Oliverde8\Component\PhpEtl\ChainProcessor

Complexity

Total Complexity

9

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	processItem()	0	15	4
A	process()	0	3	1
A	processItems()	0	11	3

<?php

namespace Oliverde8\Component\PhpEtl;

use Oliverde8\Component\PhpEtl\ChainOperation\ChainOperationInterface;
use Oliverde8\Component\PhpEtl\Item\ChainBreakItem;
use Oliverde8\Component\PhpEtl\Item\DataItem;
use Oliverde8\Component\PhpEtl\Item\GroupedItemInterface;
use Oliverde8\Component\PhpEtl\Item\ItemInterface;
use Oliverde8\Component\PhpEtl\Item\StopItem;

/**
 * Class ChainProcessor
 *
 * @author    de Cramer Oliver<oliverde8@gmail.com>
 * @copyright 2018 Oliverde8
 * @package Oliverde8\Component\PhpEtl
 */
class ChainProcessor
{
    /** @var ChainOperationInterface[] */
    protected $chainLinks = [];

    /** @var string[] */
    protected $chainLinkNames = [];

    /**
     * ChainProcessor constructor.
     *
     * @param ChainOperationInterface[] $chainLinks
     */
    public function __construct(array $chainLinks)
    {
        $this->chainLinkNames = array_keys($chainLinks);
        $this->chainLinks = array_values($chainLinks);
    }

    /**
     * Process items.
     *
     * @param \Iterator $items
     * @param $context
     */
    public function process(\Iterator $items, $context)
    {
        $this->processItems($items, 0, $context);
    }

    /**
     * Process list of items with chain starting at $startAt.
     *
     * @param \Iterator $items
     * @param int $startAt
     * @param array $context
     *
     * @return ItemInterface
     */
    protected function processItems(\Iterator $items, $startAt, &$context)
    {
        foreach ($items as $item) {
            $dataItem = new DataItem($item);
            $this->processItem($dataItem, $startAt, $context);
        }

        $stopItem = new StopItem();
        while ($this->processItem($stopItem, $startAt, $context) !== $stopItem);

        return $stopItem;
    }

    /**
     * Process an item, with chains starting at.
     *
     * @param ItemInterface $item
     * @param int $startAt
     * @param array $context
     *
     * @return ItemInterface
     */
    protected function processItem(ItemInterface $item, $startAt, &$context)
    {
        for ($chainNumber = $startAt; $chainNumber < count($this->chainLinks); $chainNumber++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $item = $this->chainLinks[$chainNumber]->process($item, $context);

            if ($item instanceof GroupedItemInterface) {
                $this->processItems($item->getIterator(), $chainNumber + 1, $context);

                return new StopItem();
            } else if ($item instanceof ChainBreakItem) {
                return $item;
            }
        }

        return $item;
    }
}