Oliverde8\Component\PhpEtl\Item\AsyncHttpClientResponseItem

Complexity

Total Complexity

8

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	isRunning()	0	12	4
A	__construct()	0	12	1
A	getItem()	0	19	3

<?php

namespace Oliverde8\Component\PhpEtl\Item;

use oliverde8\AssociativeArraySimplified\AssociativeArray;
use Symfony\Component\HttpClient\Exception\TimeoutException;

The type Symfony\Component\HttpClient\Exception\TimeoutException was not found. Maybe you did not declare it correctly or list all dependencies?

use Symfony\Component\HttpClient\Response\AsyncResponse;

The type Symfony\Component\HttpClient\Response\AsyncResponse was not found. Maybe you did not declare it correctly or list all dependencies?

use Symfony\Contracts\HttpClient\HttpClientInterface;

The type Symfony\Contracts\HttpClient\HttpClientInterface was not found. Maybe you did not declare it correctly or list all dependencies?

use Symfony\Contracts\HttpClient\ResponseInterface;

The type Symfony\Contracts\HttpClient\ResponseInterface was not found. Maybe you did not declare it correctly or list all dependencies?

class AsyncHttpClientResponseItem implements AsyncItemInterface
{
    private HttpClientInterface $client;

    private ResponseInterface $response;

    private bool $responseIsJson;

    private ?string $responseKey;

    private array $baseData;

    private bool $isRunning = true;

The private property $isRunning is not used, and could be removed.

    /**
     * @param ResponseInterface $response
     * @param bool $responseIsJson
     * @param string|null $responseKey
     * @param array $baseData
     */
    public function __construct(
        HttpClientInterface $client,
        ResponseInterface $response,
        bool $responseIsJson,
        ?string $responseKey,
        array $baseData
    ) {
        $this->client = $client;
        $this->response = $response;
        $this->responseIsJson = $responseIsJson;
        $this->responseKey = $responseKey;
        $this->baseData = $baseData;
    }


    public function isRunning(): bool
    {
        try {
            foreach ($this->client->stream($this->response, 0.01) as $chunk) {
                if ($chunk->isLast()) {
                    return false;
                }
            }

In this branch, the function will implicitly return null which is incompatible with the type-hinted return boolean. Consider adding a return statement or allowing null as return value.

        } catch (TimeoutException $exception) {
            // This is normal, we have used a very low stream timeout because we wish to continue processing
            // other items while this item is being downloaded.
            return true;
        }
    }

    public function getItem(): ItemInterface
    {
        $responseData = [
            'content' => $this->response->getContent(),
            'headers' => $this->response->getHeaders(),
            'status_code' => $this->response->getStatusCode(),
        ];
        if ($this->responseIsJson) {
            $responseData['content'] = $this->response->toArray();
        }

        $data = $this->baseData;
        if ($this->responseKey) {
            AssociativeArray::setFromKey($data, $this->responseKey, $responseData);
        } else {
            $data = $responseData;
        }

        return new DataItem($data);
    }
}