Oliverde8\Component\PhpEtl\Extract\File\Csv

Complexity

Total Complexity

16

Size/Duplication

Total Lines	146
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	setHeaders()	0	5	1
A	current()	0	5	1
A	init()	0	7	3
A	next()	0	13	2
A	valid()	0	5	2
A	getHeaders()	0	5	1
A	setStream()	0	14	3
A	rewind()	0	9	2
A	key()	0	5	1

<?php

namespace Oliverde8\Component\PhpEtl\Extract\File;

use Oliverde8\Component\PhpEtl\Model\File\AbstractCsvFile;

/**
 * Class Csv
 *
 * @author    de Cramer Oliver<oliverde8@gmail.com>
 * @copyright 2018 Oliverde8
 * @package Oliverde8\Component\PhpEtl\Loader\File
 */
class Csv extends AbstractCsvFile implements \Iterator
{
    /** @var string[] Current line */
    protected $current;

    /** @var int Number of lines read */
    protected $count = 0;

    /** @var string[] CSV file headers */
    protected $headers = null;

    /**
     * Initialize the read of the file.
     */
    protected function init()
    {
        if (is_null($this->file)) {

The condition is_null($this->file) is always false.

            if (is_string($this->filePath)) {
                $this->setStream(fopen($this->filePath, 'r'));
            } else {
                $this->setStream($this->filePath);
            }
        }
    }

    public function setStream($file)
    {
        if (!is_null($this->file)) {

The condition is_null($this->file) is always false.

            throw new \LogicException("Can't set a stream, stream already open!");
        }

        $this->file = $file;
        $headers = fgetcsv($this->file, 0, $this->delimiter, $this->enclosure, $this->escape);

        if (is_null($this->headers)) {
            $this->headers = $headers;
        }

        $this->next();
    }

    /**
     * Return file headers
     *
     * @return \string[]
     */
    public function getHeaders()
    {
        $this->init();

        return $this->headers;

The expression return $this->headers returns the type string[] which is incompatible with the documented return type string[].

    }

    /**
     * Set file headers
     *
     * @param array $headers File headers to set
     */
    public function setHeaders($headers)
    {
        $this->init();

        $this->headers = $headers;
    }

    /**
     * Return the current element
     *
     * @link http://php.net/manual/en/iterator.current.php
     * @return mixed Can return any type.
     * @since 5.0.0
     */
    public function current()
    {
        $this->init();

        return $this->current;
    }

    /**
     * Move forward to next element
     *
     * @link http://php.net/manual/en/iterator.next.php
     * @return void Any returned value is ignored.
     * @since 5.0.0
     */
    public function next()
    {
        $this->init();
        $this->count++;

        $current = fgetcsv($this->file, 0, $this->delimiter, $this->enclosure, $this->escape);

        if ($current) {

The expression $current of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->current = array_combine($this->headers, $current);
            return;
        }

        $this->current = false;

It seems like false of type false is incompatible with the declared type string[] of property $current.

    }

    /**
     * Return the key of the current element
     *
     * @link http://php.net/manual/en/iterator.key.php
     * @return mixed scalar on success, or null on failure.
     * @since 5.0.0
     */
    public function key()
    {
        $this->init();

        return $this->count;
    }

    /**
     * Checks if current position is valid
     *
     * @link http://php.net/manual/en/iterator.valid.php
     * @return boolean The return value will be casted to boolean and then evaluated.
     * Returns true on success or false on failure.
     * @since 5.0.0
     */
    public function valid()
    {
        $this->init();

        return $this->file !== false && $this->current() != false;
    }

    /**
     * Rewind the Iterator to the first element
     *
     * @link http://php.net/manual/en/iterator.rewind.php
     * @return void Any returned value is ignored.
     * @since 5.0.0
     */
    public function rewind()
    {
        if (!is_null($this->file)) {

The condition is_null($this->file) is always false.

            fclose($this->file);
            $this->count = 0;
            $this->file = null;
        }

        $this->init();
    }
}