Oliverde8\Component\PhpEtl\ChainOperation\Transformer\FilterDataOperation

Complexity

Total Complexity

6

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processData()	0	12	5
A	__construct()	0	5	1

<?php

namespace Oliverde8\Component\PhpEtl\ChainOperation\Transformer;

use Oliverde8\Component\PhpEtl\ChainOperation\AbstractChainOperation;
use Oliverde8\Component\PhpEtl\ChainOperation\DataChainOperationInterface;
use Oliverde8\Component\PhpEtl\Item\ChainBreakItem;
use Oliverde8\Component\PhpEtl\Item\DataItemInterface;
use Oliverde8\Component\PhpEtl\Item\ItemInterface;
use Oliverde8\Component\PhpEtl\Model\ExecutionContext;
use Oliverde8\Component\RuleEngine\RuleApplier;

class FilterDataOperation extends AbstractChainOperation implements DataChainOperationInterface
{
    protected RuleApplier $ruleApplier;

    protected array $rule;

    protected bool $negate;

    public function __construct(RuleApplier $ruleApplier, array $rule, bool $negate)
    {
        $this->ruleApplier = $ruleApplier;
        $this->rule = $rule;
        $this->negate = $negate;
    }


    public function processData(DataItemInterface $item, ExecutionContext $context): ItemInterface
    {
        $data = $item->getData();

        $resultData = [];
        $result = $this->ruleApplier->apply($data, $resultData, $this->rule);

        if (($this->negate && $result == false) || (!$this->negate && $result == true)) {

It seems like you are loosely comparing $result of type null|string against false; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            return $item;
        }

        return new ChainBreakItem();
    }
}