Oliverde8\Component\PhpEtl\ChainOperation\Extract\ExternalFileFinderOperation

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	processData()	0	18	4

<?php
declare(strict_types=1);

namespace Oliverde8\Component\PhpEtl\ChainOperation\Extract;

use Oliverde8\Component\PhpEtl\ChainOperation\AbstractChainOperation;
use Oliverde8\Component\PhpEtl\ChainOperation\DataChainOperationInterface;
use Oliverde8\Component\PhpEtl\Item\DataItemInterface;
use Oliverde8\Component\PhpEtl\Item\ExternalFileItem;
use Oliverde8\Component\PhpEtl\Item\ItemInterface;
use Oliverde8\Component\PhpEtl\Item\MixItem;
use Oliverde8\Component\PhpEtl\Model\ExecutionContext;
use Oliverde8\Component\PhpEtl\Model\File\FileSystemInterface;
use Symfony\Component\ExpressionLanguage\ExpressionLanguage;

class ExternalFileFinderOperation extends AbstractChainOperation implements DataChainOperationInterface
{
    protected FileSystemInterface $fileSystem;

    protected string $directory;

    private ExpressionLanguage $expressionLanguage;


    public function __construct(FileSystemInterface $fileSystem, string $directory)
    {
        $this->fileSystem = $fileSystem;
        $this->directory = $directory;

        $this->expressionLanguage = new ExpressionLanguage();

    }

    function processData(DataItemInterface $item, ExecutionContext $context): ItemInterface

It is generally recommended to explicitly declare the visibility for methods.

    {
        $pattern = $item->getData();
        $files = [];

        $directory = $this->directory;
        if (strpos($this->directory, "@") === 0) {
            $directory = ltrim($this->directory, '@');
            $directory = $this->expressionLanguage->evaluate($directory, ['context' => $context->getParameters()]);
        }

        foreach ($this->fileSystem->listContents($directory) as $file) {

It seems like $directory can also be of type array and array; however, parameter $path of Oliverde8\Component\PhpEtl\Model\File\FileSystemInterface::listContents() does only seem to accept string, maybe add an additional type check?

            if (preg_match($pattern, $file) !== 0) {
                $files[] = new ExternalFileItem($directory . "/" . $file, $this->fileSystem);

Are you sure $directory of type array|string can be used in concatenation?

            }
        }

        return new MixItem($files);
    }
}