Completed
Push — master ( 2df7ac...02da02 )
by De Cramer
19s queued 11s
created

SelectConfig::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 16
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 1 Features 0
Metric Value
eloc 3
c 1
b 1
f 0
dl 0
loc 16
rs 10
cc 1
nc 1
nop 10

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
4
namespace oliverde8\ComfyBundle\Model;
5
6
7
use oliverde8\ComfyBundle\Manager\ConfigManagerInterface;
8
use Symfony\Component\Validator\Validator\ValidatorInterface;
0 ignored issues
show
Bug introduced by
The type Symfony\Component\Valida...ator\ValidatorInterface was not found. Maybe you did not declare it correctly or list all dependencies?

The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:

filter:
    dependency_paths: ["lib/*"]

For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths

Loading history...
9
10
class SelectConfig extends TextConfig
11
{
12
    /** @var string[] */
13
    protected $options = [];
14
15
    /** @var boolean */
16
    protected $allowMultiple;
17
18
    public function __construct(
19
        ConfigManagerInterface $configManager,
20
        ValidatorInterface $validator,
21
        string $path,
22
        string $name,
23
        string $description = "",
24
        int $scope = PHP_INT_MAX,
25
        ?string $defaultValue = null,
26
        bool $isHidden = false,
27
        $options = [],
28
        $allowMultiple = false
29
    ) {
30
        parent::__construct($configManager, $validator, $path, $name, $description, $scope, $defaultValue, $isHidden);
31
32
        $this->options = $options;
33
        $this->allowMultiple = $allowMultiple;
34
    }
35
36
    /**
37
     * Serialize value to save it in Database.
38
     *
39
     * @param $value
40
     *
41
     * @return string|null
42
     */
43
    protected function serialize($value): ?string
44
    {
45
        return json_encode($value);
46
    }
47
48
    /**
49
     * Deserialize value read from database.
50
     *
51
     * @param string|null $value
52
     *
53
     * @return mixed|null
54
     */
55
    protected function deserialize(?string $value)
56
    {
57
        return json_decode($value);
0 ignored issues
show
Bug introduced by
It seems like $value can also be of type null; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

57
        return json_decode(/** @scrutinizer ignore-type */ $value);
Loading history...
58
    }
59
60
    /**
61
     * @return string[]
62
     */
63
    public function getOptions()
64
    {
65
        return $this->options;
66
    }
67
68
    /**
69
     * @return bool
70
     */
71
    public function isAllowMultiple()
72
    {
73
        return $this->allowMultiple;
74
    }
75
76
77
}
78