Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Workflow often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Workflow, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
27 | class Workflow implements WorkflowServiceInterface |
||
28 | { |
||
29 | use ServiceLocatorAwareTrait, EventManagerAwareTrait; |
||
30 | |||
31 | /** |
||
32 | * Паттерн для получения имени сервиса workflow |
||
33 | * |
||
34 | * @var string |
||
35 | */ |
||
36 | protected $workflowManagerServiceNamePattern = 'workflow.manager.%s'; |
||
37 | |||
38 | /** |
||
39 | * Конфигурация модуля |
||
40 | * |
||
41 | * @var ModuleOptions |
||
42 | */ |
||
43 | protected $moduleOptions; |
||
44 | |||
45 | /** |
||
46 | * @param $options |
||
47 | * |
||
48 | * @throws \Zend\Stdlib\Exception\InvalidArgumentException |
||
49 | * @throws \OldTown\Workflow\ZF2\Service\Exception\InvalidArgumentException |
||
50 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidArgumentException |
||
51 | */ |
||
52 | public function __construct($options) |
||
56 | |||
57 | /** |
||
58 | * Инициализация сервиса |
||
59 | * |
||
60 | * @param $options |
||
61 | * |
||
62 | * @throws \Zend\Stdlib\Exception\InvalidArgumentException |
||
63 | * @throws \OldTown\Workflow\ZF2\Service\Exception\InvalidArgumentException |
||
64 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidArgumentException |
||
65 | */ |
||
66 | protected function init($options) |
||
87 | |||
88 | /** |
||
89 | * Запуск перехода из отдного состояния в другое |
||
90 | * |
||
91 | * @param $managerName |
||
92 | * @param $entryId |
||
93 | * @param $actionName |
||
94 | * |
||
95 | * @param TransientVarsInterface $transientVars |
||
96 | * |
||
97 | * @return TransitionResultInterface |
||
98 | * |
||
99 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\DoActionException |
||
100 | */ |
||
101 | public function doAction($managerName, $entryId, $actionName, TransientVarsInterface $transientVars = null) |
||
152 | |||
153 | /** |
||
154 | * Возвращает доступные действия для текущего состояния процесса |
||
155 | * |
||
156 | * @param $managerName |
||
157 | * @param $entryId |
||
158 | * |
||
159 | * @return array|ActionDescriptor[] |
||
160 | * |
||
161 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidManagerNameException |
||
162 | * @throws \Zend\ServiceManager\Exception\ServiceNotFoundException |
||
163 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidWorkflowManagerException |
||
164 | * @throws \OldTown\Workflow\Exception\ArgumentNotNumericException |
||
165 | */ |
||
166 | public function getAvailableActions($managerName, $entryId) |
||
189 | |||
190 | |||
191 | /** |
||
192 | * Ишет действие по имени. Поиск происходит в рамках текущего step'a. |
||
193 | * |
||
194 | * @param $managerName |
||
195 | * @param $entryId |
||
196 | * @param $actionName |
||
197 | * |
||
198 | * @return ActionDescriptor|null |
||
199 | * |
||
200 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidManagerNameException |
||
201 | * @throws \Zend\ServiceManager\Exception\ServiceNotFoundException |
||
202 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidWorkflowManagerException |
||
203 | * @throws \OldTown\Workflow\Exception\ArgumentNotNumericException |
||
204 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidWorkflowActionNameException |
||
205 | * @throws \OldTown\Workflow\Exception\FactoryException |
||
206 | */ |
||
207 | public function findActionByNameForEntry($managerName, $entryId, $actionName) |
||
238 | |||
239 | /** |
||
240 | * Создание процесса workflow |
||
241 | * |
||
242 | * @param $managerName |
||
243 | * @param $workflowName |
||
244 | * @param $actionName |
||
245 | * |
||
246 | * @param TransientVarsInterface $transientVars |
||
247 | * |
||
248 | * @return TransitionResultInterface |
||
249 | * |
||
250 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidInitializeWorkflowEntryException |
||
251 | */ |
||
252 | public function initialize($managerName, $workflowName, $actionName, TransientVarsInterface $transientVars = null) |
||
306 | |||
307 | /** |
||
308 | * Конфигурация модуля |
||
309 | * |
||
310 | * @return ModuleOptions |
||
311 | */ |
||
312 | public function getModuleOptions() |
||
316 | |||
317 | /** |
||
318 | * Устанавливает конфигурацию модуля |
||
319 | * |
||
320 | * @param ModuleOptions $moduleOptions |
||
321 | * |
||
322 | * @return $this |
||
323 | */ |
||
324 | public function setModuleOptions(ModuleOptions $moduleOptions) |
||
330 | |||
331 | |||
332 | |||
333 | /** |
||
334 | * Получение менеджера workflow по имени |
||
335 | * |
||
336 | * @param string $managerName |
||
337 | * |
||
338 | * @return WorkflowInterface |
||
339 | * |
||
340 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidManagerNameException |
||
341 | * @throws \Zend\ServiceManager\Exception\ServiceNotFoundException |
||
342 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidWorkflowManagerException |
||
343 | */ |
||
344 | public function getWorkflowManager($managerName) |
||
361 | |||
362 | |||
363 | |||
364 | |||
365 | /** |
||
366 | * @param WorkflowDescriptor $wf |
||
367 | * @param $actionName |
||
368 | * |
||
369 | * @return null|ActionDescriptor |
||
370 | */ |
||
371 | public function getActionByName(WorkflowDescriptor $wf, $actionName) |
||
398 | |||
399 | /** |
||
400 | * Проверят есть ли менеджер workflow с заданным именем |
||
401 | * |
||
402 | * @param string $workflowManagerName |
||
403 | * |
||
404 | * @return bool |
||
405 | */ |
||
406 | public function hasWorkflowManager($workflowManagerName) |
||
412 | |||
413 | /** |
||
414 | * Имя сервиса для получения менеджера workflow |
||
415 | * |
||
416 | * @param string $workflowManagerName |
||
417 | * |
||
418 | * @return string |
||
419 | */ |
||
420 | public function getWorkflowManagerServiceName($workflowManagerName) |
||
424 | |||
425 | /** |
||
426 | * @return string |
||
427 | */ |
||
428 | public function getWorkflowManagerServiceNamePattern() |
||
432 | |||
433 | /** |
||
434 | * @param string $workflowManagerServiceNamePattern |
||
435 | * |
||
436 | * @return $this |
||
437 | */ |
||
438 | public function setWorkflowManagerServiceNamePattern($workflowManagerServiceNamePattern) |
||
444 | |||
445 | /** |
||
446 | * Возвращает имя менеджера по его пседовниму |
||
447 | * |
||
448 | * @param $alias |
||
449 | * |
||
450 | * @return string |
||
451 | * |
||
452 | * @throws Exception\InvalidWorkflowManagerAliasException |
||
453 | */ |
||
454 | public function getManagerNameByAlias($alias) |
||
464 | |||
465 | |||
466 | /** |
||
467 | * Проверяет есть ли псевдоним для менеджера workflow |
||
468 | * |
||
469 | * @param string $alias |
||
470 | * |
||
471 | * @return boolean |
||
472 | */ |
||
473 | public function hasWorkflowManagerAlias($alias) |
||
478 | |||
479 | /** |
||
480 | * Получение менеджера workflow по его псевдониму |
||
481 | * |
||
482 | * @param $alias |
||
483 | * |
||
484 | * @return WorkflowInterface |
||
485 | * |
||
486 | * @throws Exception\InvalidWorkflowManagerAliasException |
||
487 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidManagerNameException |
||
488 | * @throws \Zend\ServiceManager\Exception\ServiceNotFoundException |
||
489 | * @throws \OldTown\Workflow\ZF2\ServiceEngine\Exception\InvalidWorkflowManagerException |
||
490 | */ |
||
491 | public function getWorkflowManagerByAlias($alias) |
||
496 | } |
||
497 |
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.