MemoryWorkflowStore::checkExpression() - Code Metrics - Inspection of "временная заглушка. отключает корректное сохранени..." - old-town/old-town-workflow - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 138d30...5011e7 )

by Андрей
created 2016-02-25 06:00 UTC
MemoryWorkflowStore::checkExpression() F

↳ Parent: MemoryWorkflowStore
Complexity

Conditions	43
Paths	241
Size

Total Lines	197
Code Lines	117
Duplication

Lines	132
Ratio	67.01 %
Importance

Changes	3
Bugs	0	Features	0
Metric	Value
c	3
b	0
f	0
dl	132
loc	197
rs	3.4533
cc	43
eloc	117
nc	241
nop	2
How to fix Long Method Complexity

<?php
/**
 * @link    https://github.com/old-town/old-town-workflow
 * @author  Malofeykin Andrey  <[email protected]>
 */
namespace OldTown\Workflow\Spi\Memory;

use OldTown\PropertySet\PropertySetInterface;
use OldTown\PropertySet\PropertySetManager;
use OldTown\Workflow\Exception\ArgumentNotNumericException;
use OldTown\Workflow\Exception\InvalidWorkflowEntryException;
use OldTown\Workflow\Exception\NotFoundWorkflowEntryException;
use OldTown\Workflow\Query\FieldExpression;
use OldTown\Workflow\Query\NestedExpression;
use OldTown\Workflow\Query\WorkflowExpressionQuery;
use OldTown\Workflow\Spi\SimpleStep;
use OldTown\Workflow\Spi\SimpleWorkflowEntry;
use OldTown\Workflow\Spi\StepInterface;
use OldTown\Workflow\Spi\WorkflowEntryInterface;
use OldTown\Workflow\Exception\StoreException;
use DateTime;
use OldTown\Workflow\Spi\WorkflowStoreInterface;
use SplObjectStorage;
use OldTown\Workflow\Exception\InvalidArgumentException;

/**
 * Class MemoryWorkflowStore
 *
 * @package OldTown\Workflow\Spi\Memory
 */
class MemoryWorkflowStore implements WorkflowStoreInterface
{
    /**
     * @var SimpleWorkflowEntry[]
     */
    protected static $entryCache = [];

    /**
     * @var SplObjectStorage[]|SimpleStep[]
     */
    protected static $currentStepsCache = [];

    /**
     * @var SplObjectStorage[]|SimpleStep[]
     */
    protected static $historyStepsCache = [];

    /**
     * @var array
     */
    protected static $propertySetCache = [];

    /**
     * @var int
     */
    protected static $globalEntryId = 1;

    /**
     * @var int
     */
    protected static $globalStepId = 1;

    /**
     * Вызывается один раз, при инициализации хранилища
     *
     * @param array $props
     * @throws StoreException
     */
    public function init(array $props = [])
    {
        // TODO: Implement init() method.
    }

    /**
     * Возвращает PropertySet that связанный с данным экземпляром workflow
     * @param integer $entryId id workflow
     * @return PropertySetInterface
     * @throws StoreException
     * @throws \OldTown\PropertySet\Exception\RuntimeException
     * @throws \OldTown\Workflow\Exception\ArgumentNotNumericException
     */
    public function getPropertySet($entryId)

    {
        if (array_key_exists($entryId, static::$propertySetCache)) {
            return static::$propertySetCache[$entryId];
        }

        if (!is_numeric($entryId)) {
            $errMsg = sprintf('Аргумент должен быть числом. Актуальное значение %s', $entryId);
            throw new ArgumentNotNumericException($errMsg);
        }
        $entryId = (integer)$entryId;

        $ps = $this->createPropertySet();
        static::$propertySetCache[$entryId] = $ps;

        return static::$propertySetCache[$entryId];
    }

    /**
     * Создаем экземпляр PropertySet
     *
     * @return PropertySetInterface
     */
    protected function createPropertySet()
    {
        return PropertySetManager::getInstance('memory');
    }

    //~ Methods ////////////////////////////////////////////////////////////////

    /**
     * Устанавливает статус для сущности workflow с заданным id
     *
     * @param int $entryId
     * @param int $state
     *
     * @return $this
     * @throws StoreException
     * @throws NotFoundWorkflowEntryException
     * @throws ArgumentNotNumericException
     * @throws InvalidWorkflowEntryException
     */
    public function setEntryState($entryId, $state)
    {
        /** @var SimpleWorkflowEntry $theEntry */
        $theEntry = $this->findEntry($entryId);
        $theEntry->setState($state);
    }

    /**
     * Ищет сущность workflow с заданным id во внутреннем кеше
     *
     * @param int $entryId
     *
     * @return WorkflowEntryInterface
     * @throws NotFoundWorkflowEntryException
     * @throws ArgumentNotNumericException
     * @throws InvalidWorkflowEntryException
     */
    public function findEntry($entryId)
    {
        if (!is_numeric($entryId)) {
            $errMsg = sprintf('Аргумент должен быть числом. Актуальное значение %s', $entryId);
            throw new ArgumentNotNumericException($errMsg);
        }

        if (!array_key_exists($entryId, static::$entryCache)) {
            $errMsg = sprintf('Не найдена сущность workflow с id %s', $entryId);
            throw new NotFoundWorkflowEntryException($errMsg);
        }

        $entry = static::$entryCache[$entryId];

        if (!$entry instanceof WorkflowEntryInterface) {
            $errMsg = sprintf('Сущность workflow должна реализовывать интерфейс %s', WorkflowEntryInterface::class);
            throw new InvalidWorkflowEntryException($errMsg);
        }


        return $entry;
    }

    /**
     * Создает экземпляр workflow
     *
     * @param string $workflowName
     *
     * @return SimpleWorkflowEntry
     */
    public function createEntry($workflowName)
    {
        $id = static::$globalEntryId++;
        $entry = new SimpleWorkflowEntry($id, $workflowName, WorkflowEntryInterface::CREATED);
        static::$entryCache[$id] = $entry;

        return $entry;
    }

    /**
     * Создает новый шаг
     *
     * @param integer  $entryId
     * @param integer  $stepId
     * @param string   $owner
     * @param DateTime $startDate
     * @param DateTime $dueDate
     * @param string   $status
     * @param array    $previousIds
     *
     * @return SimpleStep
     */
    public function createCurrentStep($entryId, $stepId, $owner = null, DateTime $startDate, DateTime $dueDate = null, $status, array $previousIds = [])
    {
        $id = static::$globalStepId++;
        $step = new SimpleStep($id, $entryId, $stepId, 0, $owner, $startDate, $dueDate, null, $status, $previousIds, null);

        if (!array_key_exists($entryId, static::$currentStepsCache)) {
            $currentSteps = new SplObjectStorage();
            static::$currentStepsCache[$entryId] = $currentSteps;
        }


        static::$currentStepsCache[$entryId]->attach($step);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $step;
    }

    /**
     * Ищет текущий набор шагов для сущности workflow c заданным id
     *
     * @param Integer $entryId
     *
     * @return SimpleStep[]|SplObjectStorage
     * @throws ArgumentNotNumericException
     */
    public function findCurrentSteps($entryId)

    {
        if (!is_numeric($entryId)) {
            $errMsg = sprintf('Аргумент должен быть числом. Актуальное значение %s', $entryId);
            throw new ArgumentNotNumericException($errMsg);
        }
        $entryId = (integer)$entryId;

        if (!array_key_exists($entryId, static::$currentStepsCache)) {
            $currentSteps = new SplObjectStorage();
            static::$currentStepsCache[$entryId] = $currentSteps;
        }

        return static::$currentStepsCache[$entryId];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Пометить текущий шаг как выполненный
     *
     * @param StepInterface $step
     * @param integer       $actionId
     * @param DateTime      $finishDate
     * @param string        $status
     * @param string        $caller
     *
     * @return null|SimpleStep
     *
     * @throws ArgumentNotNumericException
     */
    public function markFinished(StepInterface $step, $actionId, DateTime $finishDate, $status, $caller)
    {
        $entryId = $step->getEntryId();
        $currentSteps = $this->findCurrentSteps($entryId);

        foreach ($currentSteps as $theStep) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($theStep->getId() === $step->getId()) {
                $theStep->setStatus($status);
                $theStep->setActionId($actionId);
                $theStep->setFinishDate($finishDate);
                $theStep->setCaller($caller);

                return $theStep;
            }
        }

        return null;
    }

    /**
     * Сбрасывает внутренние кеш хранилища.
     */
    public static function reset()
    {
        static::$entryCache = [];
        static::$currentStepsCache = [];
        static::$historyStepsCache = [];
        static::$propertySetCache = [];
        static::$globalEntryId = 1;
        static::$globalStepId = 1;
    }

    /**
     * Перенос шага в историю
     *
     * @param StepInterface $step
     *
     * @return void
     *
     * @throws \OldTown\Workflow\Exception\ArgumentNotNumericException
     */
    public function moveToHistory(StepInterface $step)
    {
        $entryId = $step->getEntryId();
        $currentSteps = $this->findCurrentSteps($entryId);

        if (!array_key_exists($entryId, static::$historyStepsCache)) {
            $historySteps = new SplObjectStorage();
            static::$historyStepsCache[$entryId] = $historySteps;
        }

        foreach ($currentSteps as $currentStep) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($step->getId() === $currentStep->getId()) {
                $currentSteps->detach($currentStep);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                foreach (static::$historyStepsCache[$entryId] as $historyStep) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    /** @var StepInterface $historyStep */
                    if ($historyStep->getId() === $step->getId()) {
                        static::$historyStepsCache[$entryId]->detach($historyStep);
                    }
                }

                static::$historyStepsCache[$entryId]->attach($currentStep);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

                break;
            }
        }
    }

    /**
     * Поиск по истории шагов
     *
     * @param $entryId
     *
     * @return SimpleStep[]|SplObjectStorage
     */
    public function findHistorySteps($entryId)
    {
        if (array_key_exists($entryId, static::$historyStepsCache)) {
            return static::$historyStepsCache[$entryId];

        }

        return new SplObjectStorage();
    }

    /**
     * Поиск в хранилище
     *
     * @param WorkflowExpressionQuery $query
     *
     * @return array
     *
     * @throws \OldTown\Workflow\Exception\InvalidArgumentException
     */
    public function query(WorkflowExpressionQuery $query)
    {
        $results = [];

        foreach (static::$entryCache as $entryId => $mapEntry) {
            if ($this->queryInternal($entryId, $query)) {
                $results[$entryId] = $entryId;
            }
        }

        return $results;
    }

    /**
     * Реализация поиска в харинилище
     *
     * @param integer                 $entryId
     * @param WorkflowExpressionQuery $query
     *
     * @return bool
     *
     * @throws \OldTown\Workflow\Exception\InvalidArgumentException
     */
    protected function queryInternal($entryId, WorkflowExpressionQuery $query)
    {
        $expression = $query->getExpression();

        if ($expression->isNested()) {
            return $this->checkNestedExpression($entryId, $expression);

        } else {
            return $this->checkExpression($entryId, $expression);

        }
    }

//

    /**
     * Проверка выражения
     *
     * @param integer         $entryId
     * @param FieldExpression $expression
     *
     * @return bool
     *
     * @throws InvalidArgumentException
     */
    private function checkExpression($entryId, FieldExpression $expression)
    {
        $value = $expression->getValue();
        $operator = $expression->getOperator();
        $field = $expression->getField();
        $context = $expression->getContext();

        $id = (integer)$entryId;

        if ($context === FieldExpression::ENTRY) {
            $theEntry = static::$entryCache[$id];

            if ($field === FieldExpression::NAME) {
                return $this->compareText($theEntry->getWorkflowName(), $value, $operator);
            }

            if ($field === FieldExpression::STATE) {
                if (!is_numeric($value)) {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                $valueInt = (integer)$value;

                return $this->compareLong($valueInt, $theEntry->getState(), $operator);
            }

            $errMsg = 'unknown field';
            throw new InvalidArgumentException($errMsg);
        }

        /** @var SplObjectStorage[]|SimpleStep[] $steps */
        $steps = [];

        if ($context === FieldExpression::CURRENT_STEPS) {
            $steps = array_key_exists($id, static::$currentStepsCache) ? static::$currentStepsCache[$id] : $steps;
        } elseif ($context === FieldExpression::HISTORY_STEPS) {
            $steps = array_key_exists($id, static::$historyStepsCache) ? static::$historyStepsCache[$id] : $steps;
        } else {
            $errMsg = 'unknown field context';
            throw new InvalidArgumentException($errMsg);
        }

        if (0 === count($steps)) {
            return false;
        }

        $expressionResult = false;

        switch ($field) {
            case FieldExpression::ACTION:

                if (!is_numeric($value)) {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                $actionId = (integer)$value;

                foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    if ($this->compareLong($step->getActionId(), $actionId, $operator)) {
                        $expressionResult = true;

                        break;
                    }
                }


                break;

            case FieldExpression::CALLER:

                $caller = $value;
                if ('string' !== gettype($caller)) {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    if ($this->compareText($step->getCaller(), $caller, $operator)) {
                        $expressionResult = true;

                        break;
                    }
                }

                break;

            case FieldExpression::FINISH_DATE:

                if ($value instanceof DateTime) {
                    $finishDate = $value;
                    foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                        if ($this->compareDate($step->getFinishDate(), $finishDate, $operator)) {
                            $expressionResult = true;

                            break;
                        }
                    }
                } else {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                break;

            case FieldExpression::OWNER:

                $owner = $value;
                if ('string' !== gettype($owner)) {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    if ($this->compareText($step->getOwner(), $owner, $operator)) {
                        $expressionResult = true;

                        break;
                    }
                }


                break;

            case FieldExpression::START_DATE:

                if ($value instanceof DateTime) {
                    $startDate = $value;
                    foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                        if ($this->compareDate($step->getStartDate(), $startDate, $operator)) {
                            $expressionResult = true;

                            break;
                        }
                    }
                } else {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                break;

            case FieldExpression::STEP:

                if (!is_numeric($value)) {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }
                $stepId = (integer)$value;

                foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    if ($this->compareLong($step->getStepId(), $stepId, $operator)) {
                        $expressionResult = true;

                        break;
                    }
                }

                break;

            case FieldExpression::STATUS:

                $status = $value;
                if ('string' !== gettype($status)) {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }

                foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                    if ($this->compareText($step->getStatus(), $status, $operator)) {
                        $expressionResult = true;

                        break;
                    }
                }

                break;

            case FieldExpression::DUE_DATE:

                if ($value instanceof DateTime) {
                    $dueDate = $value;
                    foreach ($steps as $step) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                        if ($this->compareDate($step->getDueDate(), $dueDate, $operator)) {
                            $expressionResult = true;

                            break;
                        }
                    }
                } else {
                    $errMsg = 'unknown field';
                    throw new InvalidArgumentException($errMsg);
                }


                break;
        }

        if ($expression->isNegate()) {
            return !$expressionResult;
        } else {
            return $expressionResult;
        }
    }

    /**
     * Проверка вложенных выражений
     *
     * @param integer          $entryId
     * @param NestedExpression $nestedExpression
     *
     * @return bool
     * @throws InvalidArgumentException
     */
    private function checkNestedExpression($entryId, NestedExpression $nestedExpression)
    {
        $expressions = $nestedExpression->getExpressions();
        foreach ($expressions as $expression) {
            if ($expression->isNested()) {
                $expressionResult = $this->checkNestedExpression($entryId, $expression);

            } else {
                $expressionResult = $this->checkExpression($entryId, $expression);

            }

            if (false === $expressionResult && $nestedExpression->getExpressionOperator() === NestedExpression::AND_OPERATOR) {
                return $nestedExpression->isNegate();
            }
            if (true === $expressionResult && $nestedExpression->getExpressionOperator() === NestedExpression::OR_OPERATOR) {
                return !$nestedExpression->isNegate();
            }
        }


        if ($nestedExpression->getExpressionOperator() === NestedExpression::AND_OPERATOR) {
            return !$nestedExpression->isNegate();
        } elseif ($nestedExpression->getExpressionOperator() === NestedExpression::OR_OPERATOR) {
            return $nestedExpression->isNegate();
        }

        $errMsg = 'unknown field';
        throw new InvalidArgumentException($errMsg);
    }

    /**
     * Сравнение дат
     *
     * @param DateTime $value1
     * @param DateTime $value2
     * @param integer  $operator
     *
     * @return bool
     * @throws InvalidArgumentException
     */
    private function compareDate(DateTime $value1, DateTime $value2, $operator)
    {
        $diff = $value1->format('U') - $value2->format('U');
        switch ($operator) {
            case FieldExpression::EQUALS:
                return $diff === 0;
            case FieldExpression::NOT_EQUALS:
                return $diff !== 0;

            case FieldExpression::GT:
                return $diff > 0;

            case FieldExpression::LT:
                return $diff < 0;
        }

        $errMsg = 'unknown field operator';
        throw new InvalidArgumentException($errMsg);
    }

    /**
     * Сравнивает целые числа
     *
     * @param string  $value1
     * @param string  $value2
     * @param integer $operator
     *
     * @return bool
     *
     * @throws InvalidArgumentException
     */
    private function compareLong($value1, $value2, $operator)
    {
        switch ($operator) {
            case FieldExpression::EQUALS:
                return $value1 === $value2;

            case FieldExpression::NOT_EQUALS:
                return $value1 !== $value2;

            case FieldExpression::GT:
                return $value1 > $value2;

            case FieldExpression::LT:
                return $value1 < $value2;
        }

        $errMsg = 'unknown field operator';
        throw new InvalidArgumentException($errMsg);
    }

    /**
     *
     * @todo поправить для юникода
     *
     * Сравнение строк
     *
     * @param $value1
     * @param $value2
     * @param $operator
     *
     * @return bool
     *
     * @throws \OldTown\Workflow\Exception\InvalidArgumentException
     */
    private function compareText($value1, $value2, $operator)
    {
        switch ($operator) {
            case FieldExpression::EQUALS:
                return $value1 === $value2;

            case FieldExpression::NOT_EQUALS:
                return $value1 !== $value2;

            case FieldExpression::GT:
                return strlen($value1) > strlen($value2);

            case FieldExpression::LT:
                return strlen($value1) < strlen($value2);
        }

        $errMsg = 'unknown field operator';
        throw new InvalidArgumentException($errMsg);
    }
}

GitHub Access Token became invalid

Push — master ( 138d30...5011e7 )

MemoryWorkflowStore::checkExpression() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* @link https://github.com/old-town/old-town-workflow
4			* @author Malofeykin Andrey <[email protected]>
5			*/
6			namespace OldTown\Workflow\Spi\Memory;
7
8			use OldTown\PropertySet\PropertySetInterface;
9			use OldTown\PropertySet\PropertySetManager;
10			use OldTown\Workflow\Exception\ArgumentNotNumericException;
11			use OldTown\Workflow\Exception\InvalidWorkflowEntryException;
12			use OldTown\Workflow\Exception\NotFoundWorkflowEntryException;
13			use OldTown\Workflow\Query\FieldExpression;
14			use OldTown\Workflow\Query\NestedExpression;
15			use OldTown\Workflow\Query\WorkflowExpressionQuery;
16			use OldTown\Workflow\Spi\SimpleStep;
17			use OldTown\Workflow\Spi\SimpleWorkflowEntry;
18			use OldTown\Workflow\Spi\StepInterface;
19			use OldTown\Workflow\Spi\WorkflowEntryInterface;
20			use OldTown\Workflow\Exception\StoreException;
21			use DateTime;
22			use OldTown\Workflow\Spi\WorkflowStoreInterface;
23			use SplObjectStorage;
24			use OldTown\Workflow\Exception\InvalidArgumentException;
25
26			/**
27			* Class MemoryWorkflowStore
28			*
29			* @package OldTown\Workflow\Spi\Memory
30			*/
31			class MemoryWorkflowStore implements WorkflowStoreInterface
32			{
33			/**
34			* @var SimpleWorkflowEntry[]
35			*/
36			protected static $entryCache = [];
37
38			/**
39			* @var SplObjectStorage[]\|SimpleStep[]
40			*/
old-town / old-town-workflow

GitHub Access Token became invalid

Push — master ( 138d30...5011e7 )

MemoryWorkflowStore::checkExpression() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
