AbstractManager::isUpToDate() - Code Metrics - Inspection of "Update AbstractManager.php" - olaurendeau/RabbitMqAdminToolkitBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 78b205...ff93a3 )

by Olivier

created 2016-02-25 09:06 UTC

AbstractManager::isUpToDate() A

↳ Parent: AbstractManager

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.0416

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
c	3
b	0
f	2
dl	0
loc	17
ccs	10
cts	12
cp	0.8333
rs	9.4285
cc	3
eloc	9
nc	3
nop	2
crap	3.0416

<?php

namespace Ola\RabbitMqAdminToolkitBundle\Manager;

use Guzzle\Http\Exception\ClientErrorResponseException;

abstract class AbstractManager
{
    /**
     * @param ClientErrorResponseException $e
     */
    protected function handleNotFoundException(ClientErrorResponseException $e)
    {
        if ($e->getResponse()->getStatusCode() !== 404) {
            throw $e;
        }
    }

    /**
     * @param $configuration
     * @param $remoteConfiguration
     *
     * @return bool
     */
    protected function isUpToDate($configuration, $remoteConfiguration)
    {
        $diff = $this->arrayDiffAssocRecursive($configuration, $remoteConfiguration);

        foreach ($remoteConfiguration as $k => $v) {
            if (!isset($configuration[$k])) {
                unset($remoteConfiguration[$k]);
            }
        }

        $diff = array_merge_recursive(
            $diff,
            $this->arrayDiffAssocRecursive($remoteConfiguration, $configuration)
        );

        return empty($diff);
    }

    private function arrayDiffAssocRecursive($array1, $array2) {
        $difference = array();
        foreach ($array1 as $key => $value) {
            if (is_array($value)) {
                if (!isset($array2[$key]) || !is_array($array2[$key])) {
                    $difference[$key] = $value;
                } else {
                    $new_diff = $this->arrayDiffAssocRecursive($value, $array2[$key]);
                    if (!empty($new_diff)) {
                        $difference[$key] = $new_diff;
                    }
                }
            } else if (!array_key_exists($key, $array2) || $array2[$key] !== $value) {
                $difference[$key] = $value;
            }
        }
        return $difference;
    }
}


1		<?php
2
3		namespace Ola\RabbitMqAdminToolkitBundle\Manager;
4
5		use Guzzle\Http\Exception\ClientErrorResponseException;
6
7		abstract class AbstractManager
8		{
9		/**
10		* @param ClientErrorResponseException $e
11		*/
12	8	protected function handleNotFoundException(ClientErrorResponseException $e)
13		{
14	8	if ($e->getResponse()->getStatusCode() !== 404) {
15	1	throw $e;
16		}
17	7	}
18
19		/**
20		* @param $configuration
21		* @param $remoteConfiguration
22		*
23		* @return bool
24		*/
25	3	protected function isUpToDate($configuration, $remoteConfiguration)
26		{
27	3	$diff = $this->arrayDiffAssocRecursive($configuration, $remoteConfiguration);
28
29	3	foreach ($remoteConfiguration as $k => $v) {
30	3	if (!isset($configuration[$k])) {
31		unset($remoteConfiguration[$k]);
32		}
33	3	}
34
35	3	$diff = array_merge_recursive(
36	3	$diff,
37	3	$this->arrayDiffAssocRecursive($remoteConfiguration, $configuration)
38	3	);
39
40	3	return empty($diff);
41		}
42
43	3	private function arrayDiffAssocRecursive($array1, $array2) {
44	3	$difference = array();
45	3	foreach ($array1 as $key => $value) {
46	3	if (is_array($value)) {
47	1	if (!isset($array2[$key]) \|\| !is_array($array2[$key])) {
48		$difference[$key] = $value;
49		} else {
50	1	$new_diff = $this->arrayDiffAssocRecursive($value, $array2[$key]);
51	1	if (!empty($new_diff)) {
52	1	$difference[$key] = $new_diff;
53	1	}
54		}
55	3	} else if (!array_key_exists($key, $array2) \|\| $array2[$key] !== $value) {
56	3	$difference[$key] = $value;
57	3	}
58	3	}
59	3	return $difference;
60		}
61		}
62

olaurendeau / RabbitMqAdminToolkitBundle

Push — master ( 78b205...ff93a3 )

AbstractManager::isUpToDate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like