okaybueno / laravel-repositories

Criteria/Eloquent/With.php

<?php

namespace OkayBueno\Repositories\Criteria\Eloquent;

use OkayBueno\Repositories\Criteria\CriteriaInterface;

/**
 * Class With
 * @package OkayBueno\Repositories\Criteria\Eloquent
 */
class With implements CriteriaInterface
{

    protected $with = NULL;

    /**
     * With constructor.
     * @param array $with
     */
    public function __construct( array $with  = [] )
    {
        $this->with = $with;
    }

    /**
    * @param mixed $queryBuilder
    * @return mixed
    */
    public function apply( $queryBuilder )
    {
        // Do something with the query builder and return it.
        if ( $this->with ) $queryBuilder->with( $this->with );

The expression $this->with of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        return $queryBuilder;
    }

}