OkayBueno\Repositories\src\Traits\Countable

Complexity

Total Complexity

9

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getAmount()	0	3	3
A	incrementCounter()	0	8	2
A	decrementCounter()	0	18	4

<?php

namespace OkayBueno\Repositories\src\Traits;

use Illuminate\Database\Eloquent\Model;

/**
 * Class Countable
 * @package OkayBueno\Repositories\Traits
 */
trait Countable
{

    /**
     * @param Model $model
     * @param $counter
     * @param int $amount
     * @return Model
     */
    public function incrementCounter( Model $model, $counter, $amount = 1 )
    {
        $amount = $this->getAmount( $amount );

        if ( $amount ) $model->increment( $counter, $amount );

The expression $amount of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

        else $model->increment( $counter );

        return $model;
    }


    /**
     * @param Model $model
     * @param $counter
     * @param int $amount
     * @param bool|FALSE $allowNegative
     * @return Model
     */
    public function decrementCounter( Model $model, $counter, $amount = 1, $allowNegative = FALSE )
    {
        $amount = $this->getAmount( $amount, 1 );

        $currentValue = $model->{$counter};
        $final = $model->{$counter} - $amount;

        if ( !$allowNegative )
        {
            if ( $currentValue && $final < 0 )
            {
                $model->{$counter} = 0;
                $model->save();
            }

        } else $model->decrement( $counter, $amount );

        return $model;
    }


    /**
     * @param $amount
     * @param null $default

Are you sure the doc-type for parameter $default is correct as it would always require null to be passed?

     * @return int|null
     */
    private function getAmount( $amount, $default = NULL )
    {
        return is_int( $amount ) && $amount > 1 ? $amount : $default;
    }
}