okaybueno / images

Services/src/ImageProcessingService.php

<?php

namespace OkayBueno\Images\Services\src;

use OkayBueno\Images\Services\ImageProcessingServiceInterface;
use Illuminate\Support\Facades\Storage;
use Intervention\Image\ImageManager;

/**
 * Class ImageProcessingService
 * @package OkayBueno\Images\Services\src
 */
class ImageProcessingService implements ImageProcessingServiceInterface
{

    protected $intervention;
    protected $disk;
    protected $diskBasePath;
    protected $availableSettings;


    /**
     * @param ImageManager $imageManager
     */
    public function __construct( ImageManager $imageManager )
    {
        $this->intervention = $imageManager;
        $this->disk = Storage::disk( config( 'images.local_disk_name', 'local' ) );

The function config was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->diskBasePath = trim( $this->disk->getAdapter()->getPathPrefix(), '/' );
        $this->availableSettings = config( 'images.processing_settings' );
    }


    /**
     * @param $imageDataOrURL
     * @param $destinationFolder
     * @return bool|string
     */
    public function createImageFromImageDataOrURL( $imageDataOrURL, $destinationFolder, array $settings = [] )
    {
        $settings = $this->parseSettings( $settings );
        $filename = md5( $imageDataOrURL  ) . '.' . $settings['extension'];
        $image = $this->intervention->make( $imageDataOrURL );

        $pathToFolderInDisk = get_path_to( $destinationFolder );
        $pathToFile = get_path_to( $destinationFolder, $filename );

        if ( !$this->disk->exists( $pathToFolderInDisk ) ) $this->disk->makeDirectory( $pathToFolderInDisk, 0775);

        try
        {
            $fullPathToImage = get_path_to( $this->diskBasePath, $destinationFolder, $filename );
            $result = $image->save( $fullPathToImage, 100 );
        } catch( \Exception $e )
        {
            $result = FALSE;
        }

        return $result ? $pathToFile : FALSE;
    }


    /**
     * @param $sourceImage
     * @param $destinationFolder
     * @param array $sizes
     * @param array $settings
     * @return array
     */
    public function resizeOrCropImageToSizes( $sourceImage, $destinationFolder, array $sizes, array $settings = [] )
    {
        $resizedImages = [];

        $sourceImage = get_path_to( $sourceImage );
        if ( $this->disk->exists( $sourceImage ) )
        {
            // Now we have to do it like this because the intervention library needs the full path.
            $fullPathToImage = get_path_to( $this->diskBasePath, $sourceImage );
            $image = $this->intervention->make( $fullPathToImage );

            if ( $image )

$image is of type Intervention\Image\Image, thus it always evaluated to true.

            {
                $image->orientate();
                $settings = $this->parseSettings( $settings );

                foreach( $sizes as $index => $size )
                {
                    $workWithThisImage = clone $image;

                    $sizesArray = explode( 'x', $size );

                    if ( count( $sizesArray ) == 2 )
                    {
                        $width = $sizesArray[0];
                        $height = $sizesArray[1];

                        $width = $width ? $width : NULL;
                        $height = $height ? $height : NULL;

                        $crop = @$settings['crop'];
                        $maintainAspectRatio = @$settings['maintain_aspect_ratio'];
                        $preventUpsizing = @$settings['prevent_upsizing'];

                        if ( !$crop )
                        {
                            $workWithThisImage->resize( $width, $height, function ($constraint) use ( $maintainAspectRatio, $preventUpsizing )

It seems like $height can also be of type string; however, parameter $height of Intervention\Image\Image::resize() does only seem to accept integer, maybe add an additional type check?

It seems like $width can also be of type string; however, parameter $width of Intervention\Image\Image::resize() does only seem to accept integer, maybe add an additional type check?

                            {
                                if ( $maintainAspectRatio ) $constraint->aspectRatio();
                                if ( $preventUpsizing ) $constraint->upsize();
                            });
                        } else
                        {
                            $workWithThisImage->fit( $width, $height, function ($constraint) use ( $preventUpsizing ) {

It seems like $width can also be of type string; however, parameter $width of Intervention\Image\Image::fit() does only seem to accept integer, maybe add an additional type check?

It seems like $height can also be of type string; however, parameter $height of Intervention\Image\Image::fit() does only seem to accept integer, maybe add an additional type check?

                                if ( $preventUpsizing ) $constraint->upsize();
                            });
                        }

                        $folderName = '_'.$size;

                        $pathInfo = pathinfo( $sourceImage );
                        $filename = @$pathInfo['filename'];

                        $extension = @$settings['extension'];
                        $extension = is_null( $extension ) ? $pathInfo['extension'] : $extension;
                        $quality = (int)@$settings['quality'];

                        $pathToFolder = get_path_to( $destinationFolder, $folderName );

                        if ( !$this->disk->exists( $pathToFolder ) ) $this->disk->makeDirectory( $pathToFolder, 0775 );

                        // Once again: intervention is not able to save the image if we don't provide the full path.
                        $finalFileName = $filename . '.' . $extension;
                        $finalPathToProcessedFile = get_path_to( $pathToFolder, $finalFileName );
                        $finalFullPathToProcessedFile = get_path_to( $this->diskBasePath, $finalPathToProcessedFile );

                        if ( !$this->disk->exists( $finalPathToProcessedFile ) ) $workWithThisImage->save( $finalFullPathToProcessedFile, $quality);

                        // Return the base path.
                        $resizedImages[ $folderName ] = $finalPathToProcessedFile;
                    }
                }
            }
        }

        return $resizedImages;
    }


    /**
     * @param array $extraSettings
     * @return array
     */
    protected function parseSettings( array $extraSettings )
    {
        $parsedSettings = [];
        foreach( $this->availableSettings as $availableSetting => $defaultValue )
        {
            if ( array_key_exists( $availableSetting, $extraSettings ) ) $parsedSettings[ $availableSetting ] = $extraSettings[ $availableSetting ];
            else $parsedSettings[ $availableSetting ] = $defaultValue;
        }

        return $parsedSettings;
    }
}