UsesDatabase::beginDatabaseTransaction() - Code Metrics - Inspection of "Add Settings model and page" - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rewrite-laravel ( eaffaa...c55a9d )

by Oliver

created 2017-06-18 13:48 UTC

UsesDatabase::beginDatabaseTransaction() A

↳ Parent: UsesDatabase

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	2
nop	0

<?php

namespace Tests;

use Illuminate\Contracts\Console\Kernel;

trait UsesDatabase
{
    /** @var string */
    protected $database = __DIR__.'/../database/testing.sqlite';

    /** @var bool */
    protected static $migrated = false;

    public function prepareDatabase($force = false)
    {
        // The database needs to be deleted before the application gets boted
        // to avoid having the database in a weird read-only state.

        if (! $force && static::$migrated) {
            return;
        }

        @unlink($this->database);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        touch($this->database);
    }

    public function setUpDatabase(callable $afterMigrations = null)
    {
        if (static::$migrated) {
            return;
        }

        $this->artisan('migrate');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->app[Kernel::class]->setArtisan(null);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if ($afterMigrations) {
            $afterMigrations();
        }

        static::$migrated = true;
    }

    public function beginDatabaseTransaction()
    {
        $database = $this->app->make('db');

        foreach ($this->connectionsToTransact() as $name) {
            $database->connection($name)->beginTransaction();
        }

        $this->beforeApplicationDestroyed(function () use ($database) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            foreach ($this->connectionsToTransact() as $name) {
                $database->connection($name)->rollBack();
            }
        });
    }

    protected function connectionsToTransact(): array
    {
        return property_exists($this, 'connectionsToTransact')
            ? $this->connectionsToTransact : [null];
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace Tests;
4
5			use Illuminate\Contracts\Console\Kernel;
6
7			trait UsesDatabase
8			{
9			/** @var string */
10			protected $database = __DIR__.'/../database/testing.sqlite';
11
12			/** @var bool */
13			protected static $migrated = false;
14
15			public function prepareDatabase($force = false)
16			{
17			// The database needs to be deleted before the application gets boted
18			// to avoid having the database in a weird read-only state.
19
20			if (! $force && static::$migrated) {
21			return;
22			}
23
24			@unlink($this->database);
			0 ignored issues – show Security Best Practice introduced 2017-06-18 13:51 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
25			touch($this->database);
26			}
27
28			public function setUpDatabase(callable $afterMigrations = null)
29			{
30			if (static::$migrated) {
31			return;
32			}
33
34			$this->artisan('migrate');
			0 ignored issues – show Bug introduced 2017-06-18 13:51 UTC by Report Bug Copy Issue Report It seems like `artisan()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35
36			$this->app[Kernel::class]->setArtisan(null);
			0 ignored issues – show Bug introduced 2017-06-18 13:51 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37
38			if ($afterMigrations) {
39			$afterMigrations();
40			}
41
42			static::$migrated = true;
43			}
44
45			public function beginDatabaseTransaction()
46			{
47			$database = $this->app->make('db');
48
49			foreach ($this->connectionsToTransact() as $name) {
50			$database->connection($name)->beginTransaction();
51			}
52
53			$this->beforeApplicationDestroyed(function () use ($database) {
			0 ignored issues – show Bug introduced 2017-06-18 13:51 UTC by Report Bug Copy Issue Report It seems like `beforeApplicationDestroyed()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54			foreach ($this->connectionsToTransact() as $name) {
55			$database->connection($name)->rollBack();
56			}
57			});
58			}
59
60			protected function connectionsToTransact(): array
61			{
62			return property_exists($this, 'connectionsToTransact')
63			? $this->connectionsToTransact : [null];
			0 ignored issues – show Bug introduced 2017-06-18 13:51 UTC by Report Bug Copy Issue Report The property `connectionsToTransact` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
64			}
65			}
66

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

Push — rewrite-laravel ( eaffaa...c55a9d )

UsesDatabase::beginDatabaseTransaction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like