Transaction::addAttachment() - Code Metrics - Inspection of "Fix format for downloading transactions" - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rewrite-laravel ( 75413a...5c1bf5 )

by Oliver

created 2017-06-07 06:57 UTC

Transaction::addAttachment() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	2

<?php

namespace App\Models;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\SoftDeletes;
use Spatie\MediaLibrary\HasMedia\HasMediaTrait;
use Spatie\MediaLibrary\HasMedia\Interfaces\HasMedia;

class Transaction extends Model implements HasMedia
{
    use SoftDeletes;
    use HasMediaTrait;

    protected $fillable = ['account_name', 'to_account_name', 'payee_name', 'category_name', 'sub_category_name', 'amount', 'notes'];

    /**
     * The attributes that should be mutated to dates.
     *
     * @var array
     */
    protected $dates = ['deleted_at'];

    public function getDateAttribute()
    {
        return $this->created_at->toDateString();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function status()
    {
        return $this->belongsTo(TransactionStatus::class);
    }

    public function type()
    {
        return $this->belongsTo(TransactionType::class);
    }

    public function addAttachment($filePath, $preventOriginal = false)
    {
        $fileName = basename($filePath);
        $media = $this->addMedia($filePath)
            ->usingFileName('Transaction_'.$this->id.'_'.$fileName);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($preventOriginal) {
            $media->preservingOriginal();
        }

        $media->toCollection('attachments');
    }
}


1			<?php
2
3			namespace App\Models;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Database\Eloquent\SoftDeletes;
7			use Spatie\MediaLibrary\HasMedia\HasMediaTrait;
8			use Spatie\MediaLibrary\HasMedia\Interfaces\HasMedia;
9
10			class Transaction extends Model implements HasMedia
11			{
12			use SoftDeletes;
13			use HasMediaTrait;
14
15			protected $fillable = ['account_name', 'to_account_name', 'payee_name', 'category_name', 'sub_category_name', 'amount', 'notes'];
16
17			/**
18			* The attributes that should be mutated to dates.
19			*
20			* @var array
21			*/
22			protected $dates = ['deleted_at'];
23
24			public function getDateAttribute()
25			{
26			return $this->created_at->toDateString();
			0 ignored issues – show Documentation introduced 2017-06-06 07:20 UTC by Report Bug Copy Issue Report The property `created_at` does not exist on `object<App\Models\Transaction>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27			}
28
29			public function status()
30			{
31			return $this->belongsTo(TransactionStatus::class);
32			}
33
34			public function type()
35			{
36			return $this->belongsTo(TransactionType::class);
37			}
38
39			public function addAttachment($filePath, $preventOriginal = false)
40			{
41			$fileName = basename($filePath);
42			$media = $this->addMedia($filePath)
43			->usingFileName('Transaction_'.$this->id.'_'.$fileName);
			0 ignored issues – show Documentation introduced 2017-06-07 07:02 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Models\Transaction>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44
45			if ($preventOriginal) {
46			$media->preservingOriginal();
47			}
48
49			$media->toCollection('attachments');
50			}
51			}
52

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

Push — rewrite-laravel ( 75413a...5c1bf5 )

Transaction::addAttachment() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like