MmexControllerTest - Code Metrics - Inspection of "Fix format for downloading transactions" - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rewrite-laravel ( 75413a...5c1bf5 )

by Oliver

created 2017-06-07 06:57 UTC

MmexControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	183
Duplicated Lines	19.13 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	11
lcom	1
cbo	3
dl	35
loc	183
rs	10
c	2
b	1
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	testDeleteAllPayees()	11	11	1
A	testImportPayees()	0	19	1
A	testDeleteAllAccounts()	11	11	1
A	testImportAccounts()	0	12	1
A	testDeleteAllCategories()	12	12	1
A	testImportCategories()	0	16	1
A	testImportSubCategories()	0	19	1
A	testDeleteTransactions()	0	11	1
B	testDownloadTransactions()	0	29	1
A	testDownloadAttachment()	0	18	1
A	addReceiptsToTransaction()	0	6	1

How to fix Duplicated Code

<?php
/**
 * MmexControllerTest.php, laravel-money-manager-ex.
 *
 * This File belongs to to Project laravel-money-manager-ex
 *
 * @author Oliver Kaufmann <[email protected]>
 *
 * @version 1.0
 */

namespace App\Tests\Api;

use App\Models\Account;
use App\Models\Category;
use App\Models\Payee;
use App\Models\Transaction;

class MmexControllerTest extends AbstractApiTestCase
{
    public function testDeleteAllPayees()

    {
        // Arrange
        $payee = factory(Payee::class)->create();
        $url = $this->buildUrl('', ['delete_payee' => 'true']);

        // Act & Assert
        $this->get($url)
            ->seeSuccess()
            ->dontSeeInDatabase('payees', ['name' => $payee->name]);
    }

    public function testImportPayees()
    {
        // Arrange
        $food = factory(Category::class)->create(['name' => 'Food']);
        $foodPurchases = factory(Category::class)->create(['name' => 'Purchases', 'parent_id' => $food->id]);
        $bills = factory(Category::class)->create(['name' => 'Bills']);
        $billsServices = factory(Category::class)->create(['name' => 'Services', 'parent_id' => $bills->id]);

        $data = ['MMEX_Post' => '{ "Payees" : [ { "PayeeName" : "Mc Donalds", "DefCateg" : "'.$food->name.'", "DefSubCateg" : "'.$foodPurchases->name.'" },'.
            '{ "PayeeName" : "Spotify", "DefCateg" : "'.$bills->name.'", "DefSubCateg" : "'.$billsServices->name.'" } ] }',];

        $url = $this->buildUrl('', ['import_payee' => 'true']);

        // Act & Assert
        $this->postJson($url, $data)
            ->seeSuccess()
            ->seeInDatabase('payees', ['name' => 'Mc Donalds', 'last_category_id' => $foodPurchases->id])
            ->seeInDatabase('payees', ['name' => 'Spotify', 'last_category_id' => $billsServices->id]);
    }

    public function testDeleteAllAccounts()

    {
        // Arrange
        $account = factory(Account::class)->create();
        $url = $this->buildUrl('', ['delete_bankaccount' => 'true']);

        // Act & Assert
        $this->get($url)
            ->seeSuccess()
            ->dontSeeInDatabase('accounts', ['name' => $account->name]);
    }

    public function testImportAccounts()
    {
        // Arrange
        $data = ['MMEX_Post' => '{ "Accounts" : [ { "AccountName" : "Creditcard" }, { "AccountName" : "Private Account" } ] }'];
        $url = $this->buildUrl('', ['import_bankaccount' => 'true']);

        // Act & Assert
        $this->postJson($url, $data)
            ->seeSuccess()
            ->seeInDatabase('accounts', ['name' => 'Creditcard'])
            ->seeInDatabase('accounts', ['name' => 'Private Account']);
    }

    public function testDeleteAllCategories()

    {
        // Arrange
        $categorie = factory(Category::class)->create();

        $url = $this->buildUrl('', ['delete_category' => 'true']);

        // Act & Assert
        $this->get($url)
            ->seeSuccess()
            ->dontSeeInDatabase('categories', ['name' => $categorie->name]);
    }

    public function testImportCategories()
    {
        // Arrange
        $data = ['MMEX_Post' => '{ "Categories" : [ { "CategoryName" : "Bills", "SubCategoryName" : "Telecom" }, { "CategoryName" : "Bills", "SubCategoryName" : "Water" }, { "CategoryName" : "Automobile", "SubCategoryName" : "Maintenance" }, { "CategoryName" : "Automobile", "SubCategoryName" : "Parking" } ] }'];
        $url = $this->buildUrl('', ['import_category' => 'true']);

        // Act & Assert
        $this->postJson($url, $data)
            ->seeSuccess()
            ->seeInDatabase('categories', ['name' => 'Bills'])
            ->seeInDatabase('categories', ['name' => 'Telecom'])
            ->seeInDatabase('categories', ['name' => 'Water'])
            ->seeInDatabase('categories', ['name' => 'Automobile'])
            ->seeInDatabase('categories', ['name' => 'Maintenance'])
            ->seeInDatabase('categories', ['name' => 'Parking']);
    }

    public function testImportSubCategories()
    {
        // Arrange
        $data = ['MMEX_Post' => '{ "Categories" : [ { "CategoryName" : "Bills", "SubCategoryName" : "Telecom" }, { "CategoryName" : "Bills", "SubCategoryName" : "Water" }, { "CategoryName" : "Automobile", "SubCategoryName" : "Maintenance" }, { "CategoryName" : "Automobile", "SubCategoryName" : "Parking" } ] }'];
        $url = $this->buildUrl('', ['import_category' => 'true']);

        $bills = factory(Category::class)->create(['name' => 'Bills']);
        $automobile = factory(Category::class)->create(['name' => 'Automobile']);

        // Act & Assert
        $this->postJson($url, $data)
            ->seeSuccess()
            ->seeInDatabase('categories', ['name' => 'Bills', 'id' => $bills->id])
            ->seeInDatabase('categories', ['name' => 'Telecom', 'parent_id' => $bills->id])
            ->seeInDatabase('categories', ['name' => 'Water', 'parent_id' => $bills->id])
            ->seeInDatabase('categories', ['name' => 'Automobile', 'id' => $automobile->id])
            ->seeInDatabase('categories', ['name' => 'Maintenance', 'parent_id' => $automobile->id])
            ->seeInDatabase('categories', ['name' => 'Parking', 'parent_id' => $automobile->id]);
    }

    public function testDeleteTransactions()
    {
        // Arrange
        $transaction = factory(Transaction::class)->create();
        $url = $this->buildUrl('', ['delete_group' => $transaction->id]);

        // Act & Assert
        $this->get($url)
            ->seeSuccess()
            ->seeIsSoftDeletedInDatabase('transactions', ['payee_name' => $transaction->payee_name]); // must not be deleted! just soft deleted.
    }

    public function testDownloadTransactions()
    {
        // Arrange
        /** @var Transaction $transaction */
        $transaction = factory(Transaction::class)->create();
        $this->addReceiptsToTransaction($transaction);
        $url = $this->buildUrl('', ['download_transaction' => 'true']);

        // Act & Assert
        $this->get($url)
            ->seeStatusCode(200)
            ->seeJson(
                [
                    'ID'          => $transaction->id,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Date'        => $transaction->date,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Account'     => $transaction->account_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'ToAccount'   => $transaction->to_account_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Status'      => $transaction->status->slug,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Type'        => $transaction->type->name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Payee'       => $transaction->payee_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Category'    => $transaction->category_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'SubCategory' => $transaction->sub_category_name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Amount'      => $transaction->amount,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Notes'       => $transaction->notes,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    'Attachments' => 'Transaction_'.$transaction->id.'_test-receipt.png;Transaction_'.$transaction->id
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        .'_test-receipt-2.png;Transaction_'.$transaction->id.'_test-receipt-3.png'
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ]
            );
    }

    /**
     * Attachment file name will be provided as comma separated list in the transaction download.
     */
    public function testDownloadAttachment()
    {
        // Arrange
        /** @var Transaction $transaction */
        $transaction = factory(Transaction::class)->create();
        $this->addReceiptsToTransaction($transaction);
        $fileName = 'Transaction_'.$transaction->id.'_test-receipt-3.png';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $url = $this->buildUrl('', ['download_attachment' => $fileName]);

        // Act & Assert
        $this->get($url)
            ->seeStatusCode(200)
            ->seeHeader('Content-Type', '')
            ->seeHeader('Cache-Control', 'public')
            ->seeHeader('Content-Description', 'File Transfer')
            ->seeHeader('Content-Disposition', 'attachment; filename= '.$fileName)
            ->seeHeader('Content-Transfer-Encoding', 'binary');
    }

    /**
     * @param $transaction
     */
    protected function addReceiptsToTransaction(Transaction $transaction)
    {
        $transaction->addAttachment(base_path('tests/data/test-receipt.png'), true);
        $transaction->addAttachment(base_path('tests/data/test-receipt-2.png'), true);
        $transaction->addAttachment(base_path('tests/data/test-receipt-3.png'), true);
    }
}


1		<?php
2		/**
3		* MmexControllerTest.php, laravel-money-manager-ex.
4		*
5		* This File belongs to to Project laravel-money-manager-ex
6		*
7		* @author Oliver Kaufmann <[email protected]>
8		*
9		* @version 1.0
10		*/
11
12		namespace App\Tests\Api;
13
14		use App\Models\Account;
15		use App\Models\Category;
16		use App\Models\Payee;
17		use App\Models\Transaction;
18
19		class MmexControllerTest extends AbstractApiTestCase
20		{
21	View Code Duplication	public function testDeleteAllPayees()
		0 ignored issues – show Duplication introduced 2016-11-02 08:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		// Arrange
24		$payee = factory(Payee::class)->create();
25		$url = $this->buildUrl('', ['delete_payee' => 'true']);
26
27		// Act & Assert
28		$this->get($url)
29		->seeSuccess()
30		->dontSeeInDatabase('payees', ['name' => $payee->name]);
31		}
32
33		public function testImportPayees()
34		{
35		// Arrange
36		$food = factory(Category::class)->create(['name' => 'Food']);
37		$foodPurchases = factory(Category::class)->create(['name' => 'Purchases', 'parent_id' => $food->id]);
38		$bills = factory(Category::class)->create(['name' => 'Bills']);
39		$billsServices = factory(Category::class)->create(['name' => 'Services', 'parent_id' => $bills->id]);

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

Push — rewrite-laravel ( 75413a...5c1bf5 )

MmexControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like