App\Services\MmexService

Complexity

Total Complexity

17

Size/Duplication

Total Lines	129
Duplicated Lines	21.71 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes	4
Bugs	2	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getTransactions()	0	23	1
A	deleteAccounts()	0	5	1
A	importBankAccounts()	0	9	2
A	deletePayees()	0	5	1
B	importPayees()	0	24	3
A	deleteCategories()	0	5	1
A	importCategories()	0	14	3
A	createOrGetCategory()	14	14	2
A	createOrGetSubCategory()	14	14	2
A	deleteTransactions()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: okaufmann
 * Date: 22.10.2016
 * Time: 14:53.
 */

namespace App\Services;

use App\Models\Account;
use App\Models\Category;
use App\Models\Payee;
use App\Models\Transaction;
use Log;

class MmexService
{
    public function getTransactions()
    {
        $transactions = Transaction::all();

        return $transactions;
        // example

49% of this comment could be valid code. Did you maybe forget this after debugging?

//        return [
//            0 => [
//                'ID'          => 1,
//                'Date'        => '2016-10-07',
//                'Account'     => 'Another Account',
//                'ToAccount'   => 'None',
//                'Status'      => 'R',
//                'Type'        => 'Zahlung',
//                'Payee'       => 'Migros',
//                'Category'    => 'Einkauf',
//                'SubCategory' => 'Etwas anderes',
//                'Amount'      => '123',
//                'Notes'       => "Das ist ein \r\nMeeeeehrzeiliger \r\nText",
//                'Attachments' => 'Transaction_1_Attach1.png;Transaction_1_Attach2.jpg',
//            ],
//        ];
    }

    public function deleteAccounts()
    {
        // TODO: find better method than where hack
        Account::where('id', '>', 0)->delete();
    }

    public function importBankAccounts($postData)
    {
        Log::debug('MmexController.importBankAccounts(), $accounts', [$postData->Accounts]);
        foreach ($postData->Accounts as $account) {
            Account::create([
                'name' => $account->AccountName,
            ]);
        }
    }

    public function deletePayees()
    {
        // TODO: find better method than where hack
        Payee::where('id', '>', 0)->delete();
    }

    public function importPayees($postData)
    {
        Log::debug('MmexController.importPayees(), $payees', [$postData->Payees]);

        foreach ($postData->Payees as $payee) {
            $categoryName = $payee->DefCateg;
            $subCategoryName = $payee->DefSubCateg;

            $category = Category::where('name', $subCategoryName)->whereHas('parentCategory', function ($query) use ($categoryName) {
                $query->where('name', $categoryName);
            })->first();

            if ($category) {
                $category->defaultForPayees()->create([
                    'name' => $payee->PayeeName,
                ]);
            } else {
                // ignore default/last category and just create entry
                Payee::create([
                    'name' => $payee->PayeeName,
                ]);
            }
        }
    }

    public function deleteCategories()
    {
        // TODO: find better method than where hack
        Category::where('id', '>', 0)->delete();
    }

    public function importCategories($postData)
    {
        $categories = collect($postData->Categories);

        $grouped = $categories->groupBy('CategoryName');

        foreach ($grouped as $categoryName => $subCategories) {
            $category = $this->createOrGetCategory($categoryName);

            foreach ($subCategories as $subCategory) {
                $this->createOrGetSubCategory($category, $subCategory->SubCategoryName);
            }
        }
    }

    private function createOrGetCategory($name)

This method seems to be duplicated in your project.

    {
        $existingCategory = Category::whereName($name)->first();

        if ($existingCategory) {
            return $existingCategory;
        }

        $newCategory = Category::create([
            'name' => $name,
        ]);

        return $newCategory;
    }

    private function createOrGetSubCategory(Category $parentCategory, $name)

This method seems to be duplicated in your project.

    {
        $existingCategory = Category::whereName($name)->first();

        if ($existingCategory) {
            return $existingCategory;
        }

        $newCategory = $parentCategory->subCategories()->create([
            'name' => $name,
        ]);

        return $newCategory;
    }

    public function deleteTransactions($transactionId)
    {
        Transaction::whereId($transactionId)->delete();
    }
}