DbUtils - Code Metrics - Inspection of "Upgrade to latest medialibrary" - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rewrite-laravel ( ad2267...b1fe86 )

by Oliver

created 2017-06-07 19:38 UTC

DbUtils A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	61
Duplicated Lines	59.02 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	0
dl	36
loc	61
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	seeIsNotSoftDeletedInDatabase()	18	18	2
A	seeIsSoftDeletedInDatabase()	18	18	2

How to fix Duplicated Code

<?php
/*
 * laravel-money-manager-ex
 *
 * This File belongs to to Project laravel-money-manager-ex
 *
 * @author Oliver Kaufmann <[email protected]>
 * @version 1.0
 */

namespace Tests\utils;


trait DbUtils
{

    /**
     * Assert that a given where condition does not matches a soft deleted record
     * From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
     *
     * @param string $table
     * @param array $data
     * @param string $connection
     *
     * @return $this
     */
    protected function seeIsNotSoftDeletedInDatabase($table, array $data, $connection = null)

    {
        $database = $this->app->make('db');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $connection = $connection ?: $database->getDefaultConnection();

        $count = $database->connection($connection)
            ->table($table)
            ->where($data)
            ->whereNull('deleted_at')
            ->count();

        $this->assertGreaterThan(0, $count, sprintf(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
        ));

        return $this;
    }

    /**
     * Assert that a given where condition matches a soft deleted record
     * From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
     *
     * @param string $table
     * @param array $data
     * @param string $connection
     *
     * @return $this
     */
    protected function seeIsSoftDeletedInDatabase($table, array $data, $connection = null)

    {
        $database = $this->app->make('db');

        $connection = $connection ?: $database->getDefaultConnection();

        $count = $database->connection($connection)
            ->table($table)
            ->where($data)
            ->whereNotNull('deleted_at')
            ->count();

        $this->assertGreaterThan(0, $count, sprintf(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
        ));

        return $this;
    }
}

1		<?php
2		/*
3		* laravel-money-manager-ex
4		*
5		* This File belongs to to Project laravel-money-manager-ex
6		*
7		* @author Oliver Kaufmann <[email protected]>
8		* @version 1.0
9		*/
10
11		namespace Tests\utils;
12
13
14		trait DbUtils
15		{
16
17		/**
18		* Assert that a given where condition does not matches a soft deleted record
19		* From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
20		*
21		* @param string $table
22		* @param array $data
23		* @param string $connection
24		*
25		* @return $this
26		*/
27	View Code Duplication	protected function seeIsNotSoftDeletedInDatabase($table, array $data, $connection = null)
		0 ignored issues – show Duplication introduced 2017-06-06 07:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		{
29		$database = $this->app->make('db');
		0 ignored issues – show Bug introduced 2017-06-07 19:45 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30
31		$connection = $connection ?: $database->getDefaultConnection();
32
33		$count = $database->connection($connection)
34		->table($table)
35		->where($data)
36		->whereNull('deleted_at')
37		->count();
38
39		$this->assertGreaterThan(0, $count, sprintf(
		0 ignored issues – show Bug introduced 2017-06-07 19:45 UTC by Report Bug Copy Issue Report It seems like `assertGreaterThan()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
41		));
42
43		return $this;
44		}
45
46		/**
47		* Assert that a given where condition matches a soft deleted record
48		* From: http://stackoverflow.com/questions/33117746/laravel-unit-testing-how-to-seeindatabase-soft-deleted-row.
49		*
50		* @param string $table
51		* @param array $data
52		* @param string $connection
53		*
54		* @return $this
55		*/
56	View Code Duplication	protected function seeIsSoftDeletedInDatabase($table, array $data, $connection = null)
		0 ignored issues – show Duplication introduced 2017-06-06 07:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$database = $this->app->make('db');
59
60		$connection = $connection ?: $database->getDefaultConnection();
61
62		$count = $database->connection($connection)
63		->table($table)
64		->where($data)
65		->whereNotNull('deleted_at')
66		->count();
67
68		$this->assertGreaterThan(0, $count, sprintf(
		0 ignored issues – show Bug introduced 2017-06-07 19:45 UTC by Report Bug Copy Issue Report It seems like `assertGreaterThan()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
69		'Found unexpected records in database table [%s] that matched attributes [%s].', $table, json_encode($data)
70		));
71
72		return $this;
73		}
74		}

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

Push — rewrite-laravel ( ad2267...b1fe86 )

DbUtils A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like