TransactionRequest::rules() - Code Metrics - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

TransactionRequest::rules() B
last analyzed 2017-10-18 00:22 UTC

↳ Parent: TransactionRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	20
nc	1
nop	0
dl	0
loc	26
rs	8.8571
c	2
b	0
f	0

<?php

namespace App\Http\Requests\Api;

use Carbon\Carbon;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Validation\Rule;

class TransactionRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Get custom messages for validator errors.
     *
     * @return array
     */
    public function messages()
    {
        return [
            'account.exists'            => 'no entry found for account',
            'transaction_status.exists' => 'no entry found for transaction_status',
            'transaction_type.exists'   => 'no entry found for transaction_type',
            'category.exists'           => 'no entry found for category',
            'subcategory.exists'        => 'no entry found for subcategory',
        ];
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'transaction_date'   => 'nullable|date|date_format:'.Carbon::ATOM,
            'transaction_status' => 'string|exists:transaction_status,name',
            'transaction_type'   => 'required|string|exists:transaction_types,name',
            'account'            => [
                'required',
                'string',
                Rule::exists('accounts', 'name')->where('user_id', auth()->user()->id),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ],
            'to_account'         => 'sometimes|required|string',
            'payee'              => 'sometimes|required|string',
            'category'           => [
                'required',
                'string',
                Rule::exists('categories', 'name')->where('user_id', auth()->user()->id)->whereNull('parent_id'),
            ],
            'subcategory'        => [
                'string',
                Rule::exists('categories', 'name')->where('user_id', auth()->user()->id)->whereNotNull('parent_id'),
            ],
            'amount'             => 'required|numeric|min:0|max:999999',
            'notes'              => 'string|nullable',
        ];
    }
}


GitHub Access Token became invalid

TransactionRequest::rules() B
last analyzed 2017-10-18 00:22 UTC

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2
3			namespace App\Http\Requests\Api;
4
5			use Carbon\Carbon;
6			use Illuminate\Foundation\Http\FormRequest;
7			use Illuminate\Validation\Rule;
8
9			class TransactionRequest extends FormRequest
10			{
11			/**
12			* Determine if the user is authorized to make this request.
13			*
14			* @return bool
15			*/
16			public function authorize()
17			{
18			return true;
19			}
20
21			/**
22			* Get custom messages for validator errors.
23			*
24			* @return array
25			*/
26			public function messages()
27			{
28			return [
29			'account.exists' => 'no entry found for account',
30			'transaction_status.exists' => 'no entry found for transaction_status',
31			'transaction_type.exists' => 'no entry found for transaction_type',
32			'category.exists' => 'no entry found for category',
33			'subcategory.exists' => 'no entry found for subcategory',
34			];
35			}
36
37			/**
38			* Get the validation rules that apply to the request.
39			*
40			* @return array
41			*/
42			public function rules()
43			{
44			return [
45			'transaction_date' => 'nullable\|date\|date_format:'.Carbon::ATOM,
46			'transaction_status' => 'string\|exists:transaction_status,name',
47			'transaction_type' => 'required\|string\|exists:transaction_types,name',
48			'account' => [
49			'required',
50			'string',
51			Rule::exists('accounts', 'name')->where('user_id', auth()->user()->id),
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
52			],
53			'to_account' => 'sometimes\|required\|string',
54			'payee' => 'sometimes\|required\|string',
55			'category' => [
56			'required',
57			'string',
58			Rule::exists('categories', 'name')->where('user_id', auth()->user()->id)->whereNull('parent_id'),
59			],
60			'subcategory' => [
61			'string',
62			Rule::exists('categories', 'name')->where('user_id', auth()->user()->id)->whereNotNull('parent_id'),
63			],
64			'amount' => 'required\|numeric\|min:0\|max:999999',
65			'notes' => 'string\|nullable',
66			];
67			}
68			}
69

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

TransactionRequest::rules() B last analyzed 2017-10-18 00:22 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

TransactionRequest::rules() B
last analyzed 2017-10-18 00:22 UTC