Tests\UsesDatabase

Complexity

Total Complexity

10

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUpDatabase()	0	16	3
A	prepareDatabase()	0	12	2
A	beginDatabaseTransaction()	0	14	3
A	connectionsToTransact()	0	5	2

<?php

namespace Tests;

use Illuminate\Contracts\Console\Kernel;

trait UsesDatabase
{
    /** @var string */
    protected $database = __DIR__.'/../database/testing.sqlite';

    /** @var bool */
    protected static $migrated = false;

    public function prepareDatabase()
    {
        // The database needs to be deleted before the application gets boted
        // to avoid having the database in a weird read-only state.

        if (static::$migrated) {
            return;
        }

        @unlink($this->database);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        touch($this->database);
    }

    public function setUpDatabase(callable $afterMigrations = null)
    {
        if (static::$migrated) {
            return;
        }

        $this->artisan('migrate');

It seems like artisan() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->app[Kernel::class]->setArtisan(null);

The property app does not exist. Did you maybe forget to declare it?

        if ($afterMigrations) {
            $afterMigrations();
        }

        static::$migrated = true;
    }

    /**
     * Handle database transactions on the specified connections.
     *
     * @return void
     */
    public function beginDatabaseTransaction()
    {
        $database = $this->app->make('db');

        foreach ($this->connectionsToTransact() as $name) {
            $database->connection($name)->beginTransaction();
        }

        $this->beforeApplicationDestroyed(function () use ($database) {

It seems like beforeApplicationDestroyed() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            foreach ($this->connectionsToTransact() as $name) {
                $database->connection($name)->rollBack();
            }
        });
    }

    /**
     * The database connections that should have transactions.
     *
     * @return array
     */
    protected function connectionsToTransact()
    {
        return property_exists($this, 'connectionsToTransact')
            ? $this->connectionsToTransact : [null];

The property connectionsToTransact does not exist. Did you maybe forget to declare it?

    }
}