ohdearapp / ohdear-php-sdk

src/Actions/ManagesPerformance.php

<?php

namespace OhDear\PhpSdk\Actions;

use OhDear\PhpSdk\Resources\PerformanceRecord;

trait ManagesPerformance
{
    /**
     * @param int $siteId
     * @param string $start Short (2020-12-01) or long (2020-12-01 15:00:00) date format
     * @param string $end Short (2020-12-01) or long (2020-12-01 15:00:00) date format
     * @param string $timeframe Should be 1m or 1h
     *
     * @return array
     */
    public function performanceRecords(int $siteId, string $start, string $end, string $timeframe = '1m'): array
    {
        $start = $this->convertDateFormat($start);

It seems like convertDateFormat() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $end = $this->convertDateFormat($end);

        return $this->transformCollection(

It seems like transformCollection() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->get("sites/$siteId/performance-records?filter[start]={$start}&filter[end]={$end}&filter[timeframe]={$timeframe}"),

It seems like get() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            PerformanceRecord::class
        );
    }
}