ManagesSites::stopSiteMaintenance() - Code Metrics - Inspection of "Extend abillity to manage maintenance periods" - ohdearapp/ohdear-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

unknown

created 2020-05-15 18:05 UTC

ManagesSites::stopSiteMaintenance() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace OhDear\PhpSdk\Actions;

use OhDear\PhpSdk\Resources\Site;

trait ManagesSites
{
    public function sites(): array
    {
        return $this->transformCollection(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->get('sites')['data'],
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Site::class
        );
    }

    public function site(int $siteId): Site
    {
        $siteAttributes = $this->get("sites/{$siteId}");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Site($siteAttributes, $this);
    }

    public function siteByUrl(string $siteUrl): Site
    {
        $siteAttributes = $this->get("sites/url/{$siteUrl}");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Site($siteAttributes, $this);
    }

    public function createSite(array $data): Site
    {
        $siteAttributes = $this->post('sites', $data);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Site($siteAttributes, $this);
    }

    public function deleteSite(int $siteId)
    {
        $this->delete("sites/$siteId");

    }
}


1			<?php
2
3			namespace OhDear\PhpSdk\Actions;
4
5			use OhDear\PhpSdk\Resources\Site;
6
7			trait ManagesSites
8			{
9			public function sites(): array
10			{
11			return $this->transformCollection(
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `transformCollection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
12			$this->get('sites')['data'],
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
13			Site::class
14			);
15			}
16
17			public function site(int $siteId): Site
18			{
19			$siteAttributes = $this->get("sites/{$siteId}");
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20
21			return new Site($siteAttributes, $this);
22			}
23
24			public function siteByUrl(string $siteUrl): Site
25			{
26			$siteAttributes = $this->get("sites/url/{$siteUrl}");
			0 ignored issues – show Bug introduced 2018-09-01 11:49 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27
28			return new Site($siteAttributes, $this);
29			}
30
31			public function createSite(array $data): Site
32			{
33			$siteAttributes = $this->post('sites', $data);
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34
35			return new Site($siteAttributes, $this);
36			}
37
38			public function deleteSite(int $siteId)
39			{
40			$this->delete("sites/$siteId");
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report The method `delete()` does not exist on `OhDear\PhpSdk\Actions\ManagesSites`. Did you maybe mean `deleteSite()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
41			}
42			}
43

ohdearapp / ohdear-php-sdk

Pull Request — master (#13)

ManagesSites::stopSiteMaintenance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like