ManagesChecks - Code Metrics - Inspection of "Add support for snoozing and unsnoozing check noti..." - ohdearapp/ohdear-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00611e...d96c30 )

unknown

created 2020-05-13 07:31 UTC

ManagesChecks A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	5
lcom	0
cbo	1
dl	0
loc	39
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	enableCheck()	6	1
A	disableCheck()	6	1
A	requestRun()	6	1
A	snooze()	8	1
A	unsnooze()	6	1

<?php

namespace OhDear\PhpSdk\Actions;

use OhDear\PhpSdk\Resources\Check;

trait ManagesChecks
{
    public function enableCheck(int $checkId): Check
    {
        $checkAttributes = $this->post("checks/{$checkId}/enable");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Check($checkAttributes, $this);
    }

    public function disableCheck(int $checkId): Check
    {
        $checkAttributes = $this->post("checks/{$checkId}/disable");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Check($checkAttributes, $this);
    }

    public function requestRun(int $checkId): Check
    {
        $checkAttributes = $this->post("checks/{$checkId}/request-run");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Check($checkAttributes, $this);
    }

    public function snooze(int $checkId, int $minutes)
    {
        $checkAttributes = $this->post("checks/{$checkId}/snooze", [
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'minutes' => $minutes,
        ]);

        return new Check($checkAttributes, $this);
    }

    public function unsnooze(int $checkId): Check
    {
        $checkAttributes = $this->post("checks/{$checkId}/unsnooze");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return new Check($checkAttributes, $this);
    }
}


1			<?php
2
3			namespace OhDear\PhpSdk\Actions;
4
5			use OhDear\PhpSdk\Resources\Check;
6
7			trait ManagesChecks
8			{
9			public function enableCheck(int $checkId): Check
10			{
11			$checkAttributes = $this->post("checks/{$checkId}/enable");
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
12
13			return new Check($checkAttributes, $this);
14			}
15
16			public function disableCheck(int $checkId): Check
17			{
18			$checkAttributes = $this->post("checks/{$checkId}/disable");
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19
20			return new Check($checkAttributes, $this);
21			}
22
23			public function requestRun(int $checkId): Check
24			{
25			$checkAttributes = $this->post("checks/{$checkId}/request-run");
			0 ignored issues – show Bug introduced 2017-11-03 17:29 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26
27			return new Check($checkAttributes, $this);
28			}
29
30			public function snooze(int $checkId, int $minutes)
31			{
32			$checkAttributes = $this->post("checks/{$checkId}/snooze", [
			0 ignored issues – show Bug introduced 2020-05-13 07:32 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33			'minutes' => $minutes,
34			]);
35
36			return new Check($checkAttributes, $this);
37			}
38
39			public function unsnooze(int $checkId): Check
40			{
41			$checkAttributes = $this->post("checks/{$checkId}/unsnooze");
			0 ignored issues – show Bug introduced 2020-05-13 07:32 UTC by Report Bug Copy Issue Report It seems like `post()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42
43			return new Check($checkAttributes, $this);
44			}
45			}
46

ohdearapp / ohdear-php-sdk

Push — master ( 00611e...d96c30 )

ManagesChecks A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like