Odiseo\SyliusVendorPlugin\Repository\VendorRepository

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes	2
Bugs	2	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	findByEnabledQueryBuilder()	0	15	2
A	findOneBySlug()	0	12	1
A	findByChannel()	0	3	1
A	createShopListQueryBuilder()	0	5	1

<?php

declare(strict_types=1);

namespace Odiseo\SyliusVendorPlugin\Repository;

use Doctrine\ORM\QueryBuilder;
use Odiseo\SyliusVendorPlugin\Entity\VendorInterface;
use Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepository;
use Sylius\Component\Core\Model\ChannelInterface;

class VendorRepository extends EntityRepository implements VendorRepositoryInterface
{
    /**
     * {@inheritdoc}
     */
    public function createShopListQueryBuilder(
        ChannelInterface $channel,
        array $sorting = []
    ): QueryBuilder {
        return $this->findByEnabledQueryBuilder($channel);
    }

    /**
     * {@inheritdoc}
     */
    public function findByEnabledQueryBuilder(?ChannelInterface $channel): QueryBuilder
    {
        $queryBuilder = $this->createQueryBuilder('o')
            ->andWhere('o.enabled = :enabled')
            ->setParameter('enabled', true)
        ;

        if ($channel instanceof ChannelInterface) {
            $queryBuilder->innerJoin('o.channels', 'channel')
                ->andWhere('channel = :channel')
                ->setParameter('channel', $channel)
            ;
        }

        return $queryBuilder;
    }

    /**
     * {@inheritdoc}
     */
    public function findByChannel(ChannelInterface $channel): array
    {
        return $this->findByEnabledQueryBuilder($channel)->getQuery()->getResult();

The expression return $this->findByEnabledQueryBuilder($channel)->getQuery()->getResult() could return the type integer which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }

    /**
     * {@inheritdoc}
     */
    public function findOneBySlug(string $slug, string $locale): ?VendorInterface
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->addSelect('translation')->innerJoin('o.translations', 'translation')->andWhere('o.slug = :slug')->andWhere('o.enabled = true')->andWhere('translation.locale = :locale')->setParameter('slug', $slug)->setParameter('locale', $locale)->getQuery()->getOneOrNullResult() could return the type integer which is incompatible with the type-hinted return Odiseo\SyliusVendorPlugin\Entity\VendorInterface|null. Consider adding an additional type-check to rule them out.

            ->addSelect('translation')
            ->innerJoin('o.translations', 'translation')
            ->andWhere('o.slug = :slug')
            ->andWhere('o.enabled = true')
            ->andWhere('translation.locale = :locale')
            ->setParameter('slug', $slug)
            ->setParameter('locale', $locale)
            ->getQuery()
            ->getOneOrNullResult()
        ;
    }
}