odiseoteam / SyliusReportPlugin

spec/DataFetcher/DelegatingDataFetcherSpec.php

<?php

namespace spec\Odiseo\SyliusReportPlugin\DataFetcher;

use Odiseo\SyliusReportPlugin\DataFetcher\Data;
use Odiseo\SyliusReportPlugin\DataFetcher\DataFetcherInterface;
use Odiseo\SyliusReportPlugin\DataFetcher\DefaultDataFetchers;
use Odiseo\SyliusReportPlugin\DataFetcher\DelegatingDataFetcher;
use Odiseo\SyliusReportPlugin\DataFetcher\DelegatingDataFetcherInterface;
use Odiseo\SyliusReportPlugin\DataFetcher\UserRegistrationDataFetcher;
use Odiseo\SyliusReportPlugin\Model\ReportInterface;
use PhpSpec\ObjectBehavior;
use Sylius\Component\Registry\ServiceRegistryInterface;

/**
 * @author Diego D'amico <diego@odiseo.com.ar>
 */
class DelegatingDataFetcherSpec extends ObjectBehavior
{
    function let(ServiceRegistryInterface $registry)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->beConstructedWith($registry);
    }

    function it_is_initializable()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldHaveType(DelegatingDataFetcher::class);
    }

    function it_should_implement_delegating_data_fetcher_interface()
    {
        $this->shouldImplement(DelegatingDataFetcherInterface::class);
    }

    function it_get_the_data_fetcher_with_given_report(ReportInterface $report, ServiceRegistryInterface $registry, UserRegistrationDataFetcher $userRegistrationDataFetcher)
    {
        $report->getDataFetcher()->willReturn(DefaultDataFetchers::USER_REGISTRATION);
        $registry->get(DefaultDataFetchers::USER_REGISTRATION)->willReturn($userRegistrationDataFetcher);
        $this->getDataFetcher($report)->shouldReturn($userRegistrationDataFetcher);

The method getDataFetcher() does not exist on spec\Odiseo\SyliusReportPlugin\DataFetcher\DelegatingDataFetcherSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_fetch_the_data_with_given_report_configuration(ReportInterface $report, DataFetcherInterface $dataFetcher, ServiceRegistryInterface $registry)
    {
        $reportConfiguration = [
            'start' => new \DateTime('1918-01-01 00:00:00.000000'),
            'end' => new \DateTime(),
            'period' => 'month',
            'empty_records' => false
        ];
        $otherConfiguration = [
        ];
        $data = new Data();

        $report->getDataFetcher()->willReturn(DefaultDataFetchers::USER_REGISTRATION);
        $registry->get(DefaultDataFetchers::USER_REGISTRATION)->willReturn($dataFetcher);
        $report->getDataFetcherConfiguration()->willReturn($reportConfiguration);
        $dataFetcher->fetch($reportConfiguration)->willReturn($data);

The method willReturn() does not exist on Odiseo\SyliusReportPlugin\DataFetcher\Data.

        $this->fetch($report, $otherConfiguration)->shouldReturn($data);

The method fetch() does not exist on spec\Odiseo\SyliusReportPlugin\DataFetcher\DelegatingDataFetcherSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_fetch_the_data_with_given_parameter_configuration(ReportInterface $report, DataFetcherInterface $dataFetcher, ServiceRegistryInterface $registry)
    {
        $reportConfiguration = [
            'start' => new \DateTime('1918-01-01 00:00:00.000000'),
            'end' => new \DateTime(),
            'period' => 'month',
            'empty_records' => false
        ];
        $otherConfiguration = [
            'otherConfiguration' => 'test'
        ];
        $data = new Data();

        $report->getDataFetcher()->willReturn(DefaultDataFetchers::USER_REGISTRATION);
        $registry->get(DefaultDataFetchers::USER_REGISTRATION)->willReturn($dataFetcher);
        $report->getDataFetcherConfiguration()->willReturn($reportConfiguration);
        $dataFetcher->fetch($otherConfiguration)->willReturn($data);

        $this->fetch($report, $otherConfiguration)->shouldReturn($data);
    }
}