Odiseo\SyliusReportPlugin\Controller\Action\ProvinceSearchAction

Complexity

Total Complexity

7

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getProvinceName()	0	13	2
A	__construct()	0	9	1
A	getAddresses()	0	22	3
A	__invoke()	0	9	1

<?php

declare(strict_types=1);

namespace Odiseo\SyliusReportPlugin\Controller\Action;

use FOS\RestBundle\View\View;
use FOS\RestBundle\View\ViewHandler;
use FOS\RestBundle\View\ViewHandlerInterface;
use Odiseo\SyliusReportPlugin\Repository\AddressRepositoryInterface;
use Sylius\Component\Addressing\Model\ProvinceInterface;
use Sylius\Component\Core\Model\AddressInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

final class ProvinceSearchAction
{
    /** @var AddressRepositoryInterface */
    private $addressRepository;

    /** @var RepositoryInterface */
    private $provinceRepository;

    /** @var ViewHandlerInterface */
    private $viewHandler;

    public function __construct(
        AddressRepositoryInterface $addressRepository,
        RepositoryInterface $provinceRepository,
        ViewHandler $viewHandler
    )
    {
        $this->addressRepository = $addressRepository;
        $this->provinceRepository = $provinceRepository;
        $this->viewHandler = $viewHandler;
    }

    public function __invoke(Request $request): Response
    {
        $addresses = $this->getAddresses($request->get('province', ''));
        $view = View::create($addresses);

        $this->viewHandler->setExclusionStrategyGroups(['Autocomplete']);
        $view->getContext()->enableMaxDepth();

        return $this->viewHandler->handle($view);
    }

    private function getAddresses($query): array
    {
        $addresses = [];
        $searchAddresses = $this->addressRepository->findByProvinceName($query);

        /** @var AddressInterface $address */
        foreach ($searchAddresses as $address) {
            $provinceName = $this->getProvinceName($address);
            $provinceLabel = ucfirst(strtolower($provinceName)).', '.$address->getCountryCode();
            $isNew = count(array_filter($addresses, function ($address) use ($provinceLabel) {
                return $address['province'] === $provinceLabel;
            })) === 0;

            if ($isNew) {
                $addresses[] = [
                    'province' => $provinceLabel,
                    'id' => $address->getId(),
                ];
            }
        }

        return $addresses;
    }

    private function getProvinceName(AddressInterface $address): string
    {
        $provinceName = $address->getProvinceName();

        if (!$provinceName) {
            /** @var ProvinceInterface $province */
            $province = $this->provinceRepository->findOneBy([
                'code' => $address->getProvinceCode(),
            ]);
            $provinceName = $province->getName();
        }

        return $provinceName;

The expression return $provinceName could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}