odiseoteam /
SyliusReportPlugin
| Conditions | 6 |
| Total Lines | 54 |
| Code Lines | 32 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | var reportChart = null; |
||
| 29 | function generateChart(ctx, type, labels, values, options) |
||
| 30 | { |
||
| 31 | var datasetOptions = $.extend({ |
||
| 32 | data: values |
||
| 33 | }, options.dataset); |
||
| 34 | |||
| 35 | var chartOptions = { |
||
| 36 | type: type, |
||
| 37 | data: { |
||
| 38 | labels: labels, |
||
| 39 | datasets: [datasetOptions] |
||
| 40 | }, |
||
| 41 | options: { |
||
| 42 | maintainAspectRatio: false, |
||
| 43 | legend: { |
||
| 44 | display: false |
||
| 45 | }, |
||
| 46 | tooltips: { |
||
| 47 | callbacks: { |
||
| 48 | label: function (tooltipItem, chart) { |
||
| 49 | var datasetLabel = chart.datasets[tooltipItem.datasetIndex].label || (chart.labels[tooltipItem.index] || ''); |
||
| 50 | var datasetValue = chart.datasets[tooltipItem.datasetIndex].data[tooltipItem.index]; |
||
| 51 | |||
| 52 | if (options.isMoneyValue !== undefined && options.isMoneyValue === true) { |
||
| 53 | return datasetLabel + ': ' + formatMoney(datasetValue, 2, '.', ',', '$'); |
||
| 54 | } |
||
| 55 | |||
| 56 | return datasetLabel + datasetValue; |
||
| 57 | } |
||
| 58 | } |
||
| 59 | } |
||
| 60 | } |
||
| 61 | }; |
||
| 62 | |||
| 63 | if (type !== 'pie' && type !== 'radar' && type !== 'polarArea' && type !== 'doughnut') { |
||
| 64 | chartOptions.options.scales = { |
||
| 65 | yAxes: [{ |
||
| 66 | ticks: { |
||
| 67 | beginAtZero: true, |
||
| 68 | userCallback: function (value, index, values) { |
||
| 69 | if (options.isMoneyValue !== undefined && options.isMoneyValue === true) { |
||
| 70 | return formatMoney(value, 2, '.', ',', '$'); |
||
| 71 | } |
||
| 72 | |||
| 73 | return value; |
||
| 74 | } |
||
| 75 | } |
||
| 76 | }] |
||
| 77 | }; |
||
| 78 | } |
||
| 79 | |||
| 80 | console.log(chartOptions); |
||
| 81 | reportChart = new Chart(ctx, chartOptions); |
||
| 82 | } |
||
| 83 | |||
| 200 |
Loading history...
This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function.