spec\Odiseo\SyliusReportPlugin\DependencyInjection\Compiler\RegisterDataFetchersPassSpec

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	it_throws_exception_if_any_data_fetcher_has_improper_attributes()	0	15	1
A	it_processes_with_given_container()	0	16	1
A	it_does_not_process_if_container_has_not_proper_definition()	0	6	1
A	it_should_implement_compiler_pass_interface()	0	3	1

<?php

namespace spec\Odiseo\SyliusReportPlugin\DependencyInjection\Compiler;

use PhpSpec\ObjectBehavior;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Reference;

/**
 * @author Mateusz Zalewski <mateusz.zalewski@lakion.com>
 * @author Diego D'amico <diego@odiseo.com.ar>
 */
final class RegisterDataFetchersPassSpec extends ObjectBehavior
{
    function it_should_implement_compiler_pass_interface()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->shouldImplement(CompilerPassInterface::class);
    }

    function it_processes_with_given_container(ContainerBuilder $container, Definition $dataFetcherDefinition)
    {
        $container->hasDefinition('odiseo_sylius_report.registry.data_fetcher')->willReturn(true);
        $container->getDefinition('odiseo_sylius_report.registry.data_fetcher')->willReturn($dataFetcherDefinition);

The method willReturn() does not exist on Symfony\Component\DependencyInjection\Definition.

        $dataFetcherServices = [
            'odiseo_sylius_report.form.type.data_fetcher.test' => [
                ['fetcher' => 'test', 'label' => 'Test data fetcher'],
            ],
        ];
        $container->findTaggedServiceIds('odiseo_sylius_report.data_fetcher')->willReturn($dataFetcherServices);

        $dataFetcherDefinition->addMethodCall('register', ['test', new Reference('odiseo_sylius_report.form.type.data_fetcher.test')])->shouldBeCalled();

The method shouldBeCalled() does not exist on Symfony\Component\DependencyInjection\Definition.

        $container->setParameter('odiseo_sylius_report.data_fetchers', ['test' => 'Test data fetcher'])->shouldBeCalled();

Are you sure the usage of $container->setParameter('odiseo_sylius_report.data_fetchers', array('test' => 'Test data fetcher')) targeting Symfony\Component\DependencyInjection\Container::setParameter() seems to always return null.

        $this->process($container);

The method process() does not exist on spec\Odiseo\SyliusReportPlugin\DependencyInjection\Compiler\RegisterDataFetchersPassSpec. Since you implemented __call, consider adding a @method annotation.

    }

    function it_does_not_process_if_container_has_not_proper_definition(ContainerBuilder $container)
    {
        $container->hasDefinition('odiseo_sylius_report.registry.data_fetcher')->willReturn(false);
        $container->getDefinition('odiseo_sylius_report.registry.data_fetcher')->shouldNotBeCalled();

The method shouldNotBeCalled() does not exist on Symfony\Component\DependencyInjection\Definition.

        $this->process($container);
    }

    function it_throws_exception_if_any_data_fetcher_has_improper_attributes(ContainerBuilder $container, Definition $dataFetcherDefinition)
    {
        $container->hasDefinition('odiseo_sylius_report.registry.data_fetcher')->willReturn(true);
        $container->getDefinition('odiseo_sylius_report.registry.data_fetcher')->willReturn($dataFetcherDefinition);

        $dataFetcherServices = [
            'odiseo_sylius_report.form.type.data_fetcher.test' => [
                ['data_fetcher' => 'test'],
            ],
        ];
        $container->findTaggedServiceIds('odiseo_sylius_report.data_fetcher')->willReturn($dataFetcherServices);
        $dataFetcherDefinition->addMethodCall('register', ['test', new Reference('odiseo_sylius_report.form.type.data_fetcher.test')])->shouldNotBeCalled();

        $this->shouldThrow(new \InvalidArgumentException('Tagged report data fetchers needs to have `fetcher` and `label` attributes.'))
            ->during('process', [$container]);
    }
}