Odiseo\SyliusReferralsPlugin\Repository\AffiliateReferralRepository

Complexity

Total Complexity

2

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	findOneByAffiliateAndProductNotExpired()	0	14	1
A	findOneByAffiliateNotExpired()	0	10	1

<?php

declare(strict_types=1);

namespace Odiseo\SyliusReferralsPlugin\Repository;

use Odiseo\SyliusReferralsPlugin\Entity\AffiliateInterface;
use Odiseo\SyliusReferralsPlugin\Entity\AffiliateReferralInterface;
use Sylius\Component\Core\Model\ProductInterface;
use Sylius\Bundle\ResourceBundle\Doctrine\ORM\EntityRepository;

class AffiliateReferralRepository extends EntityRepository implements AffiliateReferralRepositoryInterface
{
    public function findOneByAffiliateNotExpired(AffiliateInterface $affiliate): ?AffiliateReferralInterface
    {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->andWhere('o.affiliate = :affiliate')->andWhere('o.product IS NULL')->andWhere('o.expiresAt IS NULL')->setParameter('affiliate', $affiliate)->setMaxResults(1)->getQuery()->getOneOrNullResult() could return the type integer which is incompatible with the type-hinted return Odiseo\SyliusReferralsPlugin\Entity\AffiliateReferralInterface|null. Consider adding an additional type-check to rule them out.

            ->andWhere('o.affiliate = :affiliate')
            ->andWhere('o.product IS NULL')
            ->andWhere('o.expiresAt IS NULL')
            ->setParameter('affiliate', $affiliate)
            ->setMaxResults(1)
            ->getQuery()
            ->getOneOrNullResult()
        ;
    }

    public function findOneByAffiliateAndProductNotExpired(
        AffiliateInterface $affiliate,
        ProductInterface $product
    ): ?AffiliateReferralInterface {
        return $this->createQueryBuilder('o')

The expression return $this->createQueryBuilder('o')->andWhere('o.affiliate = :affiliate')->andWhere('o.product = :product')->andWhere('o.expiresAt > :now')->setParameter('product', $product)->setParameter('affiliate', $affiliate)->setParameter('now', new DateTime())->setMaxResults(1)->getQuery()->getOneOrNullResult() could return the type integer which is incompatible with the type-hinted return Odiseo\SyliusReferralsPlugin\Entity\AffiliateReferralInterface|null. Consider adding an additional type-check to rule them out.

            ->andWhere('o.affiliate = :affiliate')
            ->andWhere('o.product = :product')
            ->andWhere('o.expiresAt > :now')
            ->setParameter('product', $product)
            ->setParameter('affiliate', $affiliate)
            ->setParameter('now', new \DateTime())
            ->setMaxResults(1)
            ->getQuery()
            ->getOneOrNullResult()
        ;
    }
}