Odiseo\SyliusMailchimpPlugin\Handler\CartRegisterHandler::register()

Complexity

Conditions	15
Paths	10

Size

Total Lines	84
Code Lines	51

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function register(OrderInterface $order, bool $createOnly = false)
    {
        if (!$this->enabled) {
            return false;
        }

        /** @var CustomerInterface $customer */
        $customer = $order->getCustomer();
        $channel = $order->getChannel();

        if (
            null == $customer ||
            null == $channel ||
            count($order->getItems()) == 0
        ) {
            return false;
        }

        $storeId = $channel->getCode();
        $cartId = (string) $order->getId();

        $response = $this->ecommerceApi->getCart($storeId, $cartId);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::getCart() does only seem to accept string, maybe add an additional type check?

        $isNew = !isset($response['id']);

        // Do nothing if the cart exists
        if (false === $isNew && true === $createOnly) {
            return false;
        }

        // Registering the customer to ensure that exist on Mailchimp
        $response = $this->customerRegisterHandler->register($customer, $channel, false, $createOnly);

        if (!isset($response['id']) && $response !== false) {

The condition $response !== false is always false.

            return false;
        }
	
        // Assigning the token value to the order
        $this->orderTokenAssigner->assignTokenValueIfNotSet($order);
        $this->entityManager->flush();

        // Creating continue purchase url
        $context = $this->router->getContext();
        $context->setHost($channel->getHostname());
        $continuePurchaseUrl = $this->router->generate('odiseo_sylius_mailchimp_plugin_continue_cart_purchase', [
            '_locale' => $order->getLocaleCode() ?: 'en',
            'tokenValue' => $order->getTokenValue(),
        ], RouterInterface::ABSOLUTE_URL);
	
        $data = [
            'id' => $cartId,
            'customer' => [
                'id' => (string) $customer->getId(),
            ],
            'checkout_url' => $continuePurchaseUrl,
            'currency_code' => $order->getCurrencyCode() ?: 'USD',
            'order_total' => $order->getTotal() / 100,
            'tax_total' => $order->getTaxTotal() / 100,
            'lines' => [],
        ];

        foreach ($order->getItems() as $item) {
            $product = $item->getProduct();
            $variant = $item->getVariant();

            if (null == $product || null == $variant) {
                continue;
            }

            $data['lines'][] = [
                'id' => (string) $item->getId(),
                'product_id' => (string) $product->getId(),
                'product_variant_id' => (string) $variant->getId(),
                'quantity' => $item->getQuantity(),
                'price' => $item->getTotal() / 100,
            ];
        }

        if ($isNew) {
            $response = $this->ecommerceApi->addCart($storeId, $data);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::addCart() does only seem to accept string, maybe add an additional type check?

        } else {
            $response = $this->ecommerceApi->updateCart($storeId, $cartId, $data);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::updateCart() does only seem to accept string, maybe add an additional type check?

        }

        return $response;
    }