Odiseo\SyliusMailchimpPlugin\Handler\ProductRegisterHandler::register()

Complexity

Conditions	12
Paths	74

Size

Total Lines	70
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    public function register(ProductInterface $product, ChannelInterface $channel, bool $createOnly = false)
    {
        if (!$this->enabled) {
            return false;
        }

        $productId = (string) $product->getId();
        $storeId = $channel->getCode();

        $response = $this->ecommerceApi->getProduct($storeId, $productId);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::getProduct() does only seem to accept string, maybe add an additional type check?

        $isNew = !isset($response['id']);

        // Do nothing if the product exists
        if (false === $isNew && true === $createOnly) {
            return false;
        }

        $variants = [];
        /** @var ProductVariant $productVariant */
        foreach ($product->getVariants() as $productVariant) {
            $variant = [
                'id' => (string) $productVariant->getId(),
                'title' => $productVariant->getName() ? $productVariant->getName() : $product->getName(),
                'inventory_quantity' => $productVariant->isTracked() ? $productVariant->getOnHand() : 1,
            ];

            if ($variantPrice = $this->getVariantPrice($productVariant, $channel)) {
                $variant['price'] = $variantPrice / 100;
            }

            $variants[] = $variant;
        }

        $productImages = [];
        /** @var ProductImageInterface $image */
        foreach ($product->getImages() as $image) {
            $productImages[] = [
                'id' => (string) $image->getId(),
                'url' => $this->getImageUrl($image, $channel),
            ];
        }

        $data = [
            'id' => $productId,
            'title' => $product->getName(),
            'url' => $this->getProductUrl($product, $channel),
            'description' => $product->getDescription() ?: '',
            'images' => $productImages,
            'variants' => $variants,
        ];

        if (count($productImages) > 0) {
            $data['image_url'] = $productImages[0]['url'];
        }

        if ($isNew) {
            $event = new GenericEvent($product, ['data' => $data, 'channel' => $channel]);
            $this->eventDispatcher->dispatch($event, 'mailchimp.product.pre_add');

The call to Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() has too many arguments starting with 'mailchimp.product.pre_add'.

            $data = $event->getArgument('data');

            $response = $this->ecommerceApi->addProduct($storeId, $data);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::addProduct() does only seem to accept string, maybe add an additional type check?

        } else {
            $event = new GenericEvent($product, ['data' => $data, 'channel' => $channel]);
            $this->eventDispatcher->dispatch($event, 'mailchimp.product.pre_update');
            $data = $event->getArgument('data');

            $response = $this->ecommerceApi->updateProduct($storeId, $productId, $data);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::updateProduct() does only seem to accept string, maybe add an additional type check?

        }

        return $response;
    }