Odiseo\SyliusMailchimpPlugin\Handler\OrderRegisterHandler::register()

Complexity

Conditions	17
Paths	28

Size

Total Lines	105
Code Lines	66

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

<?php
    public function register(OrderInterface $order, bool $createOnly = false)
    {
        if (!$this->enabled) {
            return false;
        }

        /** @var CustomerInterface $customer */
        $customer = $order->getCustomer();
        $channel = $order->getChannel();

        if (
            null == $customer ||
            null == $channel ||
            count($order->getItems()) == 0
        ) {
            return false;
        }

        $storeId = $channel->getCode();
        $orderId = (string) $order->getId();

        $response = $this->ecommerceApi->getOrder($storeId, $orderId);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::getOrder() does only seem to accept string, maybe add an additional type check?

        $isNew = !isset($response['id']);

        // Do nothing if the order exists
        if (false === $isNew && true === $createOnly) {
            return false;
        }

        // Registering the customer to ensure that exist on Mailchimp
        $response = $this->customerRegisterHandler->register($customer, $channel, false, $createOnly);

        if (!isset($response['id']) && $response !== false) {
            return false;
        }

        // Creating order show url
        $context = $this->router->getContext();
        $context->setHost($channel->getHostname());
        $orderShowUrl = $this->router->generate('sylius_shop_order_show', [
            '_locale' => $order->getLocaleCode() ?: 'en',
            'tokenValue' => $order->getTokenValue(),
        ], RouterInterface::ABSOLUTE_URL);

        $lastCompletedPayment = $order->getLastPayment(PaymentInterface::STATE_COMPLETED);
        /** @var \DateTime $orderCompletedDate */
        $orderCompletedDate = $lastCompletedPayment?$lastCompletedPayment->getUpdatedAt():$order->getUpdatedAt();

        $data = [
            'id' => $orderId,
            'customer' => [
                'id' => (string) $customer->getId(),
            ],
            'financial_status' => 'paid',
            'currency_code' => $order->getCurrencyCode() ?: 'USD',
            'order_total' => $order->getTotal() / 100,
            'order_url' => $orderShowUrl,
            'discount_total' => $order->getOrderPromotionTotal() / 100,
            'tax_total' => $order->getTaxTotal() / 100,
            'shipping_total' => $order->getShippingTotal() / 100,
            'processed_at_foreign' => $orderCompletedDate->format('c'),
            'shipping_address' => $this->getAddressData($order->getShippingAddress()),

It seems like $order->getShippingAddress() can also be of type null; however, parameter $address of Odiseo\SyliusMailchimpPlugin\Handler\OrderRegisterHandler::getAddressData() does only seem to accept Sylius\Component\Core\Model\AddressInterface, maybe add an additional type check?

            'billing_address' => $this->getAddressData($order->getBillingAddress()),
            'lines' => [],
        ];

        if ($this->session->has('campaingId')) {
            $data['campaign_id'] = $this->session->get('campaingId');
        }

        foreach ($order->getItems() as $item) {
            $product = $item->getProduct();
            $variant = $item->getVariant();

            if (null == $product || null == $variant) {
                continue;
            }

            $data['lines'][] = [
                'id' => (string) $item->getId(),
                'product_id' => (string) $product->getId(),
                'product_variant_id' => (string) $variant->getId(),
                'quantity' => $item->getQuantity(),
                'price' => $item->getTotal() / 100,
            ];
        }

        if ($isNew) {
            $event = new GenericEvent($order, ['data' => $data]);
            $this->eventDispatcher->dispatch($event, 'mailchimp.order.pre_add');

The call to Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() has too many arguments starting with 'mailchimp.order.pre_add'.

            $data = $event->getArgument('data');

            $response = $this->ecommerceApi->addOrder($storeId, $data);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::addOrder() does only seem to accept string, maybe add an additional type check?

            // Unregister abandoned cart after order create
            $this->removeCart($order);
        } else {
            $event = new GenericEvent($order, ['data' => $data]);
            $this->eventDispatcher->dispatch($event, 'mailchimp.order.pre_update');
            $data = $event->getArgument('data');

            $response = $this->ecommerceApi->updateOrder($storeId, $orderId, $data);

It seems like $storeId can also be of type null; however, parameter $storeId of Odiseo\SyliusMailchimpPlugin\Api\EcommerceInterface::updateOrder() does only seem to accept string, maybe add an additional type check?

        }

        return $response;
    }