BlogFixture::__construct() - Code Metrics - Inspection of "Comments added" - odiseoteam/SyliusBlogPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 1e6437...ac5983 )

by Odiseo
created 2019-07-22 23:18 UTC
BlogFixture::__construct() A

↳ Parent: BlogFixture
Complexity

Conditions	1
Paths	1
Size

Total Lines	24
Code Lines	13
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	1
Metric	Value
eloc	13
c	1
b	0
f	1
dl	0
loc	24
rs	9.8333
cc	1
nc	1
nop	8
How to fix Many Parameters

<?php

namespace Odiseo\SyliusBlogPlugin\Fixture;

use Doctrine\Common\Persistence\ObjectManager;
use Faker\Factory;
use Odiseo\BlogBundle\EventListener\ArticleImageUploadListener;
use Odiseo\BlogBundle\Model\ArticleCategoryInterface;
use Odiseo\BlogBundle\Model\ArticleImage;
use Odiseo\BlogBundle\Model\ArticleImageInterface;
use Odiseo\SyliusBlogPlugin\Model\ArticleCommentInterface;
use Odiseo\SyliusBlogPlugin\Model\ArticleInterface;
use Sylius\Bundle\FixturesBundle\Fixture\AbstractFixture;
use Sylius\Bundle\ResourceBundle\Event\ResourceControllerEvent;
use Sylius\Component\Channel\Repository\ChannelRepositoryInterface;
use Sylius\Component\Core\Model\ChannelInterface;
use Sylius\Component\Locale\Model\LocaleInterface;
use Sylius\Component\Resource\Factory\FactoryInterface;
use Sylius\Component\Resource\Repository\RepositoryInterface;
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\OptionsResolver\OptionsResolver;

class BlogFixture extends AbstractFixture
{
    /** @var ObjectManager */
    protected $objectManager;

    /** @var FactoryInterface */
    protected $articleFactory;

    /** @var FactoryInterface */
    protected $articleCategoryFactory;

    /** @var FactoryInterface */
    protected $articleImageFactory;

    /** @var FactoryInterface */
    protected $articleCommentFactory;

    /** @var ChannelRepositoryInterface */
    protected $channelRepository;

    /** @var RepositoryInterface */
    protected $localeRepository;

    /** @var \Faker\Generator */
    protected $faker;

    /** @var OptionsResolver */
    protected $optionsResolver;

    /** @var ArticleImageUploadListener */
    protected $imageUploader;

    /** @var array */
    protected $categories;

    public function __construct(
        ObjectManager $objectManager,
        FactoryInterface $articleFactory,
        FactoryInterface $articleCategoryFactory,
        FactoryInterface $articleImageFactory,
        FactoryInterface $articleCommentFactory,
        ChannelRepositoryInterface $channelRepository,
        RepositoryInterface $localeRepository,
        ArticleImageUploadListener $imageUploader
    ) {
        $this->objectManager = $objectManager;
        $this->articleFactory = $articleFactory;
        $this->articleCategoryFactory = $articleCategoryFactory;
        $this->articleImageFactory = $articleImageFactory;
        $this->articleCommentFactory = $articleCommentFactory;
        $this->channelRepository = $channelRepository;
        $this->localeRepository = $localeRepository;
        $this->imageUploader = $imageUploader;

        $this->faker = Factory::create();
        $this->optionsResolver =
            (new OptionsResolver())
                ->setRequired('articles_per_channel')
                ->setAllowedTypes('articles_per_channel', 'int')
        ;
    }

    /**
     * @inheritDoc
     */
    public function load(array $options): void
    {
        $options = $this->optionsResolver->resolve($options);

        $channels = $this->channelRepository->findAll();

        $this->createArticleCategories();

        /** @var ChannelInterface $channel */
        foreach ($channels as $channel) {
            $imageIndex = 1;

            for ($i=1; $i <= $options['articles_per_channel']; $i++) {
                /** @var ArticleInterface $article */
                $article = $this->articleFactory->createNew();

                $article->addChannel($channel);
                $article->setCode($this->faker->md5);
                $article->setEnabled(rand(1, 100) > 30);

                // Add categories
                $categories = $this->faker->randomElements($this->categories, rand(1, count($this->categories)));

                /** @var ArticleCategoryInterface $category */
                foreach ($categories as $category) {
                    $article->addCategory($category);
                }

                // Set translatable fields
                foreach ($this->getLocales() as $localeCode) {
                    $article->setCurrentLocale($localeCode);
                    $article->setFallbackLocale($localeCode);

                    $article->getTranslation()->setTitle($this->faker->text(20));
                    $article->getTranslation()->/** @scrutinizer ignore-call */ setTitle($this->faker->text(20));
                    $article->getTranslation()->setContent($this->faker->text);
                    $article->getTranslation()->/** @scrutinizer ignore-call */ setContent($this->faker->text);
                    $article->getTranslation()->setSlug($this->faker->slug);
                    $article->getTranslation()->/** @scrutinizer ignore-call */ setSlug($this->faker->slug);
                }

                // Add images
                $srcImage = new UploadedFile($this->faker->image(null, 1200, 350), $article->getTitle());
                /** @var ArticleImageInterface $image */
                $image = $this->articleImageFactory->createNew();
                $image->setFile($srcImage);
                $article->addImage($image);

                $this->imageUploader->uploadImages(new ResourceControllerEvent($article));

                // Add comments
                if (rand(0, 100) > 50) {
                    $this->addArticleComments($article);
                }

                $this->objectManager->persist($article);
            }
        }

        $this->objectManager->flush();
    }

    private function createArticleCategories()
    {
        for ($i = 0; $i < 5; $i++) {
            /** @var ArticleCategoryInterface $articleCategory */
            $articleCategory = $this->articleCategoryFactory->createNew();
            $articleCategory->setCode($this->faker->md5);
            $articleCategory->setEnabled(true);

            foreach ($this->getLocales() as $localeCode) {
                $articleCategory->setCurrentLocale($localeCode);
                $articleCategory->setFallbackLocale($localeCode);

                $articleCategory->getTranslation()->setTitle($this->faker->text(20));
                $articleCategory->getTranslation()->setSlug($this->faker->slug);
            }

            $this->objectManager->persist($articleCategory);
            $this->categories[] = $articleCategory;
        }
    }

    private function addArticleComments(ArticleInterface $article)
    {
        for ($i = 0; $i < 8; $i++) {
            /** @var ArticleCommentInterface $comment */
            $comment = $this->articleCommentFactory->createNew();
            $comment->setName($this->faker->name);
            $comment->setEmail($this->faker->email);
            $comment->setComment($this->faker->text);
            $comment->setEnabled(rand(1, 100) > 30);

            $article->addComment($comment);
            $this->objectManager->persist($comment);
        }
    }

    /**
     * @return array
     */
    private function getLocales()
    {
        /** @var LocaleInterface[] $locales */
        $locales = $this->localeRepository->findAll();
        foreach ($locales as $locale) {
            yield $locale->getCode();

        }
    }

    /**
     * {@inheritdoc}
     */
    protected function configureOptionsNode(ArrayNodeDefinition $optionsNode): void
    {
        $optionsNode
            ->children()
                ->integerNode('articles_per_channel')->isRequired()->min(1)->end()
        ;
    }

    /**
     * {@inheritdoc}
     */
    public function getName(): string
    {
        return 'blog';
    }
}

odiseoteam / SyliusBlogPlugin

GitHub Access Token became invalid

Push — master ( 1e6437...ac5983 )

BlogFixture::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
