ArticleCommentFactory::createNewWithArticle() - Code Metrics - Inspection of "Comments creation route, form and improvements" - odiseoteam/OdiseoBlogBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( faf574...d9550b )

by Odiseo

created 2019-07-20 20:04 UTC

ArticleCommentFactory::createNewWithArticle() A

↳ Parent: ArticleCommentFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	6
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	14
rs	10

<?php

namespace Odiseo\BlogBundle\Factory;

use Exception;
use Odiseo\BlogBundle\Doctrine\ORM\ArticleRepositoryInterface;
use Odiseo\BlogBundle\Model\ArticleCommentInterface;
use Odiseo\BlogBundle\Model\ArticleInterface;

final class ArticleCommentFactory implements ArticleCommentFactoryInterface
{
    /** @var string */
    private $className;

    /** @var ArticleRepositoryInterface */
    private $articleRepository;

    public function __construct(string $className, ArticleRepositoryInterface $articleRepository)
    {
        $this->className = $className;
        $this->articleRepository = $articleRepository;
    }

    /**
     * {@inheritdoc}
     */
    public function createNew()
    {
        return new $this->className();
    }

    /**
     * {@inheritdoc}
     */
    public function createNewWithArticle(string $id): ArticleCommentInterface
    {
        /** @var ArticleInterface $article */
        $article = $this->articleRepository->find($id);

        if (!$article instanceof ArticleInterface) {

            throw new Exception();
        }

        /** @var ArticleCommentInterface $articleComment */
        $articleComment = $this->createNew();
        $articleComment->setArticle($article);

        return $articleComment;
    }
}


1			<?php
2
3			namespace Odiseo\BlogBundle\Factory;
4
5			use Exception;
6			use Odiseo\BlogBundle\Doctrine\ORM\ArticleRepositoryInterface;
7			use Odiseo\BlogBundle\Model\ArticleCommentInterface;
8			use Odiseo\BlogBundle\Model\ArticleInterface;
9
10			final class ArticleCommentFactory implements ArticleCommentFactoryInterface
11			{
12			/** @var string */
13			private $className;
14
15			/** @var ArticleRepositoryInterface */
16			private $articleRepository;
17
18			public function __construct(string $className, ArticleRepositoryInterface $articleRepository)
19			{
20			$this->className = $className;
21			$this->articleRepository = $articleRepository;
22			}
23
24			/**
25			* {@inheritdoc}
26			*/
27			public function createNew()
28			{
29			return new $this->className();
30			}
31
32			/**
33			* {@inheritdoc}
34			*/
35			public function createNewWithArticle(string $id): ArticleCommentInterface
36			{
37			/** @var ArticleInterface $article */
38			$article = $this->articleRepository->find($id);
39
40			if (!$article instanceof ArticleInterface) {
			0 ignored issues – show introduced 2019-07-20 20:07 UTC by Report Bug Copy Issue Report `$article` is always a sub-type of `Odiseo\BlogBundle\Model\ArticleInterface`. Loading history...
41			throw new Exception();
42			}
43
44			/** @var ArticleCommentInterface $articleComment */
45			$articleComment = $this->createNew();
46			$articleComment->setArticle($article);
47
48			return $articleComment;
49			}
50			}
51

odiseoteam / OdiseoBlogBundle

GitHub Access Token became invalid

Push — master ( faf574...d9550b )

ArticleCommentFactory::createNewWithArticle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like