Oddvalue\DbRouter\RouteManager

Complexity

Total Complexity

9

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createRedirect()	0	6	1
A	addRoutes()	0	13	2
A	updateRoutes()	0	15	3
A	deleteRoutes()	0	8	2
A	createOrRestoreRoute()	0	16	1

<?php

namespace Oddvalue\DbRouter;

use Oddvalue\DbRouter\Route;
use Illuminate\Database\QueryException;
use Oddvalue\DbRouter\Contracts\Routable;
use Oddvalue\DbRouter\Contracts\RouteGenerator;

This use statement conflicts with another class in this namespace, Oddvalue\DbRouter\RouteGenerator. Consider defining an alias.

use Illuminate\Database\Eloquent\Relations\Relation;
use Oddvalue\DbRouter\Contracts\ChildRouteGenerator;
use Oddvalue\DbRouter\Exceptions\RouteCollisionException;

class RouteManager
{
    /**
     * If the slug has changed then softdelete current path for self and all
     * descendants and insert new path for self and all descendants
     * By default only the primary entity types have Routes
     *
     * @param Oddvalue\DbRouter\Contracts\Routable $instance

The type Oddvalue\DbRouter\Oddvalue\DbRouter\Contracts\Routable was not found. Did you mean Oddvalue\DbRouter\Contracts\Routable? If so, make sure to prefix the type with \.

     */
    public function updateRoutes(Routable $instance)
    {
        $this->deleteRoutes($instance);

        $generator = $instance->getRouteGenerator();

        if (! $generator->isRoutable($instance)) {
            return;
        }

        $this->addRoutes($instance);

        if ($generator instanceof ChildRouteGenerator) {
            $generator->getRouteChildren($instance)->map(function ($childInstance) {
                $this->updateRoutes($childInstance);
            });
        }
    }

    /**
     * Create new Route OR restore old path if already exists
     */
    public function addRoutes(Routable $instance)
    {
        try {
            $routes = collect($instance->getRouteGenerator()->getRoutes($instance));

            $canonicalRouteString = $routes->shift();
            $canonicalId = $this->createOrRestoreRoute($canonicalRouteString, $instance)->id;

            $routes->each(function ($route) use ($instance, $canonicalId) {
                $this->createOrRestoreRoute($route, $instance, $canonicalId);
            });
        } catch (QueryException $e) {
            throw RouteCollisionException::fromQueryException($e);
        }
    }

    public function createOrRestoreRoute(string $routeString, Routable $instance, int $canonicalId = null)
    {
        $type = get_class($instance);
        $type = Relation::getMorphedModel($type) ?? $type;
        Route::onlyTrashed()->whereHasMorph('routable', $type, function ($query) use ($instance) {
            $query->where($instance->getKeyName(), $instance->id);

The method getKeyName() does not exist on Oddvalue\DbRouter\Contracts\Routable. Since it exists in all sub-types, consider adding an abstract or default implementation to Oddvalue\DbRouter\Contracts\Routable.

Accessing id on the interface Oddvalue\DbRouter\Contracts\Routable suggest that you code against a concrete implementation. How about adding an instanceof check?

        })->whereUrl($routeString)->forceDelete();

        $generator = $instance->getRouteGenerator();

The assignment to $generator is dead and can be removed.

        $path = $instance->routes()->withTrashed()->firstOrCreate([
            'url' => $routeString,
            'canonical_id' => $canonicalId,
        ]);
        $path->restore();

        return $path;
    }

    /**
     * Delete existing Route instances for an entity
     */
    public function deleteRoutes(Routable $instance)
    {
        $instance->routes()->delete();

        $generator = $instance->getRouteGenerator();
        if ($generator instanceof ChildRouteGenerator) {
            $generator->getRouteChildren($instance)->map(function ($childInstance) {
                $this->deleteRoutes($childInstance);
            });
        }
    }

    /**
     * Create a redirect route
     *
     * @param string $url
     * @param self $route
     * @return Route
     */
    public static function createRedirect(string $url, Route $route) : Route
    {
        $redirect = new Route(['url' => $url]);
        $redirect->redirect()->associate($route);
        $redirect->save();
        return $redirect;
    }
}