Comments::get() - Code Metrics - Inspection of "Multiple files get and post" - ochi51/cybozu-http - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by Yuichi

created 2017-12-05 14:04 UTC

Comments::get() A

↳ Parent: Comments

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	17
ccs	0
cts	10
cp	0
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	11
nc	1
nop	6
crap	2

<?php

namespace CybozuHttp\Api\Kintone;

use CybozuHttp\Client;
use CybozuHttp\Api\KintoneApi;
use CybozuHttp\Middleware\JsonStream;

/**
 * @author ochi51 <[email protected]>
 */
class Comments
{
    /**
     * @var Client
     */
    private $client;

    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Get record comments
     * https://cybozudev.zendesk.com/hc/ja/articles/208242326
     *
     * @param int $appId
     * @param int $recordId
     * @param string $order "asc" or "desc"
     * @param int $offset
     * @param int $limit Max = 10
     * @param int $guestSpaceId
     * @return array
     */
    public function get($appId, $recordId, $order = 'desc', $offset = 0, $limit = 10, $guestSpaceId = null)
    {
        $options = ['json' => [
            'app' => $appId,
            'record' => $recordId,
            'order' => $order,
            'offset' => $offset,
            'limit' => $limit
        ]];

        /** @var JsonStream $stream */
        $stream = $this->client
            ->get(KintoneApi::generateUrl('record/comments.json', $guestSpaceId), $options)
            ->getBody();

        return $stream->jsonSerialize()['comments'];
    }
}

1		<?php
2
3		namespace CybozuHttp\Api\Kintone;
4
5		use CybozuHttp\Client;
6		use CybozuHttp\Api\KintoneApi;
7		use CybozuHttp\Middleware\JsonStream;
8
9		/**
10		* @author ochi51 <[email protected]>
11		*/
12		class Comments
13		{
14		/**
15		* @var Client
16		*/
17		private $client;
18
19	1	public function __construct(Client $client)
20		{
21	1	$this->client = $client;
22	1	}
23
24		/**
25		* Get record comments
26		* https://cybozudev.zendesk.com/hc/ja/articles/208242326
27		*
28		* @param int $appId
29		* @param int $recordId
30		* @param string $order "asc" or "desc"
31		* @param int $offset
32		* @param int $limit Max = 10
33		* @param int $guestSpaceId
34		* @return array
35		*/
36		public function get($appId, $recordId, $order = 'desc', $offset = 0, $limit = 10, $guestSpaceId = null)
37		{
38		$options = ['json' => [
39		'app' => $appId,
40		'record' => $recordId,
41		'order' => $order,
42		'offset' => $offset,
43		'limit' => $limit
44		]];
45
46		/** @var JsonStream $stream */
47		$stream = $this->client
48		->get(KintoneApi::generateUrl('record/comments.json', $guestSpaceId), $options)
49		->getBody();
50
51		return $stream->jsonSerialize()['comments'];
52		}
53		}

ochi51 / cybozu-http

Pull Request — master (#27)

Comments::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like