AbstractInducement::configureOptions() - Code Metrics - Inspection of "Fix Scrutinizer issues" - obblm/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (69883f)

by Benjamin

created 2020-09-29 11:43 UTC

AbstractInducement::configureOptions() A

↳ Parent: AbstractInducement

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	18
nc	1
nop	1
dl	0
loc	21
rs	9.6666
c	0
b	0
f	0

<?php

namespace Obblm\Core\Helper\Rule\Inducement;

use Obblm\Core\Contracts\InducementInterface;
use Obblm\Core\Helper\Optionable;
use Symfony\Component\OptionsResolver\OptionsResolver;

abstract class AbstractInducement extends Optionable implements InducementInterface
{
    /** @var string */
    protected $key;
    /** @var int */
    protected $value;
    /** @var int */
    protected $discountValue;
    /** @var string */
    protected $name;
    /** @var string */
    protected $translationDomain;
    /** @var string */
    protected $typeName;
    /** @var InducementType */
    protected $type;
    /** @var int */
    protected $max;
    /** @var array */
    protected $rosters = null;

    protected function hydrateWithOptions()
    {
        $this->key = $this->options['key'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->type = $this->options['type'] ?? null;
        $this->name = $this->options['name'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->translationDomain = $this->options['translation_domain'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->typeName = $this->options['type_name'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->value = $this->options['value'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->discountValue = $this->options['discount_value'] ?? $this->value;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->max = $this->options['max'] ?? false;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->rosters = $this->options['rosters'] ?? [];
    }

    /**
     * @return InducementType
     */
    public function getType(): ?InducementType
    {
        return $this->type;
    }

    public function isMultiple(): bool
    {
        return false;
    }

    /**
     * @return string
     */
    public function getKey(): string
    {
        return $this->key;
    }

    /**
     * @return string
     */
    public function getTypeKey(): string
    {
        return $this->getType()->getKey();
    }

    /**
     * @return int
     */
    public function getDiscountValue(): int
    {
        return $this->discountValue;
    }

    /**
     * @return int
     */
    public function getValue(): int
    {
        return $this->value;
    }

    /**
     * @return string
     */
    public function getTypeName(): string
    {
        return $this->getType()->getName();
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @return string
     */
    public function getTranslationDomain(): string
    {
        return $this->translationDomain;
    }

    /**
     * @return int
     */
    public function getMax(): int
    {
        return $this->max;
    }

    /**
     * @return array
     */
    public function getRosters(): ?array
    {
        return $this->rosters;
    }

    /**
     * @param string $key
     */
    public function setKey(string $key): void
    {
        $this->key = $key;
    }

    /**
     * @param int $value
     */
    public function setValue(int $value): void
    {
        $this->value = $value;
    }

    /**
     * @param string $name
     */
    public function setName(string $name): void
    {
        $this->name = $name;
    }

    /**
     * @param string $translationDomain
     */
    public function setTranslationDomain(string $translationDomain): void
    {
        $this->translationDomain = $translationDomain;
    }

    /**
     * @param InducementType|array $type
     */
    public function setType($type): void
    {
        $this->type = $type;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @param int $max
     */
    public function setMax(int $max): void
    {
        $this->max = $max;
    }

    /**
     * @param array $rosters
     */
    public function setRosters(array $rosters): void
    {
        $this->rosters = $rosters;
    }

    public function __toString(): string
    {
        return $this->name;
    }

    public function configureOptions(OptionsResolver $resolver):void
    {
        $resolver->setDefaults([
            'key'                => null,
            'type'               => null,
            'name'               => null,
            'translation_domain' => null,
            'value'              => null,
            'discount_value'     => null,
            'max'                => null,
            'rosters'            => null,
        ])
            ->setRequired(['key', 'type', 'name', 'translation_domain', 'value', 'max'])
            ->setAllowedTypes('key', ['string'])
            ->setAllowedTypes('type', [InducementType::class])
            ->setAllowedTypes('name', ['string'])
            ->setAllowedTypes('translation_domain', ['string'])
            ->setAllowedTypes('value', ['int'])
            ->setAllowedTypes('discount_value', ['int', 'null'])
            ->setAllowedTypes('max', ['int'])
            ->setAllowedTypes('rosters', ['array', 'null'])
        ;
    }
}


1			<?php
2
3			namespace Obblm\Core\Helper\Rule\Inducement;
4
5			use Obblm\Core\Contracts\InducementInterface;
6			use Obblm\Core\Helper\Optionable;
7			use Symfony\Component\OptionsResolver\OptionsResolver;
8
9			abstract class AbstractInducement extends Optionable implements InducementInterface
10			{
11			/** @var string */
12			protected $key;
13			/** @var int */
14			protected $value;
15			/** @var int */
16			protected $discountValue;
17			/** @var string */
18			protected $name;
19			/** @var string */
20			protected $translationDomain;
21			/** @var string */
22			protected $typeName;
23			/** @var InducementType */
24			protected $type;
25			/** @var int */
26			protected $max;
27			/** @var array */
28			protected $rosters = null;
29
30			protected function hydrateWithOptions()
31			{
32			$this->key = $this->options['key'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['key'] ?? false` can also be of type `false`. However, the property `$key` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
33			$this->type = $this->options['type'] ?? null;
34			$this->name = $this->options['name'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['name'] ?? false` can also be of type `false`. However, the property `$name` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
35			$this->translationDomain = $this->options['translation_domain'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['translation_domain'] ?? false` can also be of type `false`. However, the property `$translationDomain` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
36			$this->typeName = $this->options['type_name'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['type_name'] ?? false` can also be of type `false`. However, the property `$typeName` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
37			$this->value = $this->options['value'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['value'] ?? false` can also be of type `false`. However, the property `$value` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
38			$this->discountValue = $this->options['discount_value'] ?? $this->value;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['discount_value'] ?? $this->value` can also be of type `false`. However, the property `$discountValue` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
39			$this->max = $this->options['max'] ?? false;
			0 ignored issues – show Documentation Bug introduced 2020-09-29 11:47 UTC by Report Bug Copy Issue Report It seems like `$this->options['max'] ?? false` can also be of type `false`. However, the property `$max` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
40			$this->rosters = $this->options['rosters'] ?? [];
41			}
42
43			/**
44			* @return InducementType
45			*/
46			public function getType(): ?InducementType
47			{
48			return $this->type;
49			}
50
51			public function isMultiple(): bool
52			{
53			return false;
54			}
55
56			/**
57			* @return string
58			*/
59			public function getKey(): string
60			{
61			return $this->key;
62			}
63
64			/**
65			* @return string
66			*/
67			public function getTypeKey(): string
68			{
69			return $this->getType()->getKey();
70			}
71
72			/**
73			* @return int
74			*/
75			public function getDiscountValue(): int
76			{
77			return $this->discountValue;
78			}
79
80			/**
81			* @return int
82			*/
83			public function getValue(): int
84			{
85			return $this->value;
86			}
87
88			/**
89			* @return string
90			*/
91			public function getTypeName(): string
92			{
93			return $this->getType()->getName();
94			}
95
96			/**
97			* @return string
98			*/
99			public function getName(): string
100			{
101			return $this->name;
102			}
103
104			/**
105			* @return string
106			*/
107			public function getTranslationDomain(): string
108			{
109			return $this->translationDomain;
110			}
111
112			/**
113			* @return int
114			*/
115			public function getMax(): int
116			{
117			return $this->max;
118			}
119
120			/**
121			* @return array
122			*/
123			public function getRosters(): ?array
124			{
125			return $this->rosters;
126			}
127
128			/**
129			* @param string $key
130			*/
131			public function setKey(string $key): void
132			{
133			$this->key = $key;
134			}
135
136			/**
137			* @param int $value
138			*/
139			public function setValue(int $value): void
140			{
141			$this->value = $value;
142			}
143
144			/**
145			* @param string $name
146			*/
147			public function setName(string $name): void
148			{
149			$this->name = $name;
150			}
151
152			/**
153			* @param string $translationDomain
154			*/
155			public function setTranslationDomain(string $translationDomain): void
156			{
157			$this->translationDomain = $translationDomain;
158			}
159
160			/**
161			* @param InducementType\|array $type
162			*/
163			public function setType($type): void
164			{
165			$this->type = $type;
			0 ignored issues – show Documentation Bug introduced 2020-09-24 12:31 UTC by Report Bug Copy Issue Report It seems like `$type` can also be of type `array`. However, the property `$type` is declared as type `Obblm\Core\Helper\Rule\Inducement\InducementType`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
166			}
167
168			/**
169			* @param int $max
170			*/
171			public function setMax(int $max): void
172			{
173			$this->max = $max;
174			}
175
176			/**
177			* @param array $rosters
178			*/
179			public function setRosters(array $rosters): void
180			{
181			$this->rosters = $rosters;
182			}
183
184			public function __toString(): string
185			{
186			return $this->name;
187			}
188
189			public function configureOptions(OptionsResolver $resolver):void
190			{
191			$resolver->setDefaults([
192			'key' => null,
193			'type' => null,
194			'name' => null,
195			'translation_domain' => null,
196			'value' => null,
197			'discount_value' => null,
198			'max' => null,
199			'rosters' => null,
200			])
201			->setRequired(['key', 'type', 'name', 'translation_domain', 'value', 'max'])
202			->setAllowedTypes('key', ['string'])
203			->setAllowedTypes('type', [InducementType::class])
204			->setAllowedTypes('name', ['string'])
205			->setAllowedTypes('translation_domain', ['string'])
206			->setAllowedTypes('value', ['int'])
207			->setAllowedTypes('discount_value', ['int', 'null'])
208			->setAllowedTypes('max', ['int'])
209			->setAllowedTypes('rosters', ['array', 'null'])
210			;
211			}
212			}
213

obblm / core

Branch — develop (69883f)

AbstractInducement::configureOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like