Obblm\Core\Helper\ImageHelper

Complexity

Total Complexity

19

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getRosterImage()	0	22	5
A	returnCachedAsset()	0	19	4
A	__construct()	0	10	1
A	getTeamCover()	0	14	4
A	sanitizeFilePath()	0	3	1
A	getTeamLogo()	0	14	4

<?php

namespace Obblm\Core\Helper;

use Doctrine\Common\Collections\ArrayCollection;
use Intervention\Image\ImageManager;

The type Intervention\Image\ImageManager was not found. Maybe you did not declare it correctly or list all dependencies?

use Obblm\Core\Entity\Rule;
use Obblm\Core\Entity\Team;
use Obblm\Core\Service\FileTeamUploader;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;
use \SplFileInfo;
use Symfony\Component\HttpFoundation\File\File;

class ImageHelper
{
    const RULE_PATH = '/rule';
    const TEAM_PATH = '/team';

    private $imageManager;
    private $ruleHelper;
    private $publicDirectory;
    private $cacheDirectory;
    private $ruleCacheDirectory;
    private $teamCacheDirectory;
    private $filesystem;
    private $fileTeamUploader;

    public function __construct(RuleHelper $ruleHelper, FileTeamUploader $fileTeamUploader, string $kernetProjectDir, string $cacheDirectory)
    {
        $this->imageManager = new ImageManager(['driver' => 'gd']);
        $this->ruleHelper = $ruleHelper;
        $this->publicDirectory = $kernetProjectDir;
        $this->cacheDirectory = $cacheDirectory;
        $this->ruleCacheDirectory = $this->cacheDirectory . self::RULE_PATH ;
        $this->teamCacheDirectory = $this->cacheDirectory . self::TEAM_PATH ;
        $this->filesystem = new Filesystem();
        $this->fileTeamUploader = $fileTeamUploader;
    }

    public function getTeamLogo(Team $team, int $width = null, int $height = null): ?string
    {
        if ($team->getLogoFilename()) {
            $this->fileTeamUploader->setObjectSubDirectory($team->getId());
            $filePath = $this->fileTeamUploader->getObjectDirectory() . '/' . $team->getLogoFilename();
            if ($width || $height) {

The expression $height of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

The expression $width of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

                $newFilePath = $this->teamCacheDirectory . '/' . $team->getId();
                $file = new File($filePath);
                return $this->returnCachedAsset($file, $newFilePath, $width, $height);
            }
            // full sized
            return $this->sanitizeFilePath($filePath);
        }
        return $this->getRosterImage($team->getRule(), $team->getRoster(), $width, $height);

It seems like $team->getRule() can also be of type null; however, parameter $rule of Obblm\Core\Helper\ImageHelper::getRosterImage() does only seem to accept Obblm\Core\Entity\Rule, maybe add an additional type check?

    }

    public function getTeamCover(Team $team, int $width = null, int $height = null): ?string
    {
        if ($team->getCoverFilename()) {
            $this->fileTeamUploader->setObjectSubDirectory($team->getId());
            $filePath = $this->fileTeamUploader->getObjectDirectory() . '/' . $team->getCoverFilename();
            if ($width || $height) {

The expression $height of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

The expression $width of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

                $newFilePath = $this->teamCacheDirectory . '/' . $team->getId();
                $file = new File($filePath);
                return $this->returnCachedAsset($file, $newFilePath, $width, $height);
            }
            // full sized
            return $this->sanitizeFilePath($filePath);
        }
        return null;
    }

    public function getRosterImage(Rule $rule, string $roster, int $width = null, int $height = null): ?string
    {
        $helper = $this->ruleHelper->getHelper($rule);
        if ($helper->getRosters()->get($roster) && $rule->getRuleDirectory()) {
            $finder = new Finder();
            $directory = dirname(__DIR__) . $rule->getRuleDirectory() . '/assets/';
            $finder->files()
                ->name($roster . '.*')
                ->in($directory);
            if ($finder->hasResults()) {
                /** @var SplFileInfo[]|ArrayCollection $results */
                $results = new ArrayCollection();
                foreach ($finder as $file) {
                    $results->add($file);
                }
                // We have to resize
                $newFilePath = $this->ruleCacheDirectory . '/' . $rule->getId();
                $file = $results->first();
                return $this->returnCachedAsset($file, $newFilePath, $width, $height);
            }
        }
        return null;
    }

    private function returnCachedAsset(SplFileInfo $file, $path = '', $width = null, $height = null)
    {
        if ($width) {
            $path .= '/w' . $width;
        }
        if ($height) {
            $path .= '/h' . $height;
        }
        $newCacheDirectory = $path;
        $path .= '/' . $file->getFilename();
        if (!$this->filesystem->exists($path)) {
            $img = $this->imageManager->make($file);
            $this->filesystem->mkdir($newCacheDirectory);
            $img->resize($width, $height, function ($constraint) {
                $constraint->aspectRatio();
            });
            $img->save($path);
        }
        return $this->sanitizeFilePath($path);
    }

    private function sanitizeFilePath($filePath)
    {
        return str_replace($this->publicDirectory, '', $filePath);
    }
}