Obblm\Core\Service\Rule\Bb2020Rule::setPlayerDefaultValues()

Complexity

Conditions	1
Paths	1

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function setPlayerDefaultValues(PlayerVersion $version): ?PlayerVersion
    {
        /**
         * -characteristics: []
         * -skills: []
         * -spp_level: null
         * -value: null
         */
        list($ruleKey, $roster, $type) = explode(CoreTranslation::TRANSLATION_GLUE, $version->getPlayer()->getType());
        $types = $this->getAvailablePlayerTypes($roster);
        $base = $types[$type];
        $characteristics = $base['characteristics'];
        $version->setCharacteristics([
            'ma' => $characteristics['ma'],
            'st' => $characteristics['st'],
            'pa' => $characteristics['pa'],
            'ag' => $characteristics['ag'],
            'av' => $characteristics['av']
        ])
            ->setActions([
                'td' => 0,
                'cas' => 0,
                'pas' => 0,
                'int' => 0,
                'mvp' => 0,
            ])
            ->setSkills(($base['skills'] ?? []))
            ->setValue($base['cost'])
            ->setSppLevel($this->getSppLevel($version));

It seems like $this->getSppLevel($version) can also be of type null; however, parameter $sppLevel of Obblm\Core\Entity\PlayerVersion::setSppLevel() does only seem to accept string, maybe add an additional type check?

        return $version;
    }