ImageHelper::getRosterImage() - Code Metrics - Inspection of "Make Front + Fix some issues" - obblm/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (defee6)

by Benjamin

created 2020-09-28 16:17 UTC

ImageHelper::getRosterImage() A

↳ Parent: ImageHelper

Complexity

Conditions	5
Paths	4

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	15
c	1
b	0
f	0
nc	4
nop	4
dl	0
loc	22
rs	9.4555

<?php

namespace Obblm\Core\Helper;

use Doctrine\Common\Collections\ArrayCollection;
use Intervention\Image\ImageManager;
filter:
    dependency_paths: ["lib/*"]
use Obblm\Core\Entity\Rule;
use Obblm\Core\Entity\Team;
use Obblm\Core\Service\FileTeamUploader;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;
use \SplFileInfo;
use Symfony\Component\HttpFoundation\File\File;

class ImageHelper
{
    const RULE_PATH = '/rule';
    const TEAM_PATH = '/team';

    private $imageManager;
    private $ruleHelper;
    private $publicDirectory;
    private $cacheDirectory;
    private $ruleCacheDirectory;
    private $teamCacheDirectory;
    private $filesystem;
    private $fileTeamUploader;

    public function __construct(RuleHelper $ruleHelper, FileTeamUploader $fileTeamUploader, string $kernetProjectDir, string $cacheDirectory)
    {
        $this->imageManager = new ImageManager(['driver' => 'gd']);
        $this->ruleHelper = $ruleHelper;
        $this->publicDirectory = $kernetProjectDir;
        $this->cacheDirectory = $cacheDirectory;
        $this->ruleCacheDirectory = $this->cacheDirectory . self::RULE_PATH ;
        $this->teamCacheDirectory = $this->cacheDirectory . self::TEAM_PATH ;
        $this->filesystem = new Filesystem();
        $this->fileTeamUploader = $fileTeamUploader;
    }

    public function getTeamLogo(Team $team, int $width = null, int $height = null): ?string
    {
        if ($team->getLogoFilename()) {
            $this->fileTeamUploader->setObjectSubDirectory($team->getId());
            $filePath = $this->fileTeamUploader->getObjectDirectory() . '/' . $team->getLogoFilename();
            if ($width || $height) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                $newFilePath = $this->teamCacheDirectory . '/' . $team->getId();
                $file = new File($filePath);
                return $this->returnCachedAsset($file, $newFilePath, $width, $height);
            }
            // full sized
            return $this->sanitizeFilePath($filePath);
        }
        return null;
    }

    public function getTeamCover(Team $team, int $width = null, int $height = null): ?string
    {
        if ($team->getCoverFilename()) {
            $this->fileTeamUploader->setObjectSubDirectory($team->getId());
            $filePath = $this->fileTeamUploader->getObjectDirectory() . '/' . $team->getCoverFilename();
            if ($width || $height) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                $newFilePath = $this->teamCacheDirectory . '/' . $team->getId();
                $file = new File($filePath);
                return $this->returnCachedAsset($file, $newFilePath, $width, $height);
            }
            // full sized
            return $this->sanitizeFilePath($filePath);
        }
        return null;
    }

    public function getRosterImage(Rule $rule, string $roster, int $width = null, int $height = null): ?string
    {
        $helper = $this->ruleHelper->getHelper($rule);
        if ($helper->getRosters()->get($roster) && $rule->getRuleDirectory()) {
            $finder = new Finder();
            $directory = dirname(__DIR__) . $rule->getRuleDirectory() . '/assets/';
            $finder->files()
                ->name($roster . '.*')
                ->in($directory);
            if ($finder->hasResults()) {
                /** @var SplFileInfo[]|ArrayCollection $results */
                $results = new ArrayCollection();
                foreach ($finder as $file) {
                    $results->add($file);
                }
                // We have to resize
                $newFilePath = $this->ruleCacheDirectory . '/' . $rule->getId();
                $file = $results->first();
                return $this->returnCachedAsset($file, $newFilePath, $width, $height);
            }
        }
        return null;
    }

    private function returnCachedAsset(SplFileInfo $file, $path = '', $width = null, $height = null)
    {
        if ($width) {
            $path .= '/w' . $width;
        }
        if ($height) {
            $path .= '/h' . $height;
        }
        $newCacheDirectory = $path;
        $path .= '/' . $file->getFilename();
        if (!$this->filesystem->exists($path)) {
            $img = $this->imageManager->make($file);
            $this->filesystem->mkdir($newCacheDirectory);
            $img->resize($width, $height, function ($constraint) {
                $constraint->aspectRatio();
            });
            $img->save($path);
        }
        return $this->sanitizeFilePath($path);
    }

    private function sanitizeFilePath($filePath)
    {
        return str_replace($this->publicDirectory, '', $filePath);
    }
}


1			<?php
2
3			namespace Obblm\Core\Helper;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Intervention\Image\ImageManager;
			0 ignored issues – show Bug introduced 2020-09-28 16:23 UTC by Report Bug Copy Issue Report The type `Intervention\Image\ImageManager` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use Obblm\Core\Entity\Rule;
8			use Obblm\Core\Entity\Team;
9			use Obblm\Core\Service\FileTeamUploader;
10			use Symfony\Component\Filesystem\Filesystem;
11			use Symfony\Component\Finder\Finder;
12			use \SplFileInfo;
13			use Symfony\Component\HttpFoundation\File\File;
14
15			class ImageHelper
16			{
17			const RULE_PATH = '/rule';
18			const TEAM_PATH = '/team';
19
20			private $imageManager;
21			private $ruleHelper;
22			private $publicDirectory;
23			private $cacheDirectory;
24			private $ruleCacheDirectory;
25			private $teamCacheDirectory;
26			private $filesystem;
27			private $fileTeamUploader;
28
29			public function __construct(RuleHelper $ruleHelper, FileTeamUploader $fileTeamUploader, string $kernetProjectDir, string $cacheDirectory)
30			{
31			$this->imageManager = new ImageManager(['driver' => 'gd']);
32			$this->ruleHelper = $ruleHelper;
33			$this->publicDirectory = $kernetProjectDir;
34			$this->cacheDirectory = $cacheDirectory;
35			$this->ruleCacheDirectory = $this->cacheDirectory . self::RULE_PATH ;
36			$this->teamCacheDirectory = $this->cacheDirectory . self::TEAM_PATH ;
37			$this->filesystem = new Filesystem();
38			$this->fileTeamUploader = $fileTeamUploader;
39			}
40
41			public function getTeamLogo(Team $team, int $width = null, int $height = null): ?string
42			{
43			if ($team->getLogoFilename()) {
44			$this->fileTeamUploader->setObjectSubDirectory($team->getId());
45			$filePath = $this->fileTeamUploader->getObjectDirectory() . '/' . $team->getLogoFilename();
46			if ($width \|\| $height) {
			0 ignored issues – show Bug Best Practice introduced 2020-09-28 16:23 UTC by Report Bug Copy Issue Report The expression `$height` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history... Bug Best Practice introduced 2020-09-28 16:23 UTC by Report Bug Copy Issue Report The expression `$width` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
47			$newFilePath = $this->teamCacheDirectory . '/' . $team->getId();
48			$file = new File($filePath);
49			return $this->returnCachedAsset($file, $newFilePath, $width, $height);
50			}
51			// full sized
52			return $this->sanitizeFilePath($filePath);
53			}
54			return null;
55			}
56
57			public function getTeamCover(Team $team, int $width = null, int $height = null): ?string
58			{
59			if ($team->getCoverFilename()) {
60			$this->fileTeamUploader->setObjectSubDirectory($team->getId());
61			$filePath = $this->fileTeamUploader->getObjectDirectory() . '/' . $team->getCoverFilename();
62			if ($width \|\| $height) {
			0 ignored issues – show Bug Best Practice introduced 2020-09-28 16:23 UTC by Report Bug Copy Issue Report The expression `$height` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history... Bug Best Practice introduced 2020-09-28 16:23 UTC by Report Bug Copy Issue Report The expression `$width` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
63			$newFilePath = $this->teamCacheDirectory . '/' . $team->getId();
64			$file = new File($filePath);
65			return $this->returnCachedAsset($file, $newFilePath, $width, $height);
66			}
67			// full sized
68			return $this->sanitizeFilePath($filePath);
69			}
70			return null;
71			}
72
73			public function getRosterImage(Rule $rule, string $roster, int $width = null, int $height = null): ?string
74			{
75			$helper = $this->ruleHelper->getHelper($rule);
76			if ($helper->getRosters()->get($roster) && $rule->getRuleDirectory()) {
77			$finder = new Finder();
78			$directory = dirname(__DIR__) . $rule->getRuleDirectory() . '/assets/';
79			$finder->files()
80			->name($roster . '.*')
81			->in($directory);
82			if ($finder->hasResults()) {
83			/** @var SplFileInfo[]\|ArrayCollection $results */
84			$results = new ArrayCollection();
85			foreach ($finder as $file) {
86			$results->add($file);
87			}
88			// We have to resize
89			$newFilePath = $this->ruleCacheDirectory . '/' . $rule->getId();
90			$file = $results->first();
91			return $this->returnCachedAsset($file, $newFilePath, $width, $height);
92			}
93			}
94			return null;
95			}
96
97			private function returnCachedAsset(SplFileInfo $file, $path = '', $width = null, $height = null)
98			{
99			if ($width) {
100			$path .= '/w' . $width;
101			}
102			if ($height) {
103			$path .= '/h' . $height;
104			}
105			$newCacheDirectory = $path;
106			$path .= '/' . $file->getFilename();
107			if (!$this->filesystem->exists($path)) {
108			$img = $this->imageManager->make($file);
109			$this->filesystem->mkdir($newCacheDirectory);
110			$img->resize($width, $height, function ($constraint) {
111			$constraint->aspectRatio();
112			});
113			$img->save($path);
114			}
115			return $this->sanitizeFilePath($path);
116			}
117
118			private function sanitizeFilePath($filePath)
119			{
120			return str_replace($this->publicDirectory, '', $filePath);
121			}
122			}
123

obblm / core

Branch — develop (defee6)

ImageHelper::getRosterImage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like