TeamHelper::getLastVersion() - Code Metrics - Inspection of "Add tests + remove useless methods" - obblm/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — v1.x-dev (b0683a)

by Benjamin

created 2020-10-02 14:44 UTC

TeamHelper::getLastVersion() A

↳ Parent: TeamHelper

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2.0078

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	11
ccs	7
cts	8
cp	0.875
rs	10
cc	2
nc	2
nop	1
crap	2.0078

<?php

namespace Obblm\Core\Helper;

use Obblm\Core\Entity\Team;
use Obblm\Core\Entity\TeamVersion;
use Obblm\Core\Contracts\RuleHelperInterface;

/**
 * Class TeamHelper
 * @package Obblm\Core\Helper
 */
class TeamHelper
{
    private $ruleHelper;

    public function __construct(RuleHelper $ruleHelper)
    {
        $this->ruleHelper = $ruleHelper;
    }

    /**
     * @param Team $team
     * @return RuleHelperInterface
     * @throws \Exception
     */
    public function getRuleHelper(Team $team):RuleHelperInterface
    {
        if (!$team->getRule()) {
            throw new \Exception('This team does not have a rule');
        }
        return $this->ruleHelper->getHelper($team->getRule());
    }

    public static function getLastVersion(Team  $team):TeamVersion
    {
        $versions = $team->getVersions();
        /** @var TeamVersion $last */
        $last = $versions->first();
        if ($last) {

            return $last;
        }
        $version = new TeamVersion();
        $team->addVersion($version);
        return $version;
    }

    /**********************
     * TEAM HELPER METHODS
     **********************/

    /**
     * @param Team $team
     * @return TeamVersion
     * @throws \Psr\Cache\InvalidArgumentException
     */
    public function createNewTeamVersion(Team $team):TeamVersion
    {
        return (TeamHelper::getLastVersion($team))
            ->setTreasure($this->ruleHelper->getHelper($team->getRule())->getMaxTeamCost());
    }
    public function destructTeamVersion(Team $team):TeamVersion
    public function destructTeamVersion(/** @scrutinizer ignore-unused */ Team $team):TeamVersion
    {
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * @param Team $team
     * @return bool
     * @throws \Exception
     */
    public function couldHaveApothecary(Team $team):bool
    {
        if (!$team->getRule()) {
            throw new \Exception('This team does not have a rule');
        }
        return (bool) $this->getRuleHelper($team)->couldHaveApothecary($team);
    }
}


obblm / core

Branch — v1.x-dev (b0683a)

TeamHelper::getLastVersion() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like