Obblm\Core\Helper\PlayerHelper

Complexity

Total Complexity

13

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

32%

Importance

Changes	2
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getPlayerCharacteristics()	0	3	2
A	getPlayerValue()	0	3	2
A	__construct()	0	3	1
A	getPlayerSkills()	0	3	2
A	getBasePlayerVersion()	0	7	1
A	getPlayerSpp()	0	3	2
A	composePlayerKey()	0	3	1
A	getLastVersion()	0	9	2

<?php

namespace Obblm\Core\Helper;

use Obblm\Core\Entity\Player;
use Obblm\Core\Entity\PlayerVersion;
use Obblm\Core\Exception\NoVersionException;

class PlayerHelper
{
    private $teamHelper;

    public function __construct(TeamHelper $teamHelper)
    {
        $this->teamHelper = $teamHelper;
    }

    public static function getLastVersion(Player $player):PlayerVersion
    {
        $versions = $player->getVersions();
        /** @var PlayerVersion $last */
        $last = $versions->first();
        if (!$last) {

$last is of type Obblm\Core\Entity\PlayerVersion, thus it always evaluated to true.

            throw new NoVersionException($player);
        }
        return $last;
    }
    public function getBasePlayerVersion(Player $player):array
    {
        list($ruleKey, $roster, $type) = explode(CoreTranslation::TRANSLATION_GLUE, $player->getType());
        $helper = $this->teamHelper->getRuleHelper($player->getTeam());

It seems like $player->getTeam() can also be of type null; however, parameter $team of Obblm\Core\Helper\TeamHelper::getRuleHelper() does only seem to accept Obblm\Core\Entity\Team, maybe add an additional type check?

        $base = $helper->getAttachedRule()->getRule()['rosters'][$roster]['players'][$type];
        $base['injuries'] = [];
        return $base;
    }

    public static function composePlayerKey($ruleKey, $roster, $type):string
    {
        return join(CoreTranslation::TRANSLATION_GLUE, [$ruleKey, $roster, $type]);
    }

    public static function getPlayerSkills(Player $player):array
    {
        return self::getLastVersion($player)->getSkills() ?: [];
    }

    public static function getPlayerCharacteristics(Player $player):array
    {
        return self::getLastVersion($player)->getCharacteristics() ?: [];
    }

    public static function getPlayerSpp(Player $player):string
    {
        return self::getLastVersion($player)->getSpp() ?: 0;
    }

    public static function getPlayerValue(Player $player):string
    {
        return self::getLastVersion($player)->getValue() ?: 0;
    }
}