obblm /
core
| Total Complexity | 53 |
| Total Lines | 322 |
| Duplicated Lines | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like RuleConfigBuilder often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RuleConfigBuilder, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class RuleConfigBuilder extends RuleConfigResolver implements RuleBuilderInterface |
||
| 24 | { |
||
| 25 | /** @var ArrayCollection */ |
||
| 26 | private $injuries; |
||
| 27 | /** @var ArrayCollection|Skill[] */ |
||
| 28 | private $skills; |
||
| 29 | /** @var ArrayCollection|InducementType[] */ |
||
| 30 | private $inducement_types; |
||
| 31 | /** @var ArrayCollection */ |
||
| 32 | private $spp_levels; |
||
| 33 | /** @var ArrayCollection|InducementInterface[] */ |
||
| 34 | private $inducements; |
||
| 35 | /** @var ArrayCollection|RosterInterface[] */ |
||
| 36 | private $rosters; |
||
| 37 | |||
| 38 | protected function build(string $rule_key, array $rule) { |
||
| 39 | |||
| 40 | $treeResolver = new ConfigResolver($this); |
||
| 41 | $rule = $treeResolver->resolve($rule); |
||
| 42 | $this->prepareInjuriesTable($rule_key, $rule); |
||
| 43 | $this->prepareSppTable($rule_key, $rule); |
||
| 44 | $this->prepareSkillsTable($rule_key, $rule); |
||
| 45 | $this->prepareInducementTypes($rule_key, $rule); |
||
| 46 | $this->prepareInducementTable($rule_key, $rule); |
||
| 47 | $this->prepareRosterTable($rule_key, $rule); |
||
| 48 | } |
||
| 49 | |||
| 50 | public function getInjuries():ArrayCollection |
||
| 51 | { |
||
| 52 | return $this->injuries; |
||
| 53 | } |
||
| 54 | |||
| 55 | public function setInjuries(ArrayCollection $injuries):self |
||
| 56 | { |
||
| 57 | $this->injuries = $injuries; |
||
| 58 | return $this; |
||
| 59 | } |
||
| 60 | |||
| 61 | public function getInducementTypes():ArrayCollection |
||
| 62 | { |
||
| 63 | return $this->inducement_types; |
||
| 64 | } |
||
| 65 | |||
| 66 | public function setInducementTypes(ArrayCollection $inducement_types):self |
||
| 67 | { |
||
| 68 | $this->inducement_types = $inducement_types; |
||
| 69 | return $this; |
||
| 70 | } |
||
| 71 | |||
| 72 | public function getSppLevels():ArrayCollection |
||
| 73 | { |
||
| 74 | return $this->spp_levels; |
||
| 75 | } |
||
| 76 | |||
| 77 | public function setSppLevels(ArrayCollection $spp_levels):self |
||
| 78 | { |
||
| 79 | $this->spp_levels = $spp_levels; |
||
| 80 | return $this; |
||
| 81 | } |
||
| 82 | |||
| 83 | public function getInducementTable():ArrayCollection |
||
| 84 | { |
||
| 85 | return $this->inducements; |
||
| 86 | } |
||
| 87 | |||
| 88 | public function setInducementTable(ArrayCollection $inducements):self |
||
| 89 | { |
||
| 90 | $this->inducements = $inducements; |
||
| 91 | return $this; |
||
| 92 | } |
||
| 93 | |||
| 94 | public function getRosters():ArrayCollection |
||
| 95 | { |
||
| 96 | return $this->rosters; |
||
| 97 | } |
||
| 98 | |||
| 99 | public function setRosters(ArrayCollection $rosters):self |
||
| 100 | { |
||
| 101 | $this->rosters = $rosters; |
||
| 102 | return $this; |
||
| 103 | } |
||
| 104 | |||
| 105 | public function getSkills():ArrayCollection |
||
| 106 | { |
||
| 107 | return $this->skills; |
||
| 108 | } |
||
| 109 | |||
| 110 | public function setSkills(ArrayCollection $skills):self |
||
| 111 | { |
||
| 112 | $this->skills = $skills; |
||
| 113 | return $this; |
||
| 114 | } |
||
| 115 | |||
| 116 | private function prepareInjuriesTable(string $rule_key, array $rule) |
||
| 117 | { |
||
| 118 | $this->injuries = new ArrayCollection(); |
||
| 119 | foreach ($rule['injuries'] as $key => $injury) { |
||
| 120 | $label = CoreTranslation::getInjuryKey($rule_key, $key); |
||
| 121 | $effect_label = CoreTranslation::getInjuryEffect($rule_key, $key); |
||
| 122 | if (isset($injury['to'])) { |
||
| 123 | for ($i = $injury['from']; $i <= $injury['to']; $i++) { |
||
| 124 | $this->injuries->set( |
||
| 125 | $i, |
||
| 126 | (object) ['value' => $i, 'label' => $label, 'effect_label' => $effect_label, 'effects' => $injury['effects']] |
||
| 127 | ); |
||
| 128 | } |
||
| 129 | } else { |
||
| 130 | $this->injuries->set( |
||
| 131 | $injury['from'], |
||
| 132 | (object) ['value' => $injury['from'], 'label' => $label, 'effect_label' => $effect_label, 'effects' => $injury['effects']] |
||
| 133 | ); |
||
| 134 | } |
||
| 135 | } |
||
| 136 | } |
||
| 137 | |||
| 138 | private function prepareInducementTypes(string $rule_key, array $rule) |
||
| 139 | { |
||
| 140 | $this->inducement_types = new ArrayCollection(); |
||
| 141 | $this->inducement_types->set('star_players', new InducementType([ |
||
| 142 | 'key' => 'star_players', |
||
| 143 | 'translation_key' => CoreTranslation::getStarPlayerTitle($rule_key), |
||
| 144 | 'translation_domain' => $rule_key, |
||
| 145 | ])); |
||
| 146 | $this->inducement_types->set('inducements', new InducementType([ |
||
| 147 | 'key' => 'inducements', |
||
| 148 | 'translation_key' => CoreTranslation::getInducementTitle($rule_key), |
||
| 149 | 'translation_domain' => $rule_key, |
||
| 150 | ])); |
||
| 151 | $this->inducement_types->set('mercenary', new InducementType([ |
||
| 152 | 'key' => 'mercenary', |
||
| 153 | 'translation_key' => CoreTranslation::getMercenaryTitle($rule_key), |
||
| 154 | 'translation_domain' => $rule_key, |
||
| 155 | ])); |
||
| 156 | } |
||
| 157 | |||
| 158 | private function prepareSppTable(string $rule_key, array $rule) |
||
| 159 | { |
||
| 160 | $spps = new ArrayCollection($rule['spp_levels']); |
||
| 161 | foreach ($spps as $from => $level) { |
||
| 162 | $to = $spps->next(); |
||
| 163 | if ($to) { |
||
| 164 | for ($i = $from; $i < $spps->indexOf($to); $i++) { |
||
| 165 | if (!isset($spps[$i])) { |
||
| 166 | $spps[$i] = $level; |
||
| 167 | } |
||
| 168 | } |
||
| 169 | } |
||
| 170 | } |
||
| 171 | $spps = $spps->toArray(); |
||
| 172 | ksort($spps); |
||
| 173 | $this->spp_levels = new ArrayCollection($spps); |
||
| 174 | } |
||
| 175 | |||
| 176 | private function prepareSkillsTable(string $rule_key, array $rule) |
||
| 190 | ]) |
||
| 191 | ); |
||
| 192 | } |
||
| 193 | } |
||
| 194 | } |
||
| 195 | |||
| 196 | private function prepareInducementTable(string $rule_key, array $rule) |
||
| 197 | { |
||
| 198 | $this->inducements = new ArrayCollection(); |
||
| 199 | |||
| 200 | foreach ($rule['inducements'] as $key => $value) { |
||
| 201 | if ($key !== 'star_players') { |
||
| 202 | $inducement = new Inducement([ |
||
| 203 | 'type' => $this->inducement_types['inducements'], |
||
| 204 | 'key' => join(CoreTranslation::TRANSLATION_GLUE, [$rule_key, 'inducements', $key]), |
||
| 205 | 'translation_domain' => $rule_key, |
||
| 206 | 'translation_key' => CoreTranslation::getInducementName($rule_key, $key), |
||
| 207 | 'max' => $value['max'] ?? 0, |
||
| 208 | 'rosters' => $value['rosters'] ?? null, |
||
| 209 | 'value' => $value['cost'], |
||
| 210 | 'discount_cost' => $value['discount_cost'] ?? null, |
||
| 211 | ]); |
||
| 212 | if (!$this->inducements->contains($inducement)) { |
||
| 213 | $this->inducements->add($inducement); |
||
| 214 | } |
||
| 215 | } |
||
| 216 | } |
||
| 217 | foreach ($rule['star_players'] as $key => $star_player) { |
||
| 218 | try { |
||
| 219 | $inducement = $this->createStarPlayerInducement($rule_key, $key, $star_player); |
||
| 220 | if (!$this->inducements->contains($inducement)) { |
||
| 221 | $this->inducements->add($inducement); |
||
| 222 | } |
||
| 223 | } catch (NotFoundRuleKeyExcepion $e) { |
||
|
Coding Style
Comprehensibility
introduced
by
|
|||
| 224 | } |
||
| 225 | } |
||
| 226 | } |
||
| 227 | |||
| 228 | private function prepareRosterTable(string $rule_key, array $rule) |
||
| 242 | ]) |
||
| 243 | ); |
||
| 244 | } |
||
| 245 | } |
||
| 246 | |||
| 247 | private function createStarPlayerInducement(string $rule_key, string $key, array $star_player):InducementInterface |
||
| 248 | { |
||
| 249 | $options = [ |
||
| 250 | 'type' => $this->inducement_types['star_players'], |
||
| 251 | 'key' => join(CoreTranslation::TRANSLATION_GLUE, [$rule_key, 'star_players', $key]), |
||
| 252 | 'value' => $star_player['cost'], |
||
| 253 | 'discount_cost' => $value['discount_cost'] ?? null, |
||
| 254 | 'characteristics' => $star_player['characteristics'] ?? null, |
||
| 255 | 'skills' => $star_player['skills'] ?? null, |
||
| 256 | 'rosters' => $star_player['rosters'] ?? null, |
||
| 257 | 'translation_domain' => $rule_key, |
||
| 258 | 'translation_key' => CoreTranslation::getStarPlayerName($rule_key, $key), |
||
| 259 | 'max' => $options['max'] ?? 1, |
||
| 260 | ]; |
||
| 261 | if (isset($star_player['multi_parts']) && $star_player['multi_parts']) { |
||
| 262 | $options['parts'] = []; |
||
| 263 | $first = true; |
||
| 264 | foreach ($star_player['multi_parts'] as $key => $part) { |
||
| 265 | $part['cost'] = $first ? $star_player['cost'] : 0; |
||
| 266 | $options['parts'][] = $this->createStarPlayerInducement($rule_key, $key, $part); |
||
| 267 | $first = false; |
||
| 268 | } |
||
| 269 | $inducement = new MultipleStarPlayer($options); |
||
| 270 | } else { |
||
| 271 | $inducement = new StarPlayer($options); |
||
| 272 | } |
||
| 273 | return $inducement; |
||
| 274 | } |
||
| 275 | |||
| 276 | protected function getInducementExpression($options = ['type' => 'inducements']):CompositeExpression |
||
| 277 | { |
||
| 278 | $sub_expressions = []; |
||
| 279 | if (isset($options['type'])) { |
||
| 280 | // Criteria by inducement type |
||
| 281 | if (is_array($options['type'])) { |
||
| 282 | $types = []; |
||
| 283 | foreach ($options['type'] as $type) { |
||
| 284 | if (is_string($type)) { |
||
| 285 | $inducementType = $this->getInducementType($type); |
||
| 286 | $types[] = Criteria::expr()->eq('type', $inducementType); |
||
| 287 | } |
||
| 288 | } |
||
| 289 | $sub_expressions['type'] = new CompositeExpression(CompositeExpression::TYPE_OR, $types); |
||
| 290 | ; |
||
| 291 | } elseif (is_string($options['type'])) { |
||
| 292 | $inducementType = $this->getInducementType($options['type']); |
||
| 293 | $sub_expressions['type'] = Criteria::expr()->eq('type', $inducementType); |
||
| 294 | } |
||
| 295 | } |
||
| 296 | if (isset($options['cost_limit'])) { |
||
| 297 | // Criteria by cost limit |
||
| 298 | if (is_int($options['cost_limit'])) { |
||
| 299 | $sub_expressions['cost'] = Criteria::expr()->lte('value', $options['cost_limit']); |
||
| 300 | } |
||
| 301 | } |
||
| 302 | if (isset($options['roster'])) { |
||
| 303 | // Criteria by roster |
||
| 304 | if (is_string($options['roster'])) { |
||
| 305 | $sub_expressions['roster'] = Criteria::expr()->orX( |
||
| 306 | Criteria::expr()->memberOf('rosters', $options['roster']), |
||
| 307 | Criteria::expr()->eq('rosters', []) |
||
| 308 | ); |
||
| 309 | } |
||
| 310 | } |
||
| 311 | $composite = new CompositeExpression(CompositeExpression::TYPE_AND, $sub_expressions); |
||
| 312 | return $composite; |
||
| 313 | } |
||
| 314 | |||
| 315 | public function getInducementsFor(Team $team, ?int $budget = null):array |
||
| 333 | } |
||
| 334 | |||
| 335 | public function getAllStarPlayers():array |
||
| 336 | { |
||
| 337 | $criteria = Criteria::create(); |
||
| 338 | |||
| 339 | $criteria->where(Criteria::expr()->andX( |
||
| 340 | $this->getInducementExpression([ |
||
| 341 | 'type' => 'star_players' |
||
| 342 | ]) |
||
| 343 | )); |
||
| 344 | return $this->getInducementTable()->matching($criteria)->toArray(); |
||
| 345 | } |
||
| 346 | } |
||
| 347 |
Loading history...