Obblm\Core\Validator\Constraints\Team\CompositionValidator

Complexity

Total Complexity

10

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	validate()	0	31	9

<?php

namespace Obblm\Core\Validator\Constraints\Team;

use Obblm\Core\Entity\Team;
use Obblm\Core\Entity\TeamVersion;
use Obblm\Core\Helper\CoreTranslation;
use Obblm\Core\Helper\RuleHelper;
use Obblm\Core\Helper\TeamHelper;
use Symfony\Component\Form\Exception\UnexpectedTypeException;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;
use Symfony\Contracts\Translation\TranslatorInterface;

class CompositionValidator extends ConstraintValidator
{
    private $ruleHelper;
    private $translator;

    public function __construct(RuleHelper $ruleHelper, TranslatorInterface $translator)
    {
        $this->ruleHelper = $ruleHelper;
        $this->translator = $translator;
    }

    public function validate($value, Constraint $constraint)
    {
        if (!$constraint instanceof Composition) {
            throw new UnexpectedTypeException($constraint, Composition::class);
        }

        if ($value instanceof TeamVersion) {
            $value->getNotDeadPlayerVersions();
        }

        if (!$value instanceof TeamVersion) {
            throw new UnexpectedTypeException($value, TeamVersion::class);
        }
        if ($value instanceof Team) {

$value is never a sub-type of Obblm\Core\Entity\Team.

            $value = TeamHelper::getLastVersion($value);
        }
        $count = [];

        /** @var TeamVersion $value */
        $team  = $value->getTeam();
        $helper = $this->ruleHelper->getHelper($team);
        foreach ($value->getNotDeadPlayerVersions() as $version) {
            if ($version->getPlayer()->getPosition()) {
                $position = $version->getPlayer()->getPosition();
                $basePosition = $helper->getRoster($team)->getPosition($position);

It seems like $team can also be of type null; however, parameter $team of Obblm\Core\Contracts\Rule\RuleBuilderInterface::getRoster() does only seem to accept Obblm\Core\Entity\Team, maybe add an additional type check?

                isset($count[$position]) ? $count[$position]++ : $count[$position] = 1;
                if ($count[$position] > $basePosition->getMax()) {
                    $this->context->buildViolation($constraint->limitMessage)
                        ->setParameter('{{ limit }}', $basePosition->getMax())
                        ->setParameter('{{ player_type }}', $this->translator->trans($basePosition->getName(), [], $basePosition->getTranslationDomain()))
                        ->addViolation();
                }
            }
        }
    }
}