obblm /
core
| Conditions | 11 |
| Paths | 9 |
| Total Lines | 38 |
| Code Lines | 31 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 132 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 24 | public function validate($value, Constraint $constraint) |
||
| 25 | { |
||
| 26 | if (!$constraint instanceof SkillsQuantity) { |
||
| 27 | throw new UnexpectedTypeException($constraint, SkillsQuantity::class); |
||
| 28 | } |
||
| 29 | if (!$value instanceof TeamVersion) { |
||
| 30 | throw new UnexpectedTypeException($value, TeamVersion::class); |
||
| 31 | } |
||
| 32 | $this->max['total'] = $value->getTeam()->getCreationOption("skills_allowed.total") ?: 0; |
||
| 33 | $this->initializeMaxValues($value, $constraint->context); |
||
| 34 | |||
| 35 | $this->helper = $this->ruleHelper->getHelper($value->getTeam()); |
||
| 36 | foreach ($value->getNotDeadPlayerVersions() as $playerVersion) { |
||
| 37 | if (count($playerVersion->getAdditionalSkills()) > $value->getTeam()->getCreationOption("skills_allowed.max_skills_per_player")) { |
||
| 38 | $this->context->buildViolation($constraint->limitByPlayerMessage) |
||
| 39 | ->setParameter('{{ limit }}', $value->getTeam()->getCreationOption("skills_allowed.max_skills_per_player")) |
||
|
Bug
introduced
by
|
|||
| 40 | ->addViolation(); |
||
| 41 | return; |
||
| 42 | } |
||
| 43 | foreach ($playerVersion->getAdditionalSkills() as $skillKey) { |
||
| 44 | $skill = $this->helper->getSkill($skillKey); |
||
| 45 | $context = $this->helper->getSkillContextForPlayerVersion($playerVersion, $skill); |
||
| 46 | $this->count['total']++; |
||
| 47 | if ($this->count['total'] > $this->max['total']) { |
||
| 48 | $this->context->buildViolation($constraint->limitMessage) |
||
| 49 | ->setParameter('{{ limit }}', $this->max['total']) |
||
| 50 | ->addViolation(); |
||
| 51 | return; |
||
| 52 | } |
||
| 53 | if (isset($this->max[$context])) { |
||
| 54 | $this->count[$context]++; |
||
| 55 | $limit = $this->max[$context] ?: 0; |
||
| 56 | if ($this->count[$context] > $limit) { |
||
| 57 | $this->context->buildViolation($constraint->limitByTypeMessage) |
||
| 58 | ->setParameter('{{ type }}', $context) |
||
| 59 | ->setParameter('{{ limit }}', $limit) |
||
| 60 | ->addViolation(); |
||
| 61 | return; |
||
| 62 | } |
||
| 80 |
Loading history...