Obblm\Core\Helper\TeamHelper

Complexity

Total Complexity

9

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

29.17%

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getRuleHelper()	0	6	2
A	__construct()	0	3	1
A	createNewTeamVersion()	0	4	1
A	destructTeamVersion()	0	2	1
A	couldHaveApothecary()	0	6	2
A	getLastVersion()	0	11	2

<?php

namespace Obblm\Core\Helper;

use Obblm\Core\Entity\Team;
use Obblm\Core\Entity\TeamVersion;
use Obblm\Core\Contracts\RuleHelperInterface;

/**
 * Class TeamHelper
 * @package Obblm\Core\Helper
 */
class TeamHelper
{
    private $ruleHelper;

    public function __construct(RuleHelper $ruleHelper)
    {
        $this->ruleHelper = $ruleHelper;
    }

    /**
     * @param Team $team
     * @return RuleHelperInterface
     * @throws \Exception
     */
    public function getRuleHelper(Team $team):RuleHelperInterface
    {
        if (!$team->getRule()) {
            throw new \Exception('This team does not have a rule');
        }
        return $this->ruleHelper->getHelper($team->getRule());
    }

    public static function getLastVersion(Team  $team):TeamVersion
    {
        $versions = $team->getVersions();
        /** @var TeamVersion $last */
        $last = $versions->first();
        if ($last) {

$last is of type Obblm\Core\Entity\TeamVersion, thus it always evaluated to true.

            return $last;
        }
        $version = new TeamVersion();
        $team->addVersion($version);
        return $version;
    }

    /**********************
     * TEAM HELPER METHODS
     **********************/

    /**
     * @param Team $team
     * @return TeamVersion
     * @throws \Psr\Cache\InvalidArgumentException
     */
    public function createNewTeamVersion(Team $team):TeamVersion
    {
        return (TeamHelper::getLastVersion($team))
            ->setTreasure($this->ruleHelper->getHelper($team->getRule())->getMaxTeamCost());
    }
    public function destructTeamVersion(Team $team):TeamVersion

The parameter $team is not used and could be removed.

    {
    }

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Obblm\Core\Entity\TeamVersion. Consider adding a return statement or allowing null as return value.

    /**
     * @param Team $team
     * @return bool
     * @throws \Exception
     */
    public function couldHaveApothecary(Team $team):bool
    {
        if (!$team->getRule()) {
            throw new \Exception('This team does not have a rule');
        }
        return (bool) $this->getRuleHelper($team)->couldHaveApothecary($team);
    }
}