Obblm\Core\Controller\Admin\UserAdminController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	0	17	4
A	index()	0	9	1
A	add()	0	16	3

<?php

namespace Obblm\Core\Controller\Admin;

use Obblm\Core\Entity\Coach;
use Doctrine\ORM\EntityManagerInterface;
use Obblm\Core\Form\Coach\AdminUserForm;
use Obblm\Core\Security\Roles;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;

/**
 * Class UserAdminController
 * @package Obblm\Core\Controller\Admin
 *
 * @Route("/admin/users")
 */
class UserAdminController extends AbstractController
{
    /**
     * @Route("/", name="admin_users")
     */
    public function index(EntityManagerInterface $em):Response
    {
        $this->denyAccessUnlessGranted(Roles::ADMIN);

        $users = $em->getRepository(Coach::class)
                    ->findAll();

        return $this->render('@ObblmCore/admin/users/index.html.twig', [
            'users' => $users
        ]);
    }
    /**
     * @Route("/add", name="admin_users_add")
     */
    public function add(Request $request, UserPasswordEncoderInterface $passwordEncoder, EntityManagerInterface $em):Response
    {
        $this->denyAccessUnlessGranted(Roles::ADMIN);

        $user = new Coach();
        $form = $this->createForm(AdminUserForm::class, $user);

        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            $password = $passwordEncoder->encodePassword($user, $user->getPlainPassword());

It seems like $user->getPlainPassword() can also be of type null; however, parameter $plainPassword of Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface::encodePassword() does only seem to accept string, maybe add an additional type check?

            $user->setPassword($password)->setPlainPassword('');
            $em->persist($user);
            $em->flush();
        }
        return $this->render('@ObblmCore/admin/users/form.html.twig', [
            'form' => $form->createView()
        ]);
    }
    /**
     * @Route("/edit/{user}", name="admin_users_edit")
     */
    public function edit(Coach $user, Request $request, UserPasswordEncoderInterface $passwordEncoder, EntityManagerInterface $em):Response
    {
        $this->denyAccessUnlessGranted(Roles::ADMIN);

        $form = $this->createForm(AdminUserForm::class, $user);

        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            if ($user->getPlainPassword() !== null) {
                $password = $passwordEncoder->encodePassword($user, $user->getPlainPassword());
                $user->setPassword($password)->setPlainPassword('');
            }
            $em->persist($user);
            $em->flush();
        }
        return $this->render('@ObblmCore/admin/users/form.html.twig', [
            'form' => $form->createView()
        ]);
    }
}