Issues in Select.js (master) - Issues in master - o2system/venus-form - Measure and Improve Code Quality continuously with Scrutinizer

Issues (23)

src/Components/Select.js (3 issues)

Labels

Severity

Minor 3

/**
 * This file is part of the O2System Venus UI Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author         Steeve Andrian Salim
 * @copyright      Copyright (c) Steeve Andrian Salim
 */
// ------------------------------------------------------------------------

import * as $ from 'jquery';
import 'select2';
import 'bootstrap-select';
import 'selectize';
require('multiselect');
require('jquery.quicksearch');

/**
 * Class Select
 *
 * @author          Teguh Rianto
 * @package         Components
 */
export default class Select {
    constructor() {
        /**
         * Initiate select with search
         */
        this.selectWithSearch();

        /**
         * Initiate select insertable search
         */
        this.selectInsertableSearch();

        /**
         * Initiate select dropdown
         */
        this.selectDropdown();

        /**
         * Initiate select multi
         */
        this.selectMulti();
    }

    selectWithSearch() {
        $(".select-with-search").select2();
    }

    selectInsertableSearch() {
        $('.select-insertable-search').selectize({
            create: true,
            sortField: 'text'
        });

        $('.select-with-tags').selectize({
            delimiter: ',',
            persist: false,
            create: function (input) {
                return {
                    value: input,
                    text: input
                }
            }
        });
    }

    selectDropdown() {
        $('.select-dropdown').selectpicker();
    }

    selectMulti() {
        $('.multiselect-search').multiSelect({
            selectableHeader: "<input type='text' class='search-input form-control mb-2' autocomplete='off' placeholder='Search...'>",
            selectionHeader: "<input type='text' class='search-input form-control mb-2' autocomplete='off' placeholder='Search...'>",
            afterInit: function(ms){

              var that = this,
                  $selectableSearch = that.$selectableUl.prev(),
                  $selectionSearch = that.$selectionUl.prev(),
                  selectableSearchString = '#'+that.$container.attr('id')+' .ms-elem-selectable:not(.ms-selected)',
                  selectionSearchString = '#'+that.$container.attr('id')+' .ms-elem-selection.ms-selected';
          
              that.qs1 = $selectableSearch.quicksearch(selectableSearchString)
              .on('keydown', function(e){
                if (e.which === 40){
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                  that.$selectableUl.focus();
                  return false;
                }
              });
          
              that.qs2 = $selectionSearch.quicksearch(selectionSearchString)
              .on('keydown', function(e){
                if (e.which == 40){
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                  that.$selectionUl.focus();
                  return false;
                }
              });
            },
            afterSelect: function(){
              this.qs1.cache();
              this.qs2.cache();
            },
            afterDeselect: function(){
              this.qs1.cache();
              this.qs2.cache();
            }
        
        });
    }
}

1			/**
2			* This file is part of the O2System Venus UI Framework package.
3			*
4			* For the full copyright and license information, please view the LICENSE
5			* file that was distributed with this source code.
6			*
7			* @author Steeve Andrian Salim
8			* @copyright Copyright (c) Steeve Andrian Salim
9			*/
10			// ------------------------------------------------------------------------
11
12			import * as $ from 'jquery';
13			import 'select2';
14			import 'bootstrap-select';
15			import 'selectize';
16			require('multiselect');
17			require('jquery.quicksearch');
18
19			/**
20			* Class Select
21			*
22			* @author Teguh Rianto
23			* @package Components
24			*/
25			export default class Select {
26			constructor() {
27			/**
28			* Initiate select with search
29			*/
30			this.selectWithSearch();
31
32			/**
33			* Initiate select insertable search
34			*/
35			this.selectInsertableSearch();
36
37			/**
38			* Initiate select dropdown
39			*/
40			this.selectDropdown();
41
42			/**
43			* Initiate select multi
44			*/
45			this.selectMulti();
46			}
47
48			selectWithSearch() {
49			$(".select-with-search").select2();
50			}
51
52			selectInsertableSearch() {
53			$('.select-insertable-search').selectize({
54			create: true,
55			sortField: 'text'
56			});
57
58			$('.select-with-tags').selectize({
59			delimiter: ',',
60			persist: false,
61			create: function (input) {
62			return {
63			value: input,
64			text: input
65			}
66			}
67			});
68			}
69
70			selectDropdown() {
71			$('.select-dropdown').selectpicker();
72			}
73
74			selectMulti() {
75			$('.multiselect-search').multiSelect({
76			selectableHeader: "<input type='text' class='search-input form-control mb-2' autocomplete='off' placeholder='Search...'>",
77			selectionHeader: "<input type='text' class='search-input form-control mb-2' autocomplete='off' placeholder='Search...'>",
78			afterInit: function(ms){
			0 ignored issues – show Unused Code introduced 2019-08-29 10:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `ms` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
79			var that = this,
80			$selectableSearch = that.$selectableUl.prev(),
81			$selectionSearch = that.$selectionUl.prev(),
82			selectableSearchString = '#'+that.$container.attr('id')+' .ms-elem-selectable:not(.ms-selected)',
83			selectionSearchString = '#'+that.$container.attr('id')+' .ms-elem-selection.ms-selected';
84
85			that.qs1 = $selectableSearch.quicksearch(selectableSearchString)
86			.on('keydown', function(e){
87			if (e.which === 40){
			0 ignored issues – show Complexity Best Practice introduced 2019-08-29 10:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no return statement if `e.which === 40` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
88			that.$selectableUl.focus();
89			return false;
90			}
91			});
92
93			that.qs2 = $selectionSearch.quicksearch(selectionSearchString)
94			.on('keydown', function(e){
95			if (e.which == 40){
			0 ignored issues – show Complexity Best Practice introduced 2019-08-29 10:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no return statement if `e.which == 40` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
96			that.$selectionUl.focus();
97			return false;
98			}
99			});
100			},
101			afterSelect: function(){
102			this.qs1.cache();
103			this.qs2.cache();
104			},
105			afterDeselect: function(){
106			this.qs1.cache();
107			this.qs2.cache();
108			}
109
110			});
111			}
112			}

GitHub Access Token became invalid

Issues (23)

src/Components/Select.js (3 issues)

Labels

Severity

Introduced By

o2system / venus-form

GitHub Access Token became invalid

Issues (23)

src/Components/Select.js (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like