O2System\Reactor\Cli\Commanders\Build::execute()

Complexity

Conditions	16
Paths	164

Size

Total Lines	114
Code Lines	75

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

<?php
    public function execute()
    {
        $this->__callOptions();

        $filename = empty($this->optionFilename) ? 'app.phar' : $this->optionFilename;
        $filename = str_replace('.phar', '', $filename);
        $filePath = PATH_ROOT . 'build' . DIRECTORY_SEPARATOR . $filename;

The constant O2System\Reactor\Cli\Commanders\PATH_ROOT was not found. Maybe you did not declare it correctly or list all dependencies?

        if (ini_get('phar.readonly') == 1 and $this->optionForce === false) {

The property optionForce does not exist on O2System\Reactor\Cli\Commanders\Build. Did you maybe forget to declare it?

            output()->write(

The method write() does not exist on O2System\Kernel\Http\Output.

                (new Format())
                    ->setContextualClass(Format::DANGER)
                    ->setString(language()->getLine('CLI_BUILD_PHAR_READONLY'))
                    ->setNewLinesAfter(1)
            );
            exit(EXIT_ERROR);

Using exit here is not recommended.

        }

        output()->verbose(

The method verbose() does not exist on O2System\Kernel\Http\Output.

            (new Format())
                ->setContextualClass(Format::INFO)
                ->setString(language()->getLine('CLI_BUILD_START'))
                ->setNewLinesAfter(1)
        );

        // Remove build directory
        $fileDirectory = dirname($filePath) . DIRECTORY_SEPARATOR;
        if (is_dir($fileDirectory)) {
            $directoryHandle = opendir($fileDirectory);
            if ( ! $directoryHandle) {

$directoryHandle is of type false|resource, thus it always evaluated to false.

                return false;
            }
            while ($file = readdir($directoryHandle)) {
                if ($file != '.' && $file != '..') {
                    if (is_file($fileDirectory . $file)) {
                        unlink($fileDirectory . $file);
                    }
                }
            }
            closedir($directoryHandle);
            rmdir($fileDirectory);
        }

        if ( ! is_writable(dirname($filePath))) {
            @mkdir(dirname($filePath), 0777, true);

It seems like you do not handle an error condition for mkdir(). This can introduce security issues, and is generally not recommended.

            output()->verbose(
                (new Format())
                    ->setContextualClass(Format::INFO)
                    ->setString(language()->getLine('CLI_BUILD_MAKE_DIRECTORY'))
                    ->setNewLinesAfter(1)
            );
        }

        try {
            $pharData = new \PharData($filePath . '.tar');
            $phar = $pharData->convertToExecutable(\Phar::PHAR);

            // Build from PATH_ROOT using Recursive Directory Iterator
            $phar->buildFromIterator(new \RecursiveIteratorIterator(new \RecursiveCallbackFilterIterator(
                new \RecursiveDirectoryIterator(PATH_ROOT,
                    \FilesystemIterator::SKIP_DOTS | \FilesystemIterator::FOLLOW_SYMLINKS),
                function ($current, $key, $iterator) {

function(...) { /* ... */ } of type callable is incompatible with the type string expected by parameter $callback of RecursiveCallbackFilterIterator::__construct().

The parameter $key is not used and could be removed.

The parameter $iterator is not used and could be removed.

                    if ($current->isDir()) {
                        // exclude build directory
                        if ($current->getFilename() === 'build') {
                            return false;
                        }
                    }

                    return true;
                })), PATH_ROOT);

            // Define main script
            $main = 'public/index.php';
            if (empty($this->optionMain)) {
                // Default Carbon Boilerplate Detection
                if (is_file(PATH_APP . 'console')) {
                    $main = 'app/console';

                    output()->verbose(
                        (new Format())
                            ->setContextualClass(Format::WARNING)
                            ->setString(language()->getLine('CLI_BUILD_USE_CARBON_DEFAULT'))
                            ->setNewLinesAfter(1)
                    );
                }
            } else {
                $main = $this->optionMain;
            }

            $phar->setStub($phar->createDefaultStub($main));

            output()->verbose(
                (new Format())
                    ->setContextualClass(Format::INFO)
                    ->setString(language()->getLine('CLI_BUILD_START_GZ_COMPRESSION'))
                    ->setNewLinesAfter(1)
            );

            $pharData->convertToExecutable(\Phar::TAR, \Phar::GZ, '.phar.tgz');

            output()->write(
                (new Format())
                    ->setContextualClass(Format::SUCCESS)
                    ->setString(language()->getLine('CLI_BUILD_SUCCESSFUL'))
                    ->setNewLinesAfter(1)
            );
        } catch (\Exception $exception) {
            output()->write(
                (new Format())
                    ->setContextualClass(Format::DANGER)
                    ->setString($exception->getMessage())
                    ->setNewLinesAfter(1)
            );
}