O2System\Reactor\Models\Sql\Relations\HasOne

Complexity

Total Complexity

8

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	getResult()	0	36	8

<?php
/**
 * This file is part of the O2System PHP Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author         Steeve Andrian Salim
 * @copyright      Copyright (c) Steeve Andrian Salim
 */

// ------------------------------------------------------------------------

namespace O2System\Reactor\Models\Sql\Relations;

// ------------------------------------------------------------------------

use O2System\Database\DataObjects\Result;
use O2System\Reactor\Models\Sql;

/**
 * Class HasOne
 *
 * @package O2System\Reactor\Models\Sql\Relations
 */
class HasOne extends Sql\Relations\Abstracts\AbstractRelation
{
    /**
     * Get Result
     *
     * @return null
     */
    public function getResult()
    {
        if ($this->map->referenceModel->row instanceof Sql\DataObjects\Result\Row) {

The property referenceModel does not exist on O2System\Reactor\Models\Sql\Relations\Maps\Intermediary. Did you mean referenceTable?

            $criteria = $this->map->referenceModel->row->offsetGet($this->map->referenceModel->primaryKey);
            $conditions = [$this->map->relationForeignKey => $criteria];

The property relationForeignKey does not seem to exist on O2System\Reactor\Models\Sql\Relations\Maps\Intermediary.

            if ($this->map->relationModel instanceof Sql\Model) {

$this->map->relationModel is always a sub-type of O2System\Reactor\Models\Sql\Model.

                $result = $this->map->relationModel->qb
                    ->from($this->map->relationTable)
                    ->getWhere($conditions, 1);

                if ($result instanceof Result) {

$result is always a sub-type of O2System\Database\DataObjects\Result.

                    if ($result->count() > 0) {
                        $this->map->relationModel->result = new Sql\DataObjects\Result($result,

It seems like new O2System\Reactor\Models\Sql\DataObjects\Result($result, $this->map->relationModel) of type O2System\Reactor\Models\Sql\DataObjects\Result is incompatible with the declared type O2System\Framework\Models\Sql\DataObjects\Result of property $result.

                            $this->map->relationModel);

                        return $this->map->relationModel->row = $this->map->relationModel->result->first();
                    }
                }
            } elseif ( ! empty($this->map->relationTable)) {
                $result = $this->map->referenceModel->qb
                    ->from($this->map->relationTable)
                    ->getWhere($conditions, 1);

                if ($result instanceof Result) {
                    if ($result->count() > 0) {
                        $result = new Sql\DataObjects\Result($result, $this->map->referenceModel);

                        return $result->first();
                    }
                }
            }
        }

        return false;

The expression return false returns the type false which is incompatible with the documented return type null.

    }
}