O2System\Reactor\DataStructures\Commons\Money

Complexity

Total Complexity

11

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__toString()	0	5	1
A	currencyFormat()	0	3	1
A	shortFormat()	0	3	1
A	isSufficient()	0	7	2
A	numberFormat()	0	5	2
A	__construct()	0	16	4

<?php
/**
 * This file is part of the O2System Reactor package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author         Steeve Andrian Salim
 * @copyright      Copyright (c) Steeve Andrian Salim
 */

// ------------------------------------------------------------------------

namespace O2System\Reactor\DataStructures\Commons;

// ------------------------------------------------------------------------

use O2System\Spl\Patterns\Structural\Repository\AbstractRepository;

/**
 * Class Money
 * @package O2System\Reactor\DataStructures\Commons
 */
class Money extends AbstractRepository
{
    /**
     * Money::__construct
     *
     * @param int $amount
     */
    public function __construct($amount)
    {
        $money = [];
        if (is_numeric($amount)) {

The condition is_numeric($amount) is always true.

            $money[ 'amount' ] = (int)$amount;
        } elseif (is_array($amount)) {
            $money = $amount;
        }

        (int)$storage[ 'amount' ] = 0;

$storage was never initialized. Although not strictly required by PHP, it is generally a good practice to add $storage = array(); before regardless.

        $storage[ 'currency' ] = config()->getItem('units')->currency;

The method getItem() does not exist on O2System\Kernel\DataStructures\Config. Did you maybe mean getIterator()?

        $storage = array_merge($storage, $money);
        (int)$storage[ 'amount' ] = empty($storage[ 'amount' ]) ? 0 : abs($storage[ 'amount' ]);

        $this->storage = $storage;
    }

    // ------------------------------------------------------------------------

    /**
     * Money::shortFormat
     *
     * @param int $decimals
     *
     * @return string
     */
    public function shortFormat($decimals = 0)
    {
        return short_format($this->amount, $decimals);

The property amount does not exist on O2System\Reactor\DataStructures\Commons\Money. Since you implemented __get, consider adding a @property annotation.

    }

    // ------------------------------------------------------------------------

    /**
     * Money::numberFormat
     *
     * @param int    $decimals
     * @param string $thousandSeparator
     * @param string $decimalSeparator
     *
     * @return string
     */
    public function numberFormat($decimals = 0, $thousandSeparator = '.', $decimalSeparator = ',')

The parameter $decimalSeparator is not used and could be removed.

    {
        $decimalSeparator = $thousandSeparator === '.' ? ',' : '.';

        return number_format($this->amount, $decimals, $decimalSeparator, $thousandSeparator);

The property amount does not exist on O2System\Reactor\DataStructures\Commons\Money. Since you implemented __get, consider adding a @property annotation.

    }

    // ------------------------------------------------------------------------

    /**
     * Money::isSufficient
     *
     * @param int $amount
     *
     * @return bool
     */
    public function isSufficient($amount)
    {
        if ($amount < $this->amount) {

The property amount does not exist on O2System\Reactor\DataStructures\Commons\Money. Since you implemented __get, consider adding a @property annotation.

            return true;
        }

        return false;
    }

    // ------------------------------------------------------------------------

    /**
     * Money::__toString
     *
     * @return string
     */
    public function __toString()
    {
        loader()->loadHelper('number');

        return $this->currencyFormat();
    }

    // ------------------------------------------------------------------------

    /**
     * Money::currencyFormat
     *
     * @param string $locale
     * @param string $currency
     * @param bool   $addSpace
     *
     * @return string
     */
    public function currencyFormat($locale = 'id_ID', $currency = 'IDR', $addSpace = true)
    {
        return currency_format($this->amount, $locale, $currency, $addSpace);

The property amount does not exist on O2System\Reactor\DataStructures\Commons\Money. Since you implemented __get, consider adding a @property annotation.

    }
}